Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/glue_connection - add tagging support + use finder #21226

Merged
merged 8 commits into from
Oct 13, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 9, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueConnection_'

--- PASS: TestAccAWSGlueConnection_disappears (49.92s)
--- PASS: TestAccAWSGlueConnection_Kafka (68.51s)
--- PASS: TestAccAWSGlueConnection_basic (68.62s)
--- PASS: TestAccAWSGlueConnection_MongoDB (68.89s)
--- PASS: TestAccAWSGlueConnection_Network (102.00s)
--- PASS: TestAccAWSGlueConnection_Description (104.76s)
--- PASS: TestAccAWSGlueConnection_tags (145.16s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (145.89s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (806.53s)

$ make testacc TESTARGS='-run=TestAccDataSourceAwsGlueConnection_basic'

--- PASS: TestAccDataSourceAwsGlueConnection_basic (55.50s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Oct 9, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 9, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review October 9, 2021 20:44
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSGlueConnection_\|TestAccDataSourceAwsGlueConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_\|TestAccDataSourceAwsGlueConnection_ -timeout 180m
=== RUN   TestAccDataSourceAwsGlueConnection_basic
=== PAUSE TestAccDataSourceAwsGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_tags
=== PAUSE TestAccAWSGlueConnection_tags
=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN   TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN   TestAccAWSGlueConnection_Network
=== PAUSE TestAccAWSGlueConnection_Network
=== RUN   TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN   TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN   TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT  TestAccDataSourceAwsGlueConnection_basic
=== CONT  TestAccAWSGlueConnection_Description
=== CONT  TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== CONT  TestAccAWSGlueConnection_Kafka
=== CONT  TestAccAWSGlueConnection_tags
=== CONT  TestAccAWSGlueConnection_MongoDB
=== CONT  TestAccAWSGlueConnection_Network
=== CONT  TestAccAWSGlueConnection_basic
=== CONT  TestAccAWSGlueConnection_MatchCriteria
--- PASS: TestAccAWSGlueConnection_disappears (17.97s)
--- PASS: TestAccDataSourceAwsGlueConnection_basic (23.88s)
--- PASS: TestAccAWSGlueConnection_basic (24.38s)
--- PASS: TestAccAWSGlueConnection_Kafka (24.47s)
--- PASS: TestAccAWSGlueConnection_MongoDB (26.99s)
--- PASS: TestAccAWSGlueConnection_Description (37.49s)
--- PASS: TestAccAWSGlueConnection_Network (40.38s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (49.95s)
--- PASS: TestAccAWSGlueConnection_tags (53.38s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (675.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	678.505s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSGlueConnection_\|TestAccDataSourceAwsGlueConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_\|TestAccDataSourceAwsGlueConnection_ -timeout 180m
=== RUN   TestAccDataSourceAwsGlueConnection_basic
=== PAUSE TestAccDataSourceAwsGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_tags
=== PAUSE TestAccAWSGlueConnection_tags
=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN   TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN   TestAccAWSGlueConnection_Network
=== PAUSE TestAccAWSGlueConnection_Network
=== RUN   TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN   TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN   TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT  TestAccDataSourceAwsGlueConnection_basic
=== CONT  TestAccAWSGlueConnection_Description
=== CONT  TestAccAWSGlueConnection_MongoDB
=== CONT  TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_Network
=== CONT  TestAccAWSGlueConnection_MatchCriteria
=== CONT  TestAccAWSGlueConnection_tags
=== CONT  TestAccAWSGlueConnection_Kafka
=== CONT  TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== CONT  TestAccAWSGlueConnection_basic
--- PASS: TestAccAWSGlueConnection_disappears (21.57s)
--- PASS: TestAccDataSourceAwsGlueConnection_basic (25.59s)
--- PASS: TestAccAWSGlueConnection_MongoDB (25.80s)
--- PASS: TestAccAWSGlueConnection_basic (28.23s)
--- PASS: TestAccAWSGlueConnection_Kafka (28.43s)
--- PASS: TestAccAWSGlueConnection_Network (40.38s)
--- PASS: TestAccAWSGlueConnection_Description (42.15s)
--- PASS: TestAccAWSGlueConnection_tags (56.82s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (57.24s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (658.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	664.022s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9a75560 into hashicorp:main Oct 13, 2021
@github-actions github-actions bot added this to the v3.63.0 milestone Oct 13, 2021
@DrFaust92 DrFaust92 deleted the r/glue_connection_tags branch October 13, 2021 18:46
@ewbankkit ewbankkit mentioned this pull request Oct 13, 2021
@github-actions
Copy link

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants