Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_model_package_group_policy - new resource #21250

Merged

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerModelPackageGroupPolicy_'
--- PASS: TestAccAWSSagemakerModelPackageGroupPolicy_disappears (62.23s)
--- PASS: TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup (62.47s)
--- PASS: TestAccAWSSagemakerModelPackageGroupPolicy_basic (75.60s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 12, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Oct 12, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSSagemakerModelPackageGroupPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerModelPackageGroupPolicy_ -timeout 180m
=== RUN   TestAccAWSSagemakerModelPackageGroupPolicy_basic
=== PAUSE TestAccAWSSagemakerModelPackageGroupPolicy_basic
=== RUN   TestAccAWSSagemakerModelPackageGroupPolicy_disappears
=== PAUSE TestAccAWSSagemakerModelPackageGroupPolicy_disappears
=== RUN   TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup
=== PAUSE TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup
=== CONT  TestAccAWSSagemakerModelPackageGroupPolicy_basic
=== CONT  TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup
=== CONT  TestAccAWSSagemakerModelPackageGroupPolicy_disappears
--- PASS: TestAccAWSSagemakerModelPackageGroupPolicy_disappears (18.05s)
--- PASS: TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup (18.34s)
--- PASS: TestAccAWSSagemakerModelPackageGroupPolicy_basic (19.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.616s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSSagemakerModelPackageGroupPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerModelPackageGroupPolicy_ -timeout 180m
=== RUN   TestAccAWSSagemakerModelPackageGroupPolicy_basic
=== PAUSE TestAccAWSSagemakerModelPackageGroupPolicy_basic
=== RUN   TestAccAWSSagemakerModelPackageGroupPolicy_disappears
=== PAUSE TestAccAWSSagemakerModelPackageGroupPolicy_disappears
=== RUN   TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup
=== PAUSE TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup
=== CONT  TestAccAWSSagemakerModelPackageGroupPolicy_basic
=== CONT  TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup
=== CONT  TestAccAWSSagemakerModelPackageGroupPolicy_disappears
=== CONT  TestAccAWSSagemakerModelPackageGroupPolicy_basic
    provider_test.go:1168: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Model Package Group tf-acc-test-6564069402183459175: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 763adde9-0545-45f3-b9e9-e120c557655f
        
          with aws_sagemaker_model_package_group.test,
          on terraform_plugin_test.tf line 16, in resource "aws_sagemaker_model_package_group" "test":
          16: resource "aws_sagemaker_model_package_group" "test" {
        
=== CONT  TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup
    provider_test.go:1168: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Model Package Group tf-acc-test-490010508962676588: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 3e4d051d-eefc-4000-a701-d15315ae1ea5
        
          with aws_sagemaker_model_package_group.test,
          on terraform_plugin_test.tf line 16, in resource "aws_sagemaker_model_package_group" "test":
          16: resource "aws_sagemaker_model_package_group" "test" {
        
--- SKIP: TestAccAWSSagemakerModelPackageGroupPolicy_basic (8.93s)
--- SKIP: TestAccAWSSagemakerModelPackageGroupPolicy_disappears_modelPackageGroup (9.00s)
=== CONT  TestAccAWSSagemakerModelPackageGroupPolicy_disappears
    provider_test.go:1168: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Model Package Group tf-acc-test-1559244971369365071: UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 4d05ef0e-2e4e-4aff-8933-88f5e056be66
        
          with aws_sagemaker_model_package_group.test,
          on terraform_plugin_test.tf line 16, in resource "aws_sagemaker_model_package_group" "test":
          16: resource "aws_sagemaker_model_package_group" "test" {
        
--- SKIP: TestAccAWSSagemakerModelPackageGroupPolicy_disappears (15.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.110s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a7c46dc into hashicorp:main Oct 13, 2021
@github-actions github-actions bot added this to the v3.63.0 milestone Oct 13, 2021
@DrFaust92 DrFaust92 deleted the r/sagemaker_model_package_group_policy branch October 14, 2021 05:00
@github-actions
Copy link

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants