Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: aws/aws_imagebuilder_distribution_configuration Remove hard limit on distributions #21254

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

drewmullen
Copy link
Collaborator

@drewmullen drewmullen commented Oct 12, 2021

NOTE:

@bflad This PR was previously merged but it appears the code never made it to main.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21253

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsImageBuilderDistributionConfiguration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsImageBuilderDistributionConfiguration -timeout 180m
=== RUN   TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn
=== PAUSE TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_basic
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_basic
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_disappears
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_disappears
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Description
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Description
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns
=== RUN   TestAccAwsImageBuilderDistributionConfiguration_Tags
=== PAUSE TestAccAwsImageBuilderDistributionConfiguration_Tags
=== CONT  TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_basic
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Tags
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_disappears
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Description
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns
=== CONT  TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_disappears (41.47s)
--- PASS: TestAccAwsImageBuilderDistributionConfigurationDataSource_Arn (47.09s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_basic (52.39s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserGroups (53.82s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution (56.90s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_LaunchPermission_UserIds (80.17s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Name (80.31s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_TargetAccountIds (80.37s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Description (80.41s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_AmiTags (80.56s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_Description (80.70s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_LicenseConfigurationArns (80.75s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Distribution_AmiDistributionConfiguration_KmsKeyId (80.77s)
--- PASS: TestAccAwsImageBuilderDistributionConfiguration_Tags (91.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	94.383s

...

@github-actions github-actions bot added service/imagebuilder Issues and PRs that pertain to the imagebuilder service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Oct 12, 2021
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 12, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f9ee8ce into hashicorp:main Oct 13, 2021
@github-actions github-actions bot added this to the v3.63.0 milestone Oct 13, 2021
@github-actions
Copy link

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_imagebuilder_distribution_configuration: Attribute supports 50 item maximum
3 participants