Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_lex_slot_type: numeric version comparison for slot type #21509

Merged
merged 4 commits into from
Oct 27, 2021
Merged

r/aws_lex_slot_type: numeric version comparison for slot type #21509

merged 4 commits into from
Oct 27, 2021

Conversation

brenthc
Copy link
Contributor

@brenthc brenthc commented Oct 26, 2021 •
edited by ewbankkit

submitting more for raw material than merging. untested, but will test tomorrow.

Relates #20383.
Relates #21045.
Relates #21049.
Relates #21122.

@github-actions github-actions bot added service/lexmodels Issues and PRs that pertain to the lexmodels service. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Oct 26, 2021
@brenthc
Copy link
Contributor Author

brenthc commented Oct 26, 2021

@ewbankkit versioning in question

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 26, 2021
@ewbankkit ewbankkit changed the title numeric version comparison for slot type r/aws_lex_slot_type: numeric version comparison for slot type Oct 27, 2021
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Oct 27, 2021
ewbankkit
ewbankkit approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccLexModelBuildingSlotTypeDataSource_' PKG_NAME=internal/service/lexmodelbuilding   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexmodelbuilding/... -v -count 1 -parallel 20 -run=TestAccLexModelBuildingSlotTypeDataSource_ -timeout 180m
=== RUN   TestAccLexModelBuildingSlotTypeDataSource_basic
=== PAUSE TestAccLexModelBuildingSlotTypeDataSource_basic
=== RUN   TestAccLexModelBuildingSlotTypeDataSource_withVersion
=== PAUSE TestAccLexModelBuildingSlotTypeDataSource_withVersion
=== CONT  TestAccLexModelBuildingSlotTypeDataSource_basic
=== CONT  TestAccLexModelBuildingSlotTypeDataSource_withVersion
--- PASS: TestAccLexModelBuildingSlotTypeDataSource_basic (16.20s)
--- PASS: TestAccLexModelBuildingSlotTypeDataSource_withVersion (17.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodelbuilding	20.122s
% make testacc TESTARGS='-run=TestAccLexModelBuildingSlotType_' PKG_NAME=internal/service/lexmodelbuilding
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexmodelbuilding/... -v -count 1 -parallel 20 -run=TestAccLexModelBuildingSlotType_ -timeout 180m
=== RUN   TestAccLexModelBuildingSlotType_basic
=== PAUSE TestAccLexModelBuildingSlotType_basic
=== RUN   TestAccLexModelBuildingSlotType_createVersion
=== PAUSE TestAccLexModelBuildingSlotType_createVersion
=== RUN   TestAccLexModelBuildingSlotType_description
=== PAUSE TestAccLexModelBuildingSlotType_description
=== RUN   TestAccLexModelBuildingSlotType_enumerationValues
=== PAUSE TestAccLexModelBuildingSlotType_enumerationValues
=== RUN   TestAccLexModelBuildingSlotType_name
=== PAUSE TestAccLexModelBuildingSlotType_name
=== RUN   TestAccLexModelBuildingSlotType_valueSelectionStrategy
=== PAUSE TestAccLexModelBuildingSlotType_valueSelectionStrategy
=== RUN   TestAccLexModelBuildingSlotType_disappears
=== PAUSE TestAccLexModelBuildingSlotType_disappears
=== RUN   TestAccLexModelBuildingSlotType_computeVersion
=== PAUSE TestAccLexModelBuildingSlotType_computeVersion
=== CONT  TestAccLexModelBuildingSlotType_basic
=== CONT  TestAccLexModelBuildingSlotType_valueSelectionStrategy
=== CONT  TestAccLexModelBuildingSlotType_computeVersion
=== CONT  TestAccLexModelBuildingSlotType_disappears
=== CONT  TestAccLexModelBuildingSlotType_enumerationValues
=== CONT  TestAccLexModelBuildingSlotType_description
=== CONT  TestAccLexModelBuildingSlotType_name
=== CONT  TestAccLexModelBuildingSlotType_createVersion
--- PASS: TestAccLexModelBuildingSlotType_disappears (20.06s)
--- PASS: TestAccLexModelBuildingSlotType_basic (26.05s)
--- PASS: TestAccLexModelBuildingSlotType_computeVersion (46.48s)
--- PASS: TestAccLexModelBuildingSlotType_enumerationValues (49.42s)
--- PASS: TestAccLexModelBuildingSlotType_description (50.61s)
--- PASS: TestAccLexModelBuildingSlotType_createVersion (52.09s)
--- PASS: TestAccLexModelBuildingSlotType_name (54.21s)
--- PASS: TestAccLexModelBuildingSlotType_valueSelectionStrategy (58.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodelbuilding	62.084s
GovCloud
% make testacc TESTARGS='-run=TestAccLexModelBuildingSlotTypeDataSource_' PKG_NAME=internal/service/lexmodelbuilding
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexmodelbuilding/... -v -count 1 -parallel 20 -run=TestAccLexModelBuildingSlotTypeDataSource_ -timeout 180m
=== RUN   TestAccLexModelBuildingSlotTypeDataSource_basic
=== PAUSE TestAccLexModelBuildingSlotTypeDataSource_basic
=== RUN   TestAccLexModelBuildingSlotTypeDataSource_withVersion
=== PAUSE TestAccLexModelBuildingSlotTypeDataSource_withVersion
=== CONT  TestAccLexModelBuildingSlotTypeDataSource_basic
=== CONT  TestAccLexModelBuildingSlotTypeDataSource_withVersion
--- PASS: TestAccLexModelBuildingSlotTypeDataSource_withVersion (18.02s)
--- PASS: TestAccLexModelBuildingSlotTypeDataSource_basic (18.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodelbuilding	21.763s
% make testacc TESTARGS='-run=TestAccLexModelBuildingSlotType_' PKG_NAME=internal/service/lexmodelbuilding
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexmodelbuilding/... -v -count 1 -parallel 20 -run=TestAccLexModelBuildingSlotType_ -timeout 180m
=== RUN   TestAccLexModelBuildingSlotType_basic
=== PAUSE TestAccLexModelBuildingSlotType_basic
=== RUN   TestAccLexModelBuildingSlotType_createVersion
=== PAUSE TestAccLexModelBuildingSlotType_createVersion
=== RUN   TestAccLexModelBuildingSlotType_description
=== PAUSE TestAccLexModelBuildingSlotType_description
=== RUN   TestAccLexModelBuildingSlotType_enumerationValues
=== PAUSE TestAccLexModelBuildingSlotType_enumerationValues
=== RUN   TestAccLexModelBuildingSlotType_name
=== PAUSE TestAccLexModelBuildingSlotType_name
=== RUN   TestAccLexModelBuildingSlotType_valueSelectionStrategy
=== PAUSE TestAccLexModelBuildingSlotType_valueSelectionStrategy
=== RUN   TestAccLexModelBuildingSlotType_disappears
=== PAUSE TestAccLexModelBuildingSlotType_disappears
=== RUN   TestAccLexModelBuildingSlotType_computeVersion
=== PAUSE TestAccLexModelBuildingSlotType_computeVersion
=== CONT  TestAccLexModelBuildingSlotType_basic
=== CONT  TestAccLexModelBuildingSlotType_computeVersion
=== CONT  TestAccLexModelBuildingSlotType_enumerationValues
=== CONT  TestAccLexModelBuildingSlotType_createVersion
=== CONT  TestAccLexModelBuildingSlotType_disappears
=== CONT  TestAccLexModelBuildingSlotType_description
=== CONT  TestAccLexModelBuildingSlotType_name
=== CONT  TestAccLexModelBuildingSlotType_valueSelectionStrategy
--- PASS: TestAccLexModelBuildingSlotType_disappears (29.31s)
--- PASS: TestAccLexModelBuildingSlotType_basic (37.37s)
--- PASS: TestAccLexModelBuildingSlotType_enumerationValues (51.52s)
--- PASS: TestAccLexModelBuildingSlotType_computeVersion (54.19s)
--- PASS: TestAccLexModelBuildingSlotType_description (56.35s)
--- PASS: TestAccLexModelBuildingSlotType_createVersion (57.43s)
--- PASS: TestAccLexModelBuildingSlotType_valueSelectionStrategy (58.91s)
--- PASS: TestAccLexModelBuildingSlotType_name (59.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodelbuilding	65.203s

@ewbankkit
Copy link
Contributor

@brenthc Thanks for the contribution 🎉 👏.

@brenthc
Copy link
Contributor Author

brenthc commented Oct 27, 2021

You tested it? You have to make over 9 slot types to make sure it gets 10 instead of 9 to verify. I didn't get to it yet.

@ewbankkit
Copy link
Contributor

@brenthc No, I didn't test that. As the code was pretty much identical to the aws_lex_bot case I took it on faith.
Please go ahead and test with > 9 versions before I merge.

@brenthc
Copy link
Contributor Author

brenthc commented Oct 27, 2021

Current release (3.63.0):

$ for i in 1 2 1 2 1 2 1 2 1 2 1 2; do terraform apply -auto-approve -no-color -var-file=desc$i.tfvars | grep -E '^slot_type_version'; done
slot_type_version = "1"
slot_type_version = "2"
slot_type_version = "3"
slot_type_version = "4"
slot_type_version = "5"
slot_type_version = "6"
slot_type_version = "7"
slot_type_version = "8"
slot_type_version = "9"
slot_type_version = "9"
slot_type_version = "9"
slot_type_version = "9"

Build from main with this change:

$ for i in 1 2 1 2 1 2 1 2 1 2 1 2; do terraform apply -auto-approve -no-color -var-file=desc$i.tfvars | grep -E '^slot_type_version'; done
slot_type_version = "1"
slot_type_version = "2"
slot_type_version = "3"
slot_type_version = "4"
slot_type_version = "5"
slot_type_version = "6"
slot_type_version = "7"
slot_type_version = "8"
slot_type_version = "9"
slot_type_version = "10"
slot_type_version = "11"
slot_type_version = "12"

I think we're good!

@ewbankkit ewbankkit merged commit 83448eb into hashicorp:main Oct 27, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 27, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/lexmodels Issues and PRs that pertain to the lexmodels service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brenthc @ewbankkit @justinretzolk