Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix initialization of serviceData in internal/conns #21639

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

perryao
Copy link
Contributor

@perryao perryao commented Nov 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21637
Relates #21641

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Nov 4, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @perryao 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@YakDriver
Copy link
Member

@perryao Thank you so much!

@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Nov 4, 2021
@YakDriver YakDriver added this to the v3.64.1 milestone Nov 4, 2021
@YakDriver YakDriver self-assigned this Nov 4, 2021
@YakDriver YakDriver merged commit f96bae8 into hashicorp:main Nov 4, 2021
@github-actions github-actions bot modified the milestones: v3.64.1, v3.65.0 Nov 4, 2021
@YakDriver YakDriver modified the milestones: v3.65.0, v3.64.1 Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v3.64.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Provider Endpoints not working on 3.64.0
2 participants