Add eventual consistency protection to efs_file_system_policy

[joelthompson]

There was no retry logic around putting an EFS file system policy, which
would lead to errors when the same TF both creates a new IAM principal
(e.g., role) and tries to specify that principal in an EFS FS policy in
the same run. This adds retry logic when AWS returns an error about an
invalid principal in line with standard recommendations.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21716

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccEFSFileSystemPolicy' PKG_NAME=internal/service/efs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run=TestAccEFSFileSystemPolicy -timeout 180m
=== RUN   TestAccEFSFileSystemPolicy_basic
=== PAUSE TestAccEFSFileSystemPolicy_basic
=== RUN   TestAccEFSFileSystemPolicy_disappears
=== PAUSE TestAccEFSFileSystemPolicy_disappears
=== RUN   TestAccEFSFileSystemPolicy_policyBypass
=== PAUSE TestAccEFSFileSystemPolicy_policyBypass
=== CONT  TestAccEFSFileSystemPolicy_basic
=== CONT  TestAccEFSFileSystemPolicy_policyBypass
=== CONT  TestAccEFSFileSystemPolicy_disappears
--- PASS: TestAccEFSFileSystemPolicy_disappears (18.16s)
--- PASS: TestAccEFSFileSystemPolicy_basic (26.20s)
--- PASS: TestAccEFSFileSystemPolicy_policyBypass (27.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	29.112s

[jdebbink]

Please merge this.

[harshitp1987]

Please merge This

[arthurgurov]

Please merge this - we need it for our project too.

[phrytsen-gl]

@hc-github-team-terraform-aws Please, review the issue.

[n3mawashi]

Please merge this.

[mandrado]

I need this too.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEFSFileSystemPolicy_' PKG=efs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 2  -run=TestAccEFSFileSystemPolicy_ -timeout 180m
=== RUN   TestAccEFSFileSystemPolicy_basic
=== PAUSE TestAccEFSFileSystemPolicy_basic
=== RUN   TestAccEFSFileSystemPolicy_disappears
=== PAUSE TestAccEFSFileSystemPolicy_disappears
=== RUN   TestAccEFSFileSystemPolicy_policyBypass
=== PAUSE TestAccEFSFileSystemPolicy_policyBypass
=== RUN   TestAccEFSFileSystemPolicy_equivalentPolicies
=== PAUSE TestAccEFSFileSystemPolicy_equivalentPolicies
=== RUN   TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc
=== PAUSE TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc
=== CONT  TestAccEFSFileSystemPolicy_basic
=== CONT  TestAccEFSFileSystemPolicy_equivalentPolicies
--- PASS: TestAccEFSFileSystemPolicy_equivalentPolicies (69.53s)
=== CONT  TestAccEFSFileSystemPolicy_policyBypass
--- PASS: TestAccEFSFileSystemPolicy_basic (87.85s)
=== CONT  TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc
--- PASS: TestAccEFSFileSystemPolicy_policyBypass (84.45s)
=== CONT  TestAccEFSFileSystemPolicy_disappears
--- PASS: TestAccEFSFileSystemPolicy_equivalentPoliciesIAMPolicyDoc (67.84s)
--- PASS: TestAccEFSFileSystemPolicy_disappears (44.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	204.523s

[ewbankkit]

@joelthompson Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.