Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/security_group: add pagination to security group find method #21743

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Nov 11, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21628

Output from acceptance testing:

in progress

--- SKIP: TestAccEC2DefaultSecurityGroup_Classic_empty (0.00s)
--- SKIP: TestAccEC2DefaultSecurityGroup_Classic_basic (2.25s)
--- PASS: TestAccEC2SecurityGroupRule_expectInvalidTypeError (13.94s)
--- PASS: TestAccEC2SecurityGroupRule_expectInvalidCIDR (22.87s)
--- PASS: TestAccEC2SecurityGroupDataSource_basic (79.42s)
--- PASS: TestAccEC2SecurityGroupRule_Ingress_vpc (84.90s)
--- PASS: TestAccEC2SecurityGroupRule_PartialMatching_source (86.89s)
--- PASS: TestAccEC2SecurityGroupRule_Ingress_icmpv6 (87.70s)
--- PASS: TestAccEC2SecurityGroupRule_IngressSourceWithAccount_id (87.13s)
--- PASS: TestAccEC2SecurityGroupRule_egress (87.44s)
--- PASS: TestAccEC2SecurityGroupRule_multiIngress (89.19s)
--- PASS: TestAccEC2SecurityGroupRule_selfSource (90.34s)
--- PASS: TestAccEC2SecurityGroupRule_Ingress_protocol (92.10s)
--- PASS: TestAccEC2SecurityGroupRule_issue5310 (92.57s)
--- PASS: TestAccEC2SecurityGroupRule_Ingress_classic (92.99s)
--- PASS: TestAccEC2DefaultSecurityGroup_VPC_empty (95.00s)
--- PASS: TestAccEC2SecurityGroupRule_Ingress_ipv6 (95.06s)
--- PASS: TestAccEC2SecurityGroupRule_selfReference (95.44s)
--- PASS: TestAccEC2SecurityGroupRule_ingressDescription (86.25s)
--- PASS: TestAccEC2SecurityGroupRule_egressDescription (80.90s)
--- PASS: TestAccEC2SecurityGroupRule_prefixListEgress (105.06s)
--- PASS: TestAccEC2SecurityGroupRule_PartialMatching_basic (120.14s)
--- PASS: TestAccEC2DefaultSecurityGroup_VPC_basic (135.39s)
--- PASS: TestAccEC2SecurityGroupRule_MultipleRuleSearching_allProtocolCrash (81.93s)
--- PASS: TestAccEC2SecurityGroup_allowAll (95.14s)
--- PASS: TestAccEC2SecurityGroup_basic (94.43s)
--- PASS: TestAccEC2SecurityGroup_sourceSecurityGroup (96.81s)
--- PASS: TestAccEC2SecurityGroup_ipRangesWithSameRules (96.43s)
--- PASS: TestAccEC2SecurityGroup_ipRangeAndSecurityGroupWithSameRules (97.00s)
--- PASS: TestAccEC2SecurityGroup_ipv6 (97.20s)
--- PASS: TestAccEC2SecurityGroup_ruleGathering (109.50s)
--- PASS: TestAccEC2SecurityGroup_Name_generated (94.21s)
--- PASS: TestAccEC2SecurityGroup_Name_terraformPrefix (95.01s)
--- PASS: TestAccEC2SecurityGroupRule_IngressDescription_updates (152.75s)
--- SKIP: TestAccEC2SecurityGroup_defaultEgressClassic (2.48s)
--- PASS: TestAccEC2SecurityGroupRule_EgressDescription_updates (151.02s)
--- PASS: TestAccEC2SecurityGroupRule_race (238.18s)
--- PASS: TestAccEC2SecurityGroupRule_Description_allPorts (152.08s)
--- PASS: TestAccEC2SecurityGroupRule_DescriptionAllPorts_nonZeroPorts (151.71s)
--- PASS: TestAccEC2SecurityGroup_namePrefix (89.12s)
--- PASS: TestAccEC2SecurityGroup_NamePrefix_terraformPrefix (85.36s)
--- SKIP: TestAccEC2SecurityGroup_ingressWithCIDRAndSGsClassic (2.32s)
--- PASS: TestAccEC2SecurityGroup_invalidCIDRBlock (35.42s)
--- PASS: TestAccEC2SecurityGroup_self (86.41s)
--- PASS: TestAccEC2SecurityGroup_vpcProtoNumIngress (85.55s)
--- PASS: TestAccEC2SecurityGroup_vpcNegOneIngress (86.68s)
--- PASS: TestAccEC2SecurityGroup_vpc (88.51s)
--- PASS: TestAccEC2SecurityGroup_multiIngress (88.28s)
--- PASS: TestAccEC2SecurityGroup_ingressMode (211.57s)
--- PASS: TestAccEC2SecurityGroup_egressMode (212.60s)
--- PASS: TestAccEC2SecurityGroup_defaultEgressVPC (82.65s)
--- PASS: TestAccEC2SecurityGroup_drift (80.67s)
--- PASS: TestAccEC2SecurityGroupRule_multiDescription (232.49s)
--- PASS: TestAccEC2SecurityGroup_driftComplex (85.32s)
--- PASS: TestAccEC2SecurityGroup_cidrAndGroups (85.43s)
--- PASS: TestAccEC2SecurityGroup_ingressWithCIDRAndSGsVPC (81.27s)
--- PASS: TestAccEC2SecurityGroup_change (137.77s)
--- PASS: TestAccEC2SecurityGroup_failWithDiffMismatch (68.49s)
--- PASS: TestAccEC2SecurityGroup_ipv4AndIPv6Egress (76.82s)
--- PASS: TestAccEC2SecurityGroup_egressWithPrefixList (85.85s)
--- PASS: TestAccEC2SecurityGroup_ingressWithPrefixList (86.12s)
--- PASS: TestAccEC2SecurityGroupsDataSource_tag (50.79s)
--- PASS: TestAccEC2SecurityGroupsDataSource_filter (51.80s)
--- PASS: TestAccEC2SecurityGroup_ruleDescription (163.34s)
--- PASS: TestAccEC2SecurityGroup_tags (145.77s)
--- PASS: TestAccEC2SecurityGroup_ruleLimitCIDRBlockExceededAppend (107.30s)
--- PASS: TestAccEC2SecurityGroup_rulesDropOnError (79.60s)
--- PASS: TestAccEC2SecurityGroup_ruleLimitExceededAppend (120.76s)
--- PASS: TestAccEC2SecurityGroup_ruleLimitExceededPrepend (109.70s)
--- PASS: TestAccEC2SecurityGroup_ruleLimitExceededAllNew (97.70s)
--- PASS: TestAccEC2SecurityGroup_forceRevokeRulesFalse (1034.67s)
--- PASS: TestAccEC2SecurityGroup_forceRevokeRulesTrue (1057.82s)

--- PASS: TestAccELBLoadBalancer_generatesNameForZeroValue (41.39s)
--- PASS: TestAccELBLoadBalancer_healthCheck (72.06s)
--- PASS: TestAccELBLoadBalancer_availabilityZones (78.73s)
--- PASS: TestAccELBLoadBalancer_generatedName (81.78s)
--- PASS: TestAccELBLoadBalancer_timeout (97.46s)
--- PASS: TestAccELBLoadBalancer_basic (100.83s)
--- PASS: TestAccELBLoadBalancer_tags (116.84s)
--- PASS: TestAccELBLoadBalancer_disappears (123.14s)
--- PASS: TestAccELBLoadBalancer_fullCharacterRange (133.32s)
--- PASS: TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate (139.98s)
--- PASS: TestAccELBLoadBalancer_securityGroups (165.86s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_enabled (175.07s)
--- PASS: TestAccELBLoadBalancer_connectionDraining (181.25s)
--- PASS: TestAccELBLoadBalancer_Swap_subnets (181.50s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_disabled (187.16s)
--- PASS: TestAccELBLoadBalancer_listener (208.95s)
--- PASS: TestAccELBLoadBalancer_instanceAttaching (234.95s)
--- PASS: TestAccELBLoadBalancerDataSource_basic (255.27s)
--- PASS: TestAccELBLoadBalancer_namePrefix (256.26s)

@anGie44 anGie44 changed the title r/security_group: add pagination to security group finde method r/security_group: add pagination to security group find method Nov 11, 2021
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. labels Nov 11, 2021
@anGie44 anGie44 marked this pull request as ready for review November 11, 2021 22:52
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Nov 12, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2SecurityGroup_basic'    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2SecurityGroup_basic -timeout 180m
=== RUN   TestAccEC2SecurityGroup_basic
=== PAUSE TestAccEC2SecurityGroup_basic
=== CONT  TestAccEC2SecurityGroup_basic
--- PASS: TestAccEC2SecurityGroup_basic (29.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	34.648s

@anGie44 anGie44 added this to the v3.66.0 milestone Nov 12, 2021
@anGie44 anGie44 merged commit c3f781a into main Nov 12, 2021
@anGie44 anGie44 deleted the e-security-group-pagination branch November 12, 2021 18:01
github-actions bot pushed a commit that referenced this pull request Nov 12, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants