Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase aws_lambda_layer_version compatible_runtimes MaxItems value to 15 #21825

Conversation

Victorp99
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21742

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccLambdaLayerVersion' PKG_NAME=internal/service/lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaLayerVersion -timeout 180m
=== RUN   TestAccLambdaLayerVersionDataSource_basic
=== PAUSE TestAccLambdaLayerVersionDataSource_basic
=== RUN   TestAccLambdaLayerVersionDataSource_version
=== PAUSE TestAccLambdaLayerVersionDataSource_version
=== RUN   TestAccLambdaLayerVersionDataSource_runtime
=== PAUSE TestAccLambdaLayerVersionDataSource_runtime
=== RUN   TestAccLambdaLayerVersionDataSource_architectures
=== PAUSE TestAccLambdaLayerVersionDataSource_architectures
=== RUN   TestAccLambdaLayerVersion_basic
=== PAUSE TestAccLambdaLayerVersion_basic
=== RUN   TestAccLambdaLayerVersion_update
=== PAUSE TestAccLambdaLayerVersion_update
=== RUN   TestAccLambdaLayerVersion_s3
=== PAUSE TestAccLambdaLayerVersion_s3
=== RUN   TestAccLambdaLayerVersion_compatibleRuntimes
=== PAUSE TestAccLambdaLayerVersion_compatibleRuntimes
=== RUN   TestAccLambdaLayerVersion_compatibleArchitectures
=== PAUSE TestAccLambdaLayerVersion_compatibleArchitectures
=== RUN   TestAccLambdaLayerVersion_description
=== PAUSE TestAccLambdaLayerVersion_description
=== RUN   TestAccLambdaLayerVersion_licenseInfo
=== PAUSE TestAccLambdaLayerVersion_licenseInfo
=== CONT  TestAccLambdaLayerVersionDataSource_basic
=== CONT  TestAccLambdaLayerVersion_compatibleRuntimes
=== CONT  TestAccLambdaLayerVersion_licenseInfo
=== CONT  TestAccLambdaLayerVersion_description
=== CONT  TestAccLambdaLayerVersion_compatibleArchitectures
=== CONT  TestAccLambdaLayerVersionDataSource_architectures
=== CONT  TestAccLambdaLayerVersionDataSource_runtime
=== CONT  TestAccLambdaLayerVersion_update
=== CONT  TestAccLambdaLayerVersionDataSource_version
=== CONT  TestAccLambdaLayerVersion_s3
=== CONT  TestAccLambdaLayerVersion_basic
--- PASS: TestAccLambdaLayerVersion_basic (32.52s)
--- PASS: TestAccLambdaLayerVersion_s3 (36.13s)
--- PASS: TestAccLambdaLayerVersion_licenseInfo (38.63s)
--- PASS: TestAccLambdaLayerVersion_compatibleRuntimes (46.97s)
--- PASS: TestAccLambdaLayerVersionDataSource_version (50.76s)
--- PASS: TestAccLambdaLayerVersion_description (65.88s)
--- PASS: TestAccLambdaLayerVersionDataSource_basic (67.01s)
--- PASS: TestAccLambdaLayerVersion_update (73.70s)
--- PASS: TestAccLambdaLayerVersionDataSource_runtime (77.94s)
--- PASS: TestAccLambdaLayerVersionDataSource_architectures (108.37s)
--- PASS: TestAccLambdaLayerVersion_compatibleArchitectures (118.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	118.415s
...

@github-actions github-actions bot added service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Nov 18, 2021
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 18, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLambdaLayerVersion' PKG_NAME=internal/service/lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaLayerVersion -timeout 180m
=== RUN   TestAccLambdaLayerVersionDataSource_basic
=== PAUSE TestAccLambdaLayerVersionDataSource_basic
=== RUN   TestAccLambdaLayerVersionDataSource_version
=== PAUSE TestAccLambdaLayerVersionDataSource_version
=== RUN   TestAccLambdaLayerVersionDataSource_runtime
=== PAUSE TestAccLambdaLayerVersionDataSource_runtime
=== RUN   TestAccLambdaLayerVersionDataSource_architectures
=== PAUSE TestAccLambdaLayerVersionDataSource_architectures
=== RUN   TestAccLambdaLayerVersion_basic
=== PAUSE TestAccLambdaLayerVersion_basic
=== RUN   TestAccLambdaLayerVersion_update
=== PAUSE TestAccLambdaLayerVersion_update
=== RUN   TestAccLambdaLayerVersion_s3
=== PAUSE TestAccLambdaLayerVersion_s3
=== RUN   TestAccLambdaLayerVersion_compatibleRuntimes
=== PAUSE TestAccLambdaLayerVersion_compatibleRuntimes
=== RUN   TestAccLambdaLayerVersion_compatibleArchitectures
=== PAUSE TestAccLambdaLayerVersion_compatibleArchitectures
=== RUN   TestAccLambdaLayerVersion_description
=== PAUSE TestAccLambdaLayerVersion_description
=== RUN   TestAccLambdaLayerVersion_licenseInfo
=== PAUSE TestAccLambdaLayerVersion_licenseInfo
=== CONT  TestAccLambdaLayerVersionDataSource_basic
=== CONT  TestAccLambdaLayerVersion_compatibleRuntimes
=== CONT  TestAccLambdaLayerVersion_description
=== CONT  TestAccLambdaLayerVersion_basic
=== CONT  TestAccLambdaLayerVersion_s3
=== CONT  TestAccLambdaLayerVersionDataSource_runtime
=== CONT  TestAccLambdaLayerVersion_update
=== CONT  TestAccLambdaLayerVersion_licenseInfo
=== CONT  TestAccLambdaLayerVersionDataSource_architectures
=== CONT  TestAccLambdaLayerVersion_compatibleArchitectures
=== CONT  TestAccLambdaLayerVersionDataSource_version
--- PASS: TestAccLambdaLayerVersion_basic (37.57s)
--- PASS: TestAccLambdaLayerVersion_description (41.87s)
--- PASS: TestAccLambdaLayerVersion_compatibleRuntimes (51.64s)
--- PASS: TestAccLambdaLayerVersion_s3 (52.67s)
--- PASS: TestAccLambdaLayerVersion_licenseInfo (57.40s)
--- PASS: TestAccLambdaLayerVersionDataSource_version (63.00s)
--- PASS: TestAccLambdaLayerVersionDataSource_basic (68.41s)
--- PASS: TestAccLambdaLayerVersionDataSource_runtime (77.13s)
--- PASS: TestAccLambdaLayerVersion_update (88.04s)
--- PASS: TestAccLambdaLayerVersionDataSource_architectures (112.42s)
--- PASS: TestAccLambdaLayerVersion_compatibleArchitectures (118.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	124.155s

@ewbankkit
Copy link
Contributor

@Victorp99 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a29ec6f into hashicorp:main Nov 18, 2021
@github-actions github-actions bot added this to the v3.66.0 milestone Nov 18, 2021
@Victorp99
Copy link
Contributor Author

Thank you for the review!

@Victorp99 Victorp99 deleted the b-aws_lambda_layer_version-compatible-runtimes branch November 18, 2021 21:06
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda layer version max compatible runtimes
3 participants