Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagebuilder: Allow image recipe to be updated/replaced #21884

Merged
merged 7 commits into from Nov 23, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Nov 23, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19642
Relates #17137

Output from acceptance testing:

--- PASS: TestAccImageBuilderComponent_basic (21.37s)
--- PASS: TestAccImageBuilderComponent_changeDescription (23.79s)
--- PASS: TestAccImageBuilderComponent_description (23.02s)
--- PASS: TestAccImageBuilderComponent_disappears (17.76s)
--- PASS: TestAccImageBuilderComponent_kmsKeyID (28.42s)
--- PASS: TestAccImageBuilderComponent_Platform_windows (22.53s)
--- PASS: TestAccImageBuilderComponent_supportedOsVersions (18.70s)
--- PASS: TestAccImageBuilderComponent_tags (100.51s)
--- PASS: TestAccImageBuilderComponent_uri (41.03s)
--- PASS: TestAccImageBuilderComponentDataSource_arn (28.77s)
--- PASS: TestAccImageBuilderDistributionConfiguration_basic (27.20s)
--- PASS: TestAccImageBuilderDistributionConfiguration_description (40.19s)
--- PASS: TestAccImageBuilderDistributionConfiguration_disappears (16.49s)
--- PASS: TestAccImageBuilderDistributionConfiguration_distribution (28.34s)
--- PASS: TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs (40.70s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags (40.37s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description (50.01s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID (46.93s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name (53.62s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs (49.91s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups (23.46s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs (55.00s)
--- PASS: TestAccImageBuilderDistributionConfiguration_tags (57.28s)
--- PASS: TestAccImageBuilderDistributionConfigurationDataSource_arn (22.35s)
--- PASS: TestAccImageBuilderImage_basic (1453.20s)
--- PASS: TestAccImageBuilderImage_disappears (1197.38s)
--- PASS: TestAccImageBuilderImage_distributionARN (1705.86s)
--- PASS: TestAccImageBuilderImage_enhancedImageMetadataEnabled (1187.08s)
--- PASS: TestAccImageBuilderImage_ImageTests_imageTestsEnabled (1067.64s)
--- PASS: TestAccImageBuilderImage_ImageTests_timeoutMinutes (1445.54s)
--- PASS: TestAccImageBuilderImage_tags (1489.89s)
--- PASS: TestAccImageBuilderImageDataSource_ARN_aws (19.31s)
--- PASS: TestAccImageBuilderImageDataSource_ARN_self (1443.78s)
--- PASS: TestAccImageBuilderImagePipeline_basic (52.42s)
--- PASS: TestAccImageBuilderImagePipeline_description (71.10s)
--- PASS: TestAccImageBuilderImagePipeline_disappears (36.83s)
--- PASS: TestAccImageBuilderImagePipeline_distributionARN (80.59s)
--- PASS: TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled (74.71s)
--- PASS: TestAccImageBuilderImagePipeline_imageRecipeARN (75.79s)
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled (59.99s)
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes (66.84s)
--- PASS: TestAccImageBuilderImagePipeline_infrastructureARN (71.12s)
--- PASS: TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition (66.04s)
--- PASS: TestAccImageBuilderImagePipeline_Schedule_scheduleExpression (73.72s)
--- PASS: TestAccImageBuilderImagePipeline_status (73.55s)
--- PASS: TestAccImageBuilderImagePipeline_tags (101.55s)
--- PASS: TestAccImageBuilderImagePipelineDataSource_arn (49.69s)
--- PASS: TestAccImageBuilderImageRecipe_basic (33.89s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMapping_deviceName (24.74s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMapping_noDevice (33.68s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMapping_virtualName (28.50s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_deleteOnTermination (27.28s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_encrypted (26.86s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_iops (26.96s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_kmsKeyID (28.87s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_snapshotID (54.57s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeSize (26.94s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP2 (26.77s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP2 (51.24s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP3 (27.26s)
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP3 (49.23s)
--- PASS: TestAccImageBuilderImageRecipe_component (32.58s)
--- PASS: TestAccImageBuilderImageRecipe_description (31.76s)
--- PASS: TestAccImageBuilderImageRecipe_disappears (29.26s)
--- PASS: TestAccImageBuilderImageRecipe_pipelineUpdateDependency (64.27s)
--- PASS: TestAccImageBuilderImageRecipe_tags (115.28s)
--- PASS: TestAccImageBuilderImageRecipe_workingDirectory (33.17s)
--- PASS: TestAccImageBuilderImageRecipeDataSource_arn (37.35s)
--- PASS: TestAccImageBuilderImageRecipesDataSource_filter (32.53s)
--- PASS: TestAccImageBuilderImageRecipesDataSource_owner (21.81s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_basic (46.74s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_description (70.09s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_disappears (45.64s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceProfileName (81.32s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceTypes (75.16s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_keyPair (67.68s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName (112.57s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName (92.20s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix (115.88s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix (85.97s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_resourceTags (70.38s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs (114.51s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_snsTopicARN (75.28s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_subnetID (112.79s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_tags (134.68s)
--- PASS: TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure (70.31s)
--- PASS: TestAccImageBuilderInfrastructureConfigurationDataSource_arn (43.20s)

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 23, 2021
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 23, 2021
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 23, 2021
@YakDriver YakDriver added the bug Addresses a defect in current functionality. label Nov 23, 2021
@YakDriver YakDriver modified the milestone: Roadmap Nov 23, 2021
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Nov 23, 2021
@YakDriver YakDriver changed the title imagebuilder: Allow image recipe to be update/replaced imagebuilder: Allow image recipe to be updated/replaced Nov 23, 2021
@YakDriver YakDriver merged commit 3b60b4b into main Nov 23, 2021
@YakDriver YakDriver deleted the b-imagebuilder-replace-dep branch November 23, 2021 23:38
@github-actions github-actions bot added this to the v3.67.0 milestone Nov 23, 2021
github-actions bot pushed a commit that referenced this pull request Nov 23, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_imagebuilder_image_recipe can't be replaced due to dependency on aws_imagebuilder_image_pipeline
1 participant