r/aws_kinesis_stream: add stream_mode attribute #22002

roberth-k · 2021-12-02T01:15:26Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21972

Note that this PR flattens the stream_mode_details, i.e. stream_mode is a top-level attribute of aws_kinesis_stream.

Output from acceptance testing:

$ make testacc PKG=kinesis TESTS=TestAccKinesisStream_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStream_' -timeout 180m
=== RUN   TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN   TestAccKinesisStream_createMultipleConcurrentStreams
=== PAUSE TestAccKinesisStream_createMultipleConcurrentStreams
=== RUN   TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== RUN   TestAccKinesisStream_encryption
=== PAUSE TestAccKinesisStream_encryption
=== RUN   TestAccKinesisStream_shardCount
=== PAUSE TestAccKinesisStream_shardCount
=== RUN   TestAccKinesisStream_retentionPeriod
=== PAUSE TestAccKinesisStream_retentionPeriod
=== RUN   TestAccKinesisStream_shardLevelMetrics
=== PAUSE TestAccKinesisStream_shardLevelMetrics
=== RUN   TestAccKinesisStream_enforceConsumerDeletion
=== PAUSE TestAccKinesisStream_enforceConsumerDeletion
=== RUN   TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN   TestAccKinesisStream_updateKMSKeyID
=== PAUSE TestAccKinesisStream_updateKMSKeyID
=== RUN   TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== RUN   TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
=== PAUSE TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
=== RUN   TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== CONT  TestAccKinesisStream_basic
=== CONT  TestAccKinesisStream_enforceConsumerDeletion
=== CONT  TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_createMultipleConcurrentStreams
=== CONT  TestAccKinesisStream_updateKMSKeyID
=== CONT  TestAccKinesisStream_tags
=== CONT  TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== CONT  TestAccKinesisStream_shardCount
=== CONT  TestAccKinesisStream_shardLevelMetrics
=== CONT  TestAccKinesisStream_encryption
=== CONT  TestAccKinesisStream_retentionPeriod
=== CONT  TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== CONT  TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
--- PASS: TestAccKinesisStream_basicOnDemand (64.85s)
--- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (66.67s)
--- PASS: TestAccKinesisStream_enforceConsumerDeletion (76.72s)
--- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (97.42s)
--- PASS: TestAccKinesisStream_basic (101.60s)
--- PASS: TestAccKinesisStream_retentionPeriod (123.84s)
--- PASS: TestAccKinesisStream_shardCount (131.42s)
--- PASS: TestAccKinesisStream_updateKMSKeyID (143.66s)
--- PASS: TestAccKinesisStream_shardLevelMetrics (144.77s)
--- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (166.42s)
--- PASS: TestAccKinesisStream_tags (174.10s)
--- PASS: TestAccKinesisStream_encryption (179.46s)
--- PASS: TestAccKinesisStream_switchBetweenProvisionedAndOnDemand (237.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    239.318s

$ make testacc PKG=kinesis TESTS=TestAccKinesisStreamDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStreamDataSource_' -timeout 180m
=== RUN   TestAccKinesisStreamDataSource_basic
=== PAUSE TestAccKinesisStreamDataSource_basic
=== CONT  TestAccKinesisStreamDataSource_basic
--- PASS: TestAccKinesisStreamDataSource_basic (128.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    130.742s

github-actions · 2021-12-02T01:15:53Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

ewbankkit · 2021-12-02T18:49:23Z

@xxx Thanks for the contribution 🎉 👏.
We do prefer that attributes do not get flattened. Could you please update this PR to define the attribute as

"stream_mode_details": {
	Type:     schema.TypeList,
	Optional: true,
	MaxItems: 1,
	Elem: &schema.Resource{
		Schema: map[string]*schema.Schema{
			"stream_mode": {
				Type:         schema.TypeString,
				Optional:     true,
				Default:      kinesis.StreamModeProvisioned,
				ValidateFunc: validation.StringInSlice(kinesis.StreamMode_Values(), false),
			},
		},
	},
},

…m-stream_mode

roberth-k · 2021-12-05T23:55:59Z

@ewbankkit That's now been introduced.

…ustomizeDiff function so it runs during 'terraform plan'.

Acceptance test output: % make testacc PKG=kinesis TESTS=TestAccKinesisStream_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStream_' -timeout 180m === RUN TestAccKinesisStream_basic === PAUSE TestAccKinesisStream_basic === RUN TestAccKinesisStream_createMultipleConcurrentStreams === PAUSE TestAccKinesisStream_createMultipleConcurrentStreams === RUN TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === RUN TestAccKinesisStream_encryption === PAUSE TestAccKinesisStream_encryption === RUN TestAccKinesisStream_shardCount === PAUSE TestAccKinesisStream_shardCount === RUN TestAccKinesisStream_retentionPeriod === PAUSE TestAccKinesisStream_retentionPeriod === RUN TestAccKinesisStream_shardLevelMetrics === PAUSE TestAccKinesisStream_shardLevelMetrics === RUN TestAccKinesisStream_enforceConsumerDeletion === PAUSE TestAccKinesisStream_enforceConsumerDeletion === RUN TestAccKinesisStream_tags === PAUSE TestAccKinesisStream_tags === RUN TestAccKinesisStream_updateKMSKeyID === PAUSE TestAccKinesisStream_updateKMSKeyID === RUN TestAccKinesisStream_basicOnDemand === PAUSE TestAccKinesisStream_basicOnDemand === RUN TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === PAUSE TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === RUN TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === CONT TestAccKinesisStream_basic === CONT TestAccKinesisStream_enforceConsumerDeletion === CONT TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === CONT TestAccKinesisStream_basicOnDemand === CONT TestAccKinesisStream_retentionPeriod === CONT TestAccKinesisStream_updateKMSKeyID === CONT TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === CONT TestAccKinesisStream_tags === CONT TestAccKinesisStream_shardLevelMetrics === CONT TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === CONT TestAccKinesisStream_encryption === CONT TestAccKinesisStream_createMultipleConcurrentStreams === CONT TestAccKinesisStream_shardCount --- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (58.04s) --- PASS: TestAccKinesisStream_basic (69.06s) --- PASS: TestAccKinesisStream_basicOnDemand (69.08s) --- PASS: TestAccKinesisStream_enforceConsumerDeletion (90.38s) --- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (95.21s) --- PASS: TestAccKinesisStream_retentionPeriod (112.04s) --- PASS: TestAccKinesisStream_shardCount (121.26s) --- PASS: TestAccKinesisStream_shardLevelMetrics (132.47s) --- PASS: TestAccKinesisStream_tags (150.61s) --- PASS: TestAccKinesisStream_updateKMSKeyID (155.86s) --- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (165.18s) --- PASS: TestAccKinesisStream_encryption (166.91s) --- PASS: TestAccKinesisStream_switchBetweenProvisionedAndOnDemand (221.43s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kinesis 225.446s

Acceptance test output: % make testacc PKG=kinesis TESTS=TestAccKinesisStream_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStream_' -timeout 180m === RUN TestAccKinesisStream_basic === PAUSE TestAccKinesisStream_basic === RUN TestAccKinesisStream_disappears === PAUSE TestAccKinesisStream_disappears === RUN TestAccKinesisStream_createMultipleConcurrentStreams === PAUSE TestAccKinesisStream_createMultipleConcurrentStreams === RUN TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === RUN TestAccKinesisStream_encryption === PAUSE TestAccKinesisStream_encryption === RUN TestAccKinesisStream_shardCount === PAUSE TestAccKinesisStream_shardCount === RUN TestAccKinesisStream_retentionPeriod === PAUSE TestAccKinesisStream_retentionPeriod === RUN TestAccKinesisStream_shardLevelMetrics === PAUSE TestAccKinesisStream_shardLevelMetrics === RUN TestAccKinesisStream_enforceConsumerDeletion === PAUSE TestAccKinesisStream_enforceConsumerDeletion === RUN TestAccKinesisStream_tags === PAUSE TestAccKinesisStream_tags === RUN TestAccKinesisStream_updateKMSKeyID === PAUSE TestAccKinesisStream_updateKMSKeyID === RUN TestAccKinesisStream_basicOnDemand === PAUSE TestAccKinesisStream_basicOnDemand === RUN TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === PAUSE TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === RUN TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === CONT TestAccKinesisStream_basic === CONT TestAccKinesisStream_enforceConsumerDeletion === CONT TestAccKinesisStream_shardLevelMetrics === CONT TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === CONT TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === CONT TestAccKinesisStream_retentionPeriod === CONT TestAccKinesisStream_basicOnDemand === CONT TestAccKinesisStream_updateKMSKeyID === CONT TestAccKinesisStream_tags === CONT TestAccKinesisStream_createMultipleConcurrentStreams === CONT TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === CONT TestAccKinesisStream_shardCount === CONT TestAccKinesisStream_encryption === CONT TestAccKinesisStream_disappears --- PASS: TestAccKinesisStream_enforceConsumerDeletion (57.05s) --- PASS: TestAccKinesisStream_basic (57.13s) --- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (62.10s) --- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (68.79s) --- PASS: TestAccKinesisStream_disappears (79.47s) --- PASS: TestAccKinesisStream_retentionPeriod (100.94s) --- PASS: TestAccKinesisStream_basicOnDemand (108.42s) --- PASS: TestAccKinesisStream_shardCount (111.80s) --- PASS: TestAccKinesisStream_updateKMSKeyID (122.08s) --- PASS: TestAccKinesisStream_tags (128.86s) --- PASS: TestAccKinesisStream_shardLevelMetrics (130.74s) --- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (136.09s) --- PASS: TestAccKinesisStream_encryption (156.16s) --- PASS: TestAccKinesisStream_switchBetweenProvisionedAndOnDemand (210.61s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kinesis 214.338s

Acceptance test output: % make testacc PKG=kinesis TESTS=TestAccKinesisStream_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStream_' -timeout 180m === RUN TestAccKinesisStream_basic === PAUSE TestAccKinesisStream_basic === RUN TestAccKinesisStream_disappears === PAUSE TestAccKinesisStream_disappears === RUN TestAccKinesisStream_createMultipleConcurrentStreams === PAUSE TestAccKinesisStream_createMultipleConcurrentStreams === RUN TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === RUN TestAccKinesisStream_encryption === PAUSE TestAccKinesisStream_encryption === RUN TestAccKinesisStream_shardCount === PAUSE TestAccKinesisStream_shardCount === RUN TestAccKinesisStream_retentionPeriod === PAUSE TestAccKinesisStream_retentionPeriod === RUN TestAccKinesisStream_shardLevelMetrics === PAUSE TestAccKinesisStream_shardLevelMetrics === RUN TestAccKinesisStream_enforceConsumerDeletion === PAUSE TestAccKinesisStream_enforceConsumerDeletion === RUN TestAccKinesisStream_tags === PAUSE TestAccKinesisStream_tags === RUN TestAccKinesisStream_updateKMSKeyID === PAUSE TestAccKinesisStream_updateKMSKeyID === RUN TestAccKinesisStream_basicOnDemand === PAUSE TestAccKinesisStream_basicOnDemand === RUN TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === PAUSE TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === RUN TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === CONT TestAccKinesisStream_basic === CONT TestAccKinesisStream_enforceConsumerDeletion === CONT TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === CONT TestAccKinesisStream_encryption === CONT TestAccKinesisStream_shardLevelMetrics === CONT TestAccKinesisStream_retentionPeriod === CONT TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === CONT TestAccKinesisStream_shardCount === CONT TestAccKinesisStream_createMultipleConcurrentStreams === CONT TestAccKinesisStream_disappears === CONT TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === CONT TestAccKinesisStream_tags === CONT TestAccKinesisStream_basicOnDemand === CONT TestAccKinesisStream_updateKMSKeyID --- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (47.52s) --- PASS: TestAccKinesisStream_enforceConsumerDeletion (56.61s) --- PASS: TestAccKinesisStream_disappears (66.08s) --- PASS: TestAccKinesisStream_basic (71.44s) --- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (77.51s) --- PASS: TestAccKinesisStream_shardCount (89.02s) --- PASS: TestAccKinesisStream_shardLevelMetrics (110.64s) --- PASS: TestAccKinesisStream_retentionPeriod (113.40s) --- PASS: TestAccKinesisStream_tags (128.41s) --- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (136.12s) --- PASS: TestAccKinesisStream_encryption (139.08s) --- PASS: TestAccKinesisStream_switchBetweenProvisionedAndOnDemand (185.77s) --- PASS: TestAccKinesisStream_updateKMSKeyID (189.78s) --- PASS: TestAccKinesisStream_basicOnDemand (273.48s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kinesis 277.207s % make testacc PKG=kinesis TESTS=TestAccKinesisStreamDataSource_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStreamDataSource_' -timeout 180m === RUN TestAccKinesisStreamDataSource_basic === PAUSE TestAccKinesisStreamDataSource_basic === CONT TestAccKinesisStreamDataSource_basic --- PASS: TestAccKinesisStreamDataSource_basic (105.71s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kinesis 112.345s

Acceptance test output: % make testacc PKG=kinesis TESTS=TestAccKinesisStream_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStream_' -timeout 180m === RUN TestAccKinesisStream_basic === PAUSE TestAccKinesisStream_basic === RUN TestAccKinesisStream_disappears === PAUSE TestAccKinesisStream_disappears === RUN TestAccKinesisStream_createMultipleConcurrentStreams === PAUSE TestAccKinesisStream_createMultipleConcurrentStreams === RUN TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === RUN TestAccKinesisStream_encryption === PAUSE TestAccKinesisStream_encryption === RUN TestAccKinesisStream_shardCount === PAUSE TestAccKinesisStream_shardCount === RUN TestAccKinesisStream_retentionPeriod === PAUSE TestAccKinesisStream_retentionPeriod === RUN TestAccKinesisStream_shardLevelMetrics === PAUSE TestAccKinesisStream_shardLevelMetrics === RUN TestAccKinesisStream_enforceConsumerDeletion === PAUSE TestAccKinesisStream_enforceConsumerDeletion === RUN TestAccKinesisStream_tags === PAUSE TestAccKinesisStream_tags === RUN TestAccKinesisStream_updateKMSKeyID === PAUSE TestAccKinesisStream_updateKMSKeyID === RUN TestAccKinesisStream_basicOnDemand === PAUSE TestAccKinesisStream_basicOnDemand === RUN TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === PAUSE TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === RUN TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === CONT TestAccKinesisStream_basic === CONT TestAccKinesisStream_enforceConsumerDeletion === CONT TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError === CONT TestAccKinesisStream_disappears === CONT TestAccKinesisStream_encryption === CONT TestAccKinesisStream_shardLevelMetrics === CONT TestAccKinesisStream_retentionPeriod === CONT TestAccKinesisStream_switchBetweenProvisionedAndOnDemand === CONT TestAccKinesisStream_shardCount === CONT TestAccKinesisStream_updateKMSKeyID === CONT TestAccKinesisStream_createMultipleConcurrentStreams === CONT TestAccKinesisStream_basicOnDemand === CONT TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination === CONT TestAccKinesisStream_tags --- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (44.74s) --- PASS: TestAccKinesisStream_basic (54.06s) --- PASS: TestAccKinesisStream_basicOnDemand (54.12s) --- PASS: TestAccKinesisStream_enforceConsumerDeletion (54.13s) --- PASS: TestAccKinesisStream_disappears (61.82s) --- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (70.00s) --- PASS: TestAccKinesisStream_shardCount (95.36s) --- PASS: TestAccKinesisStream_shardLevelMetrics (108.61s) --- PASS: TestAccKinesisStream_encryption (131.75s) --- PASS: TestAccKinesisStream_tags (132.09s) --- PASS: TestAccKinesisStream_updateKMSKeyID (134.18s) --- PASS: TestAccKinesisStream_retentionPeriod (142.53s) --- PASS: TestAccKinesisStream_switchBetweenProvisionedAndOnDemand (191.17s) --- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (195.74s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/kinesis 199.328s

ewbankkit

LGTM 🚀.

% make testacc PKG=kinesis TESTS=TestAccKinesisStream_  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStream_' -timeout 180m
=== RUN   TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN   TestAccKinesisStream_disappears
=== PAUSE TestAccKinesisStream_disappears
=== RUN   TestAccKinesisStream_createMultipleConcurrentStreams
=== PAUSE TestAccKinesisStream_createMultipleConcurrentStreams
=== RUN   TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== RUN   TestAccKinesisStream_encryption
=== PAUSE TestAccKinesisStream_encryption
=== RUN   TestAccKinesisStream_shardCount
=== PAUSE TestAccKinesisStream_shardCount
=== RUN   TestAccKinesisStream_retentionPeriod
=== PAUSE TestAccKinesisStream_retentionPeriod
=== RUN   TestAccKinesisStream_shardLevelMetrics
=== PAUSE TestAccKinesisStream_shardLevelMetrics
=== RUN   TestAccKinesisStream_enforceConsumerDeletion
=== PAUSE TestAccKinesisStream_enforceConsumerDeletion
=== RUN   TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN   TestAccKinesisStream_updateKMSKeyID
=== PAUSE TestAccKinesisStream_updateKMSKeyID
=== RUN   TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== RUN   TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
=== PAUSE TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
=== RUN   TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== CONT  TestAccKinesisStream_basic
=== CONT  TestAccKinesisStream_enforceConsumerDeletion
=== CONT  TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== CONT  TestAccKinesisStream_disappears
=== CONT  TestAccKinesisStream_encryption
=== CONT  TestAccKinesisStream_shardLevelMetrics
=== CONT  TestAccKinesisStream_retentionPeriod
=== CONT  TestAccKinesisStream_switchBetweenProvisionedAndOnDemand
=== CONT  TestAccKinesisStream_shardCount
=== CONT  TestAccKinesisStream_updateKMSKeyID
=== CONT  TestAccKinesisStream_createMultipleConcurrentStreams
=== CONT  TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== CONT  TestAccKinesisStream_tags
--- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (44.74s)
--- PASS: TestAccKinesisStream_basic (54.06s)
--- PASS: TestAccKinesisStream_basicOnDemand (54.12s)
--- PASS: TestAccKinesisStream_enforceConsumerDeletion (54.13s)
--- PASS: TestAccKinesisStream_disappears (61.82s)
--- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (70.00s)
--- PASS: TestAccKinesisStream_shardCount (95.36s)
--- PASS: TestAccKinesisStream_shardLevelMetrics (108.61s)
--- PASS: TestAccKinesisStream_encryption (131.75s)
--- PASS: TestAccKinesisStream_tags (132.09s)
--- PASS: TestAccKinesisStream_updateKMSKeyID (134.18s)
--- PASS: TestAccKinesisStream_retentionPeriod (142.53s)
--- PASS: TestAccKinesisStream_switchBetweenProvisionedAndOnDemand (191.17s)
--- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (195.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	199.328s
% make testacc PKG=kinesis TESTS=TestAccKinesisStreamDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStreamDataSource_' -timeout 180m
=== RUN   TestAccKinesisStreamDataSource_basic
=== PAUSE TestAccKinesisStreamDataSource_basic
=== CONT  TestAccKinesisStreamDataSource_basic
--- PASS: TestAccKinesisStreamDataSource_basic (105.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	112.345s

ewbankkit · 2021-12-06T23:08:07Z

@roberth-k Thanks for the contribution 🎉 👏.

…s can be combined with single HasChanges() call'.

…ws/aws-sdk-go/service/kinesis.StreamDescription) is never used (unparam)'.

rpalanisamy · 2021-12-07T07:36:02Z

@roberth-k , @ewbankkit , Thank you so much for putting this feature together. we are actually waiting for this release. when can we expect the release v3.69.0 in GA ?

ewbankkit · 2021-12-07T11:19:09Z

We usually release on Thursdays.

github-actions · 2021-12-10T00:39:45Z

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-27T02:34:13Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

roberth-k added 4 commits December 2, 2021 01:17

r/aws_kinesis_stream: add stream_mode attribute

d0722c7

d/aws_kinesis_stream: add stream_mode attribute

32ace8b

check stream_mode in the basic stream test

7a4764d

add changelog entry

c47d7d2

roberth-k force-pushed the f-aws_kinesis_stream-stream_mode branch from 67c8109 to c47d7d2 Compare December 2, 2021 01:18

github-actions bot added documentation Introduces or discusses updates to documentation. service/kinesis Issues and PRs that pertain to the kinesis service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 2, 2021

roberth-k mentioned this pull request Dec 2, 2021

r/aws_kinesis_stream: support on-demand capacity mode #21972

Closed

roberth-k added 5 commits December 5, 2021 21:14

r/aws_kinesis_stream: un-flatten stream_mode

c01ee16

d/aws_kinesis_stream: un-flatten stream_mode

7e6674b

fixup

5f19699

Merge remote-tracking branch 'upstream/main' into f-aws_kinesis_strea…

fbdcff4

…m-stream_mode

fixup

6316dfd

roberth-k and others added 5 commits December 6, 2021 02:17

walk back goland's new defaults

47a2b72

Tweak CHANGELOG entry.

a093dd9

Alphabetic ordering for attributes.

de82f1a

r/aws_kinesis_stream: Move 'validateStreamModeAndShardCount' into a C…

08e0bc4

…ustomizeDiff function so it runs during 'terraform plan'.

Reorder functions.

94c2547

ewbankkit added 2 commits December 6, 2021 11:12

johhnsmmith198 mentioned this pull request Dec 6, 2021

On-demand Kinesis Stream hashicorp/terraform#30074

Closed

Use 'FindStreamByName' in resource Read.

d6b5554

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 6, 2021

ewbankkit added 2 commits December 6, 2021 17:37

ewbankkit approved these changes Dec 6, 2021

View reviewed changes

ewbankkit added 2 commits December 6, 2021 18:28

Fix providerlint error: 'R005: multiple ResourceData.HasChange() call…

e8da350

…s can be combined with single HasChanges() call'.

Fix golangci-lint error: 'waitStreamUpdated - result 0 (*github.com/a…

9d05fb1

…ws/aws-sdk-go/service/kinesis.StreamDescription) is never used (unparam)'.

ewbankkit merged commit d212e80 into hashicorp:main Dec 7, 2021

github-actions bot added this to the v3.69.0 milestone Dec 7, 2021

ewbankkit mentioned this pull request Dec 7, 2021

r/aws_kinesis_stream: Test with shard_count > 100 #22090

Merged

roberth-k deleted the f-aws_kinesis_stream-stream_mode branch January 16, 2022 20:23

github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_kinesis_stream: add stream_mode attribute #22002

r/aws_kinesis_stream: add stream_mode attribute #22002

roberth-k commented Dec 2, 2021

github-actions bot commented Dec 2, 2021

ewbankkit commented Dec 2, 2021 •

edited

roberth-k commented Dec 5, 2021

ewbankkit left a comment

ewbankkit commented Dec 6, 2021

rpalanisamy commented Dec 7, 2021

ewbankkit commented Dec 7, 2021

github-actions bot commented Dec 10, 2021

github-actions bot commented May 27, 2022

r/aws_kinesis_stream: add stream_mode attribute #22002

r/aws_kinesis_stream: add stream_mode attribute #22002

Conversation

roberth-k commented Dec 2, 2021

Community Note

github-actions bot commented Dec 2, 2021

ewbankkit commented Dec 2, 2021 • edited

roberth-k commented Dec 5, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Dec 6, 2021

rpalanisamy commented Dec 7, 2021

ewbankkit commented Dec 7, 2021

github-actions bot commented Dec 10, 2021

github-actions bot commented May 27, 2022

ewbankkit commented Dec 2, 2021 •

edited