Add a subnet CIDR reservation resource

[georgebuckerfield]

This adds a resource - aws_subnet_cidr_reservation - which manages CIDR reservations in subnets.

Unfortunately there is no way to retrieve information about a reservation using it's ID - I can't find any other way to do it than retrieve all reservations for a subnet and then loop through them (the filters suggested in the API docs don't work at all either from what I can tell). I have also not implemented tags - again the API docs seem to be wrong here.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21897

Output from acceptance testing:

make testacc TESTS=TestAccEC2SubnetCidrReservation PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SubnetCidrReservation' -timeout 180m
=== RUN   TestAccEC2SubnetCidrReservation_basic
=== PAUSE TestAccEC2SubnetCidrReservation_basic
=== RUN   TestAccEC2SubnetCidrReservation_Ipv6
=== PAUSE TestAccEC2SubnetCidrReservation_Ipv6
=== RUN   TestAccEC2SubnetCidrReservation_disappears
=== PAUSE TestAccEC2SubnetCidrReservation_disappears
=== CONT  TestAccEC2SubnetCidrReservation_basic
=== CONT  TestAccEC2SubnetCidrReservation_disappears
=== CONT  TestAccEC2SubnetCidrReservation_Ipv6
--- PASS: TestAccEC2SubnetCidrReservation_disappears (31.52s)
--- PASS: TestAccEC2SubnetCidrReservation_Ipv6 (36.45s)
--- PASS: TestAccEC2SubnetCidrReservation_basic (36.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	39.401s

[github-actions]

Welcome @georgebuckerfield 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

@georgebuckerfield Thanks for the contribution.
Everything is looking good so far.
Could you please rename the resource from aws_subnet_cidr_reservation to aws_ec2_subnet_cidr_reservation to conform to our resource naming guildlines.

[t0rr3sp3dr0]

Is this PR still in draft or is it ready to be reviewed and merged?

[georgebuckerfield]

Is this PR still in draft or is it ready to be reviewed and merged?

I think it's ready for a review now. I haven't added a docs page for it yet - but I should be able to get to that today.

[samuel-form3]

lgtm

[ewbankkit]

Adding documentation will fix the tfproviderdocs CI failure.

Tests are passing:

% make testacc TESTS=TestAccEC2SubnetCidrReservation_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SubnetCidrReservation_' -timeout 180m
=== RUN   TestAccEC2SubnetCidrReservation_basic
=== PAUSE TestAccEC2SubnetCidrReservation_basic
=== RUN   TestAccEC2SubnetCidrReservation_Ipv6
=== PAUSE TestAccEC2SubnetCidrReservation_Ipv6
=== RUN   TestAccEC2SubnetCidrReservation_disappears
=== PAUSE TestAccEC2SubnetCidrReservation_disappears
=== CONT  TestAccEC2SubnetCidrReservation_basic
=== CONT  TestAccEC2SubnetCidrReservation_disappears
=== CONT  TestAccEC2SubnetCidrReservation_Ipv6
--- PASS: TestAccEC2SubnetCidrReservation_disappears (27.47s)
--- PASS: TestAccEC2SubnetCidrReservation_basic (29.55s)
--- PASS: TestAccEC2SubnetCidrReservation_Ipv6 (29.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	33.743s

@georgebuckerfield If you can add a documentation page then I can complete the review.
If you don't have time, let us know and we can complete.
Thanks.

[georgebuckerfield]

Thanks for the review @ewbankkit - I've just added a doc page, and am working on addressing your other comments.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTS=TestAccEC2SubnetCidrReservation_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SubnetCidrReservation_' -timeout 180m
=== RUN   TestAccEC2SubnetCidrReservation_basic
=== PAUSE TestAccEC2SubnetCidrReservation_basic
=== RUN   TestAccEC2SubnetCidrReservation_ipv6
=== PAUSE TestAccEC2SubnetCidrReservation_ipv6
=== RUN   TestAccEC2SubnetCidrReservation_disappears
=== PAUSE TestAccEC2SubnetCidrReservation_disappears
=== CONT  TestAccEC2SubnetCidrReservation_basic
=== CONT  TestAccEC2SubnetCidrReservation_disappears
=== CONT  TestAccEC2SubnetCidrReservation_ipv6
--- PASS: TestAccEC2SubnetCidrReservation_disappears (23.80s)
--- PASS: TestAccEC2SubnetCidrReservation_basic (26.04s)
--- PASS: TestAccEC2SubnetCidrReservation_ipv6 (27.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	30.710s

GovCloud

% make testacc TESTS=TestAccEC2SubnetCidrReservation_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SubnetCidrReservation_' -timeout 180m
=== RUN   TestAccEC2SubnetCidrReservation_basic
=== PAUSE TestAccEC2SubnetCidrReservation_basic
=== RUN   TestAccEC2SubnetCidrReservation_ipv6
=== PAUSE TestAccEC2SubnetCidrReservation_ipv6
=== RUN   TestAccEC2SubnetCidrReservation_disappears
=== PAUSE TestAccEC2SubnetCidrReservation_disappears
=== CONT  TestAccEC2SubnetCidrReservation_basic
=== CONT  TestAccEC2SubnetCidrReservation_disappears
=== CONT  TestAccEC2SubnetCidrReservation_ipv6
--- PASS: TestAccEC2SubnetCidrReservation_disappears (29.95s)
--- PASS: TestAccEC2SubnetCidrReservation_basic (32.99s)
--- PASS: TestAccEC2SubnetCidrReservation_ipv6 (33.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	36.952s

[github-actions]

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.