Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add aws_ecs_task_set resource #22096

Merged
merged 6 commits into from
Dec 8, 2021
Merged

feat: add aws_ecs_task_set resource #22096

merged 6 commits into from
Dec 8, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Dec 7, 2021 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13651
Closes #8124

Continues the work in #13651

Output from acceptance testing (us-west-2):

--- PASS: TestAccECSTaskSet_Tags (107.55s)
--- PASS: TestAccECSTaskSet_basic (81.85s)
--- PASS: TestAccECSTaskSet_disappears (73.98s)
--- PASS: TestAccECSTaskSet_withAlb (171.33s)
--- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (125.64s)
--- PASS: TestAccECSTaskSet_withExternalId (81.31s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargate (82.99s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion (116.62s)
--- PASS: TestAccECSTaskSet_withMultipleCapacityProviderStrategies (94.91s)
--- PASS: TestAccECSTaskSet_withScale (109.16s)
--- PASS: TestAccECSTaskSet_withServiceRegistries (142.97s)

Output from acceptance testing (us-gov-west-1):

--- PASS: TestAccECSTaskSet_withServiceRegistries (59.83s)
--- PASS: TestAccECSTaskSet_basic (68.94s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargate (73.57s)
--- PASS: TestAccECSTaskSet_disappears (74.29s)
--- PASS: TestAccECSTaskSet_withExternalId (78.62s)
--- PASS: TestAccECSTaskSet_withMultipleCapacityProviderStrategies (80.94s)
--- PASS: TestAccECSTaskSet_withScale (86.38s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion (98.46s)
--- PASS: TestAccECSTaskSet_Tags (108.90s)
--- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (124.31s)
--- PASS: TestAccECSTaskSet_withAlb (317.96s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. provider Pertains to the provider itself, rather than any interaction with AWS. labels Dec 7, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 7, 2021
@anGie44 anGie44 force-pushed the addTasksSetResource branch 4 times, most recently from 13e42e9 to 7c29359 Compare December 7, 2021 21:26
@anGie44 anGie44 marked this pull request as ready for review December 7, 2021 22:38
@anGie44 anGie44 marked this pull request as draft December 7, 2021 22:41
@anGie44 anGie44 marked this pull request as ready for review December 8, 2021 01:24
@anGie44 anGie44 force-pushed the addTasksSetResource branch 3 times, most recently from 3ff5f04 to 4c0d329 Compare December 8, 2021 01:53
@anGie44 anGie44 added the new-resource Introduces a new resource. label Dec 8, 2021
@anGie44 anGie44 added this to the v3.69.0 milestone Dec 8, 2021
@anGie44
Copy link
Contributor Author

anGie44 commented Dec 8, 2021

Thanks again @kumarappan-arumugam for your contributions!

Output of acceptance tests:

--- PASS: TestAccECSTaskSet_disappears (206.41s)
--- PASS: TestAccECSTaskSet_basic (257.55s)
--- PASS: TestAccECSTaskSet_withExternalId (257.71s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargate (336.08s)
--- PASS: TestAccECSTaskSet_withScale (364.62s)
--- PASS: TestAccECSTaskSet_withServiceRegistries (371.34s)
--- PASS: TestAccECSTaskSet_withMultipleCapacityProviderStrategies (383.37s)
--- PASS: TestAccECSTaskSet_Tags (414.98s)
--- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (424.31s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion (446.71s)
--- PASS: TestAccECSTaskSet_withAlb (450.43s)

@anGie44 anGie44 merged commit 0dc0093 into main Dec 8, 2021
@anGie44 anGie44 deleted the addTasksSetResource branch December 8, 2021 03:55
github-actions bot pushed a commit that referenced this pull request Dec 8, 2021
Update CHANGELOG.md for #22096
be4a54c
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecs Issues and PRs that pertain to the ecs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.69.0
Development

Successfully merging this pull request may close these issues.

Support ECS TaskSet
2 participants
@anGie44 @kumarappan-arumugam