Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_dynamodb_table: add table_class attribute #22110

Merged
merged 15 commits into from
Dec 8, 2021
Merged

r/aws_dynamodb_table: add table_class attribute #22110

merged 15 commits into from
Dec 8, 2021

Conversation

roberth-k
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21995

Output from acceptance testing:

f-aws_dynamodb_table-table_class $ make testacc PKG=dynamodb TESTS=TestAccDynamoDBTable_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_' -timeout 180m
=== RUN   TestAccDynamoDBTable_basic
=== PAUSE TestAccDynamoDBTable_basic
=== RUN   TestAccDynamoDBTable_disappears
=== PAUSE TestAccDynamoDBTable_disappears
=== RUN   TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== PAUSE TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== RUN   TestAccDynamoDBTable_extended
=== PAUSE TestAccDynamoDBTable_extended
=== RUN   TestAccDynamoDBTable_enablePITR
=== PAUSE TestAccDynamoDBTable_enablePITR
=== RUN   TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_streamSpecification
=== PAUSE TestAccDynamoDBTable_streamSpecification
=== RUN   TestAccDynamoDBTable_streamSpecificationValidation
=== PAUSE TestAccDynamoDBTable_streamSpecificationValidation
=== RUN   TestAccDynamoDBTable_tags
=== PAUSE TestAccDynamoDBTable_tags
=== RUN   TestAccDynamoDBTable_gsiUpdateCapacity
=== PAUSE TestAccDynamoDBTable_gsiUpdateCapacity
=== RUN   TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== RUN   TestAccDynamoDBTable_lsiNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_lsiNonKeyAttributes
=== RUN   TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== RUN   TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== PAUSE TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== RUN   TestAccDynamoDBTable_TTL_enabled
=== PAUSE TestAccDynamoDBTable_TTL_enabled
=== RUN   TestAccDynamoDBTable_TTL_disabled
=== PAUSE TestAccDynamoDBTable_TTL_disabled
=== RUN   TestAccDynamoDBTable_attributeUpdate
=== PAUSE TestAccDynamoDBTable_attributeUpdate
=== RUN   TestAccDynamoDBTable_lsiUpdate
=== PAUSE TestAccDynamoDBTable_lsiUpdate
=== RUN   TestAccDynamoDBTable_attributeUpdateValidation
=== PAUSE TestAccDynamoDBTable_attributeUpdateValidation
=== RUN   TestAccDynamoDBTable_encryption
=== PAUSE TestAccDynamoDBTable_encryption
=== RUN   TestAccDynamoDBTable_Replica_multiple
=== PAUSE TestAccDynamoDBTable_Replica_multiple
=== RUN   TestAccDynamoDBTable_Replica_single
=== PAUSE TestAccDynamoDBTable_Replica_single
=== RUN   TestAccDynamoDBTable_Replica_singleWithCMK
=== PAUSE TestAccDynamoDBTable_Replica_singleWithCMK
=== RUN   TestAccDynamoDBTable_tableClassInfrequentAccess
=== PAUSE TestAccDynamoDBTable_tableClassInfrequentAccess
=== CONT  TestAccDynamoDBTable_basic
=== CONT  TestAccDynamoDBTable_lsiNonKeyAttributes
=== CONT  TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== CONT  TestAccDynamoDBTable_tags
=== CONT  TestAccDynamoDBTable_TTL_enabled
=== CONT  TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== CONT  TestAccDynamoDBTable_streamSpecificationValidation
=== CONT  TestAccDynamoDBTable_streamSpecification
=== CONT  TestAccDynamoDBTable_enablePITR
=== CONT  TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== CONT  TestAccDynamoDBTable_attributeUpdateValidation
=== CONT  TestAccDynamoDBTable_tableClassInfrequentAccess
=== CONT  TestAccDynamoDBTable_Replica_singleWithCMK
=== CONT  TestAccDynamoDBTable_Replica_single
=== CONT  TestAccDynamoDBTable_Replica_multiple
=== CONT  TestAccDynamoDBTable_lsiUpdate
=== CONT  TestAccDynamoDBTable_attributeUpdate
=== CONT  TestAccDynamoDBTable_TTL_disabled
=== CONT  TestAccDynamoDBTable_encryption
=== CONT  TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (7.62s)
=== CONT  TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (14.45s)
=== CONT  TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
--- PASS: TestAccDynamoDBTable_TTL_enabled (44.27s)
=== CONT  TestAccDynamoDBTable_extended
--- PASS: TestAccDynamoDBTable_basic (46.13s)
=== CONT  TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (50.15s)
=== CONT  TestAccDynamoDBTable_gsiUpdateOtherAttributes
--- PASS: TestAccDynamoDBTable_tags (58.95s)
=== CONT  TestAccDynamoDBTable_disappears
--- PASS: TestAccDynamoDBTable_TTL_disabled (68.49s)
=== CONT  TestAccDynamoDBTable_gsiUpdateCapacity
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (71.42s)
--- PASS: TestAccDynamoDBTable_tableClassInfrequentAccess (74.63s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (67.09s)
--- PASS: TestAccDynamoDBTable_streamSpecification (75.84s)
--- PASS: TestAccDynamoDBTable_enablePITR (81.35s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (82.51s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (83.71s)
--- PASS: TestAccDynamoDBTable_disappears (25.24s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (85.20s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (61.91s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (122.65s)
--- PASS: TestAccDynamoDBTable_extended (126.96s)
--- PASS: TestAccDynamoDBTable_encryption (194.86s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (500.00s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (552.19s)
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (622.18s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (996.22s)
--- PASS: TestAccDynamoDBTable_Replica_single (1004.40s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (1100.85s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (1373.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   1375.981s

f-aws_dynamodb_table-table_class $ make testacc PKG=dynamodb TESTS=TestAccDynamoDBTableDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableDataSource_' -timeout 180m
=== RUN   TestAccDynamoDBTableDataSource_basic
=== PAUSE TestAccDynamoDBTableDataSource_basic
=== CONT  TestAccDynamoDBTableDataSource_basic
--- PASS: TestAccDynamoDBTableDataSource_basic (49.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   51.509s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Dec 8, 2021
@roberth-k roberth-k mentioned this pull request Dec 8, 2021
Closed
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2021
ewbankkit
ewbankkit approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG=dynamodb TESTS=TestAccDynamoDBTable_                          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_' -timeout 180m
=== RUN   TestAccDynamoDBTable_basic
=== PAUSE TestAccDynamoDBTable_basic
=== RUN   TestAccDynamoDBTable_disappears
=== PAUSE TestAccDynamoDBTable_disappears
=== RUN   TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== PAUSE TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== RUN   TestAccDynamoDBTable_extended
=== PAUSE TestAccDynamoDBTable_extended
=== RUN   TestAccDynamoDBTable_enablePITR
=== PAUSE TestAccDynamoDBTable_enablePITR
=== RUN   TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_streamSpecification
=== PAUSE TestAccDynamoDBTable_streamSpecification
=== RUN   TestAccDynamoDBTable_streamSpecificationValidation
=== PAUSE TestAccDynamoDBTable_streamSpecificationValidation
=== RUN   TestAccDynamoDBTable_tags
=== PAUSE TestAccDynamoDBTable_tags
=== RUN   TestAccDynamoDBTable_gsiUpdateCapacity
=== PAUSE TestAccDynamoDBTable_gsiUpdateCapacity
=== RUN   TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== RUN   TestAccDynamoDBTable_lsiNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_lsiNonKeyAttributes
=== RUN   TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== RUN   TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== PAUSE TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== RUN   TestAccDynamoDBTable_TTL_enabled
=== PAUSE TestAccDynamoDBTable_TTL_enabled
=== RUN   TestAccDynamoDBTable_TTL_disabled
=== PAUSE TestAccDynamoDBTable_TTL_disabled
=== RUN   TestAccDynamoDBTable_attributeUpdate
=== PAUSE TestAccDynamoDBTable_attributeUpdate
=== RUN   TestAccDynamoDBTable_lsiUpdate
=== PAUSE TestAccDynamoDBTable_lsiUpdate
=== RUN   TestAccDynamoDBTable_attributeUpdateValidation
=== PAUSE TestAccDynamoDBTable_attributeUpdateValidation
=== RUN   TestAccDynamoDBTable_encryption
=== PAUSE TestAccDynamoDBTable_encryption
=== RUN   TestAccDynamoDBTable_Replica_multiple
=== PAUSE TestAccDynamoDBTable_Replica_multiple
=== RUN   TestAccDynamoDBTable_Replica_single
=== PAUSE TestAccDynamoDBTable_Replica_single
=== RUN   TestAccDynamoDBTable_Replica_singleWithCMK
=== PAUSE TestAccDynamoDBTable_Replica_singleWithCMK
=== RUN   TestAccDynamoDBTable_tableClassInfrequentAccess
=== PAUSE TestAccDynamoDBTable_tableClassInfrequentAccess
=== CONT  TestAccDynamoDBTable_basic
=== CONT  TestAccDynamoDBTable_lsiNonKeyAttributes
=== CONT  TestAccDynamoDBTable_encryption
=== CONT  TestAccDynamoDBTable_streamSpecification
=== CONT  TestAccDynamoDBTable_tableClassInfrequentAccess
=== CONT  TestAccDynamoDBTable_Replica_singleWithCMK
=== CONT  TestAccDynamoDBTable_Replica_single
=== CONT  TestAccDynamoDBTable_TTL_enabled
=== CONT  TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== CONT  TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== CONT  TestAccDynamoDBTable_Replica_multiple
=== CONT  TestAccDynamoDBTable_lsiUpdate
=== CONT  TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== CONT  TestAccDynamoDBTable_tags
=== CONT  TestAccDynamoDBTable_streamSpecificationValidation
=== CONT  TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== CONT  TestAccDynamoDBTable_attributeUpdate
=== CONT  TestAccDynamoDBTable_TTL_disabled
=== CONT  TestAccDynamoDBTable_gsiUpdateCapacity
=== CONT  TestAccDynamoDBTable_attributeUpdateValidation
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (8.96s)
=== CONT  TestAccDynamoDBTable_enablePITR
--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (18.93s)
=== CONT  TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
--- PASS: TestAccDynamoDBTable_basic (46.94s)
=== CONT  TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
--- PASS: TestAccDynamoDBTable_TTL_enabled (50.53s)
=== CONT  TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (56.80s)
=== CONT  TestAccDynamoDBTable_disappears
--- PASS: TestAccDynamoDBTable_tags (65.45s)
=== CONT  TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
--- PASS: TestAccDynamoDBTable_TTL_disabled (73.95s)
=== CONT  TestAccDynamoDBTable_extended
--- PASS: TestAccDynamoDBTable_tableClassInfrequentAccess (75.71s)
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (78.89s)
--- PASS: TestAccDynamoDBTable_disappears (24.22s)
--- PASS: TestAccDynamoDBTable_streamSpecification (81.76s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (82.33s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (87.67s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (93.40s)
--- PASS: TestAccDynamoDBTable_enablePITR (87.91s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (65.29s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (82.66s)
--- PASS: TestAccDynamoDBTable_encryption (191.83s)
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (389.77s)
--- PASS: TestAccDynamoDBTable_extended (464.90s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (541.82s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (929.21s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (931.29s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (941.03s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (994.44s)
--- PASS: TestAccDynamoDBTable_Replica_single (1948.36s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (2047.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	2050.925s
% make testacc PKG=dynamodb TESTS=TestAccDynamoDBTableDataSource_     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableDataSource_' -timeout 180m
=== RUN   TestAccDynamoDBTableDataSource_basic
=== PAUSE TestAccDynamoDBTableDataSource_basic
=== CONT  TestAccDynamoDBTableDataSource_basic
--- PASS: TestAccDynamoDBTableDataSource_basic (40.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	44.289s
GovCloud
% make testacc PKG=dynamodb TESTS=TestAccDynamoDBTable_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_' -timeout 180m
=== RUN   TestAccDynamoDBTable_basic
=== PAUSE TestAccDynamoDBTable_basic
=== RUN   TestAccDynamoDBTable_disappears
=== PAUSE TestAccDynamoDBTable_disappears
=== RUN   TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== PAUSE TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== RUN   TestAccDynamoDBTable_extended
=== PAUSE TestAccDynamoDBTable_extended
=== RUN   TestAccDynamoDBTable_enablePITR
=== PAUSE TestAccDynamoDBTable_enablePITR
=== RUN   TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_streamSpecification
=== PAUSE TestAccDynamoDBTable_streamSpecification
=== RUN   TestAccDynamoDBTable_streamSpecificationValidation
=== PAUSE TestAccDynamoDBTable_streamSpecificationValidation
=== RUN   TestAccDynamoDBTable_tags
=== PAUSE TestAccDynamoDBTable_tags
=== RUN   TestAccDynamoDBTable_gsiUpdateCapacity
=== PAUSE TestAccDynamoDBTable_gsiUpdateCapacity
=== RUN   TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== RUN   TestAccDynamoDBTable_lsiNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_lsiNonKeyAttributes
=== RUN   TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== RUN   TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== PAUSE TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== RUN   TestAccDynamoDBTable_TTL_enabled
=== PAUSE TestAccDynamoDBTable_TTL_enabled
=== RUN   TestAccDynamoDBTable_TTL_disabled
=== PAUSE TestAccDynamoDBTable_TTL_disabled
=== RUN   TestAccDynamoDBTable_attributeUpdate
=== PAUSE TestAccDynamoDBTable_attributeUpdate
=== RUN   TestAccDynamoDBTable_lsiUpdate
=== PAUSE TestAccDynamoDBTable_lsiUpdate
=== RUN   TestAccDynamoDBTable_attributeUpdateValidation
=== PAUSE TestAccDynamoDBTable_attributeUpdateValidation
=== RUN   TestAccDynamoDBTable_encryption
=== PAUSE TestAccDynamoDBTable_encryption
=== RUN   TestAccDynamoDBTable_Replica_multiple
=== PAUSE TestAccDynamoDBTable_Replica_multiple
=== RUN   TestAccDynamoDBTable_Replica_single
=== PAUSE TestAccDynamoDBTable_Replica_single
=== RUN   TestAccDynamoDBTable_Replica_singleWithCMK
=== PAUSE TestAccDynamoDBTable_Replica_singleWithCMK
=== RUN   TestAccDynamoDBTable_tableClassInfrequentAccess
=== PAUSE TestAccDynamoDBTable_tableClassInfrequentAccess
=== CONT  TestAccDynamoDBTable_basic
=== CONT  TestAccDynamoDBTable_lsiNonKeyAttributes
=== CONT  TestAccDynamoDBTable_TTL_enabled
=== CONT  TestAccDynamoDBTable_attributeUpdateValidation
=== CONT  TestAccDynamoDBTable_tableClassInfrequentAccess
=== CONT  TestAccDynamoDBTable_Replica_singleWithCMK
=== CONT  TestAccDynamoDBTable_Replica_single
=== CONT  TestAccDynamoDBTable_Replica_multiple
=== CONT  TestAccDynamoDBTable_TTL_disabled
=== CONT  TestAccDynamoDBTable_lsiUpdate
=== CONT  TestAccDynamoDBTable_encryption
=== CONT  TestAccDynamoDBTable_attributeUpdate
=== CONT  TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== CONT  TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== CONT  TestAccDynamoDBTable_gsiUpdateCapacity
=== CONT  TestAccDynamoDBTable_tags
=== CONT  TestAccDynamoDBTable_streamSpecificationValidation
=== CONT  TestAccDynamoDBTable_streamSpecification
=== CONT  TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== CONT  TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== CONT  TestAccDynamoDBTable_Replica_multiple
    acctest.go:632: AWS_THIRD_REGION partition (aws) does not match AWS_DEFAULT_REGION partition (aws-us-gov)
--- FAIL: TestAccDynamoDBTable_Replica_multiple (1.46s)
=== CONT  TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (10.62s)
=== CONT  TestAccDynamoDBTable_enablePITR
=== CONT  TestAccDynamoDBTable_tableClassInfrequentAccess
    acctest.go:960: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DynamoDB Table: ValidationException: Unsupported input parameter TableClass
        	status code: 400, request id: 5DECGEBISH1K4LKCQDRFJCS4CRVV4KQNSO5AEMVJF66Q9ASUAAJG
        
          with aws_dynamodb_table.test,
          on terraform_plugin_test.tf line 2, in resource "aws_dynamodb_table" "test":
           2: resource "aws_dynamodb_table" "test" {
        
--- SKIP: TestAccDynamoDBTable_tableClassInfrequentAccess (7.47s)
--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (19.61s)
=== CONT  TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== CONT  TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
--- PASS: TestAccDynamoDBTable_TTL_enabled (50.65s)
=== CONT  TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
--- PASS: TestAccDynamoDBTable_basic (58.07s)
=== CONT  TestAccDynamoDBTable_extended
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (59.11s)
=== CONT  TestAccDynamoDBTable_disappears
--- PASS: TestAccDynamoDBTable_tags (70.23s)
--- PASS: TestAccDynamoDBTable_TTL_disabled (80.48s)
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (85.96s)
--- PASS: TestAccDynamoDBTable_disappears (28.90s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (71.29s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (92.97s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (98.66s)
--- PASS: TestAccDynamoDBTable_enablePITR (89.28s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (101.13s)
--- PASS: TestAccDynamoDBTable_streamSpecification (101.60s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (86.54s)
--- PASS: TestAccDynamoDBTable_encryption (154.23s)
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (335.53s)
--- PASS: TestAccDynamoDBTable_extended (294.80s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (353.25s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (649.30s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (651.49s)
--- PASS: TestAccDynamoDBTable_Replica_single (712.55s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (756.49s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (943.47s)
PASS
PASS	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	947.471s
% make testacc PKG=dynamodb TESTS=TestAccDynamoDBTableDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableDataSource_' -timeout 180m
=== RUN   TestAccDynamoDBTableDataSource_basic
=== PAUSE TestAccDynamoDBTableDataSource_basic
=== CONT  TestAccDynamoDBTableDataSource_basic
--- PASS: TestAccDynamoDBTableDataSource_basic (42.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	45.689s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.
I removed the explicit default value for table_class as it's not supported in US GovCloud and we don't want to always specify a value.

@ewbankkit ewbankkit merged commit 2838da1 into hashicorp:main Dec 8, 2021
@github-actions github-actions bot added this to the v3.69.0 milestone Dec 8, 2021
@ewbankkit ewbankkit mentioned this pull request Dec 9, 2021
Closed
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@roberth-k roberth-k deleted the f-aws_dynamodb_table-table_class branch January 16, 2022 20:21
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.69.0
Development

Successfully merging this pull request may close these issues.

r/aws_dynamodb_table: support table storage class
2 participants
@roberth-k @ewbankkit