Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/d/aws_ecs_cluster: Fix 'Attribute "setting.#" not set, but "setting.#" is set in aws_ecs_cluster.test as "1"' #22119

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20720.

Continual CI failure:

=== RUN   TestAccECSClusterDataSource_ecsClusterContainerInsights
=== PAUSE TestAccECSClusterDataSource_ecsClusterContainerInsights
=== CONT  TestAccECSClusterDataSource_ecsClusterContainerInsights
cluster_data_source_test.go:42: Step 1/1 error: Check failed: Check 6/6 error: data.aws_ecs_cluster.test: Attribute "setting.#" not set, but "setting.#" is set in aws_ecs_cluster.test as "1"
--- FAIL: TestAccECSClusterDataSource_ecsClusterContainerInsights (48.24s)

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccECSCluster_\|TestAccECSClusterDataSource_' PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run=TestAccECSCluster_\|TestAccECSClusterDataSource_ -timeout 180m
=== RUN   TestAccECSClusterDataSource_ecsCluster
=== PAUSE TestAccECSClusterDataSource_ecsCluster
=== RUN   TestAccECSClusterDataSource_ecsClusterContainerInsights
=== PAUSE TestAccECSClusterDataSource_ecsClusterContainerInsights
=== RUN   TestAccECSCluster_basic
=== PAUSE TestAccECSCluster_basic
=== RUN   TestAccECSCluster_disappears
=== PAUSE TestAccECSCluster_disappears
=== RUN   TestAccECSCluster_tags
=== PAUSE TestAccECSCluster_tags
=== RUN   TestAccECSCluster_singleCapacityProvider
=== PAUSE TestAccECSCluster_singleCapacityProvider
=== RUN   TestAccECSCluster_capacityProviders
=== PAUSE TestAccECSCluster_capacityProviders
=== RUN   TestAccECSCluster_capacityProvidersUpdate
=== PAUSE TestAccECSCluster_capacityProvidersUpdate
=== RUN   TestAccECSCluster_capacityProvidersNoStrategy
=== PAUSE TestAccECSCluster_capacityProvidersNoStrategy
=== RUN   TestAccECSCluster_containerInsights
=== PAUSE TestAccECSCluster_containerInsights
=== RUN   TestAccECSCluster_configuration
=== PAUSE TestAccECSCluster_configuration
=== CONT  TestAccECSClusterDataSource_ecsCluster
=== CONT  TestAccECSCluster_capacityProviders
=== CONT  TestAccECSCluster_basic
=== CONT  TestAccECSClusterDataSource_ecsClusterContainerInsights
=== CONT  TestAccECSCluster_disappears
=== CONT  TestAccECSCluster_singleCapacityProvider
=== CONT  TestAccECSCluster_tags
=== CONT  TestAccECSCluster_containerInsights
=== CONT  TestAccECSCluster_configuration
=== CONT  TestAccECSCluster_capacityProvidersNoStrategy
=== CONT  TestAccECSCluster_capacityProvidersUpdate
--- PASS: TestAccECSCluster_disappears (47.24s)
--- PASS: TestAccECSClusterDataSource_ecsClusterContainerInsights (53.84s)
--- PASS: TestAccECSClusterDataSource_ecsCluster (53.88s)
--- PASS: TestAccECSCluster_basic (58.87s)
--- PASS: TestAccECSCluster_capacityProviders (84.36s)
--- PASS: TestAccECSCluster_configuration (92.13s)
--- PASS: TestAccECSCluster_tags (92.62s)
--- PASS: TestAccECSCluster_singleCapacityProvider (99.12s)
--- PASS: TestAccECSCluster_capacityProvidersNoStrategy (102.96s)
--- PASS: TestAccECSCluster_containerInsights (110.08s)
--- PASS: TestAccECSCluster_capacityProvidersUpdate (114.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	121.405s

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Dec 8, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Output of acceptance tests:

--- PASS: TestAccECSClusterDataSource_ecsCluster (54.98s)
--- PASS: TestAccECSClusterDataSource_ecsClusterContainerInsights (54.58s)
--- PASS: TestAccECSCluster_basic (59.39s)
--- PASS: TestAccECSCluster_capacityProviders (79.70s)
--- PASS: TestAccECSCluster_capacityProvidersNoStrategy (84.79s)
--- PASS: TestAccECSCluster_capacityProvidersUpdate (112.75s)
--- PASS: TestAccECSCluster_configuration (79.41s)
--- PASS: TestAccECSCluster_containerInsights (101.93s)
--- PASS: TestAccECSCluster_disappears (47.41s)
--- PASS: TestAccECSCluster_singleCapacityProvider (107.85s)
--- PASS: TestAccECSCluster_tags (85.09s)

@ewbankkit ewbankkit merged commit d39b72b into main Dec 8, 2021
@ewbankkit ewbankkit deleted the t-d/aws_ecs_cluster-setting branch December 8, 2021 22:25
@github-actions github-actions bot added this to the v3.69.0 milestone Dec 8, 2021
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ecs Issues and PRs that pertain to the ecs service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants