Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set SourceIdentity in assume_role configuration #22128

Closed
chgerkens opened this issue Dec 9, 2021 · 6 comments
Closed

Allow to set SourceIdentity in assume_role configuration #22128

chgerkens opened this issue Dec 9, 2021 · 6 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. upstream Addresses functionality related to the cloud provider.

Comments

@chgerkens
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please provide a way to specify the SourceIdentity argument as part of an assume_role configuration.

New or Affected Resource(s)

Potential Terraform Configuration

I suggest to add a new argument "source_identity" to the assume_role configuration block:

provider "aws" {
  assume_role {
    role_arn     = "arn:aws:iam::ACCOUNT_ID:role/ROLE_NAME"
    session_name = "SESSION_NAME"
    external_id  = "EXTERNAL_ID"
    source_identity = "SOURCE_IDENTITY" // suggested new attribute
  }
}

References

@chgerkens chgerkens added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 9, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 9, 2021
@ewbankkit ewbankkit added provider Pertains to the provider itself, rather than any interaction with AWS. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2021
@ewbankkit
Copy link
Contributor

@chgerkens Thanks for raising this issue.
AWS credentials are handled by the https://github.com/hashicorp/aws-sdk-go-base library.
I have opened an issue - hashicorp/aws-sdk-go-base#87.

@gdavison gdavison added the upstream Addresses functionality related to the cloud provider. label Jan 28, 2022
@gdavison
Copy link
Contributor

gdavison commented Jan 28, 2022

This is also affected by aws/aws-sdk-go-v2#1575

@gdavison
Copy link
Contributor

Implemented in aws/aws-sdk-go-v2#1588

@wlami
Copy link
Contributor

wlami commented Jun 1, 2022

This is blocked by hashicorp/aws-sdk-go-base#87. I already have a local test build implementing this feature - I'll create a PR once the upstream PR on aws-sdk-go-base is merged.

@wlami
Copy link
Contributor

wlami commented Sep 14, 2022

This has been implemented in #25368 and released in v4.29.0 of the Terraform AWS Provider.

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

No branches or pull requests

4 participants