Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_connect_hours_of_operation #22207

Merged
merged 7 commits into from Dec 14, 2021
Merged

d/aws_connect_hours_of_operation #22207

merged 7 commits into from Dec 14, 2021

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21043

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectHoursOfOperationDataSource PKG=connect

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectHoursOfOperationDataSource' -timeout 180m
=== RUN   TestAccConnectHoursOfOperationDataSource_hoursOfOperationID
--- PASS: TestAccConnectHoursOfOperationDataSource_hoursOfOperationID (153.93s)
=== RUN   TestAccConnectHoursOfOperationDataSource_name
--- PASS: TestAccConnectHoursOfOperationDataSource_name (110.01s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    271.342s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Dec 14, 2021
AdamTylerLynch
AdamTylerLynch approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AdamTylerLynch
Copy link
Collaborator

Ready for maintainer review.

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @GlennChia

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTS=TestAccConnectHoursOfOperationDataSource PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectHoursOfOperationDataSource' -timeout 180m
=== RUN   TestAccConnectHoursOfOperationDataSource_hoursOfOperationID
--- PASS: TestAccConnectHoursOfOperationDataSource_hoursOfOperationID (84.58s)
=== RUN   TestAccConnectHoursOfOperationDataSource_name
--- PASS: TestAccConnectHoursOfOperationDataSource_name (99.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	187.266s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTS=TestAccConnectHoursOfOperationDataSource PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectHoursOfOperationDataSource' -timeout 180m
=== RUN   TestAccConnectHoursOfOperationDataSource_hoursOfOperationID
--- PASS: TestAccConnectHoursOfOperationDataSource_hoursOfOperationID (74.98s)
=== RUN   TestAccConnectHoursOfOperationDataSource_name
--- PASS: TestAccConnectHoursOfOperationDataSource_name (98.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	176.671s

@breathingdust breathingdust merged commit 83329c5 into hashicorp:main Dec 14, 2021
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Dec 14, 2021
@github-actions github-actions bot added this to the v3.70.0 milestone Dec 14, 2021
@GlennChia GlennChia deleted the f-aws_connect_hours_of_operation branch December 14, 2021 22:53
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

Assignees

@breathingdust breathingdust

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.70.0
Development

Successfully merging this pull request may close these issues.

Add new resource/data_source for aws_connect_hours_of_operations
3 participants
@GlennChia @AdamTylerLynch @breathingdust