Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_connect_security_profile #22369

Merged
merged 19 commits into from
Jan 25, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Dec 29, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22376

Output from acceptance testing:

make testacc TESTS=TestAccConnectSecurityProfile_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectSecurityProfile_serial' -timeout 180m
=== RUN   TestAccConnectSecurityProfile_serial
=== RUN   TestAccConnectSecurityProfile_serial/basic
=== RUN   TestAccConnectSecurityProfile_serial/disappears
--- PASS: TestAccConnectSecurityProfile_serial (296.29s)
    --- PASS: TestAccConnectSecurityProfile_serial/basic (185.87s)
    --- PASS: TestAccConnectSecurityProfile_serial/disappears (110.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    305.214s
...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Dec 29, 2021
@sohaibmaroof
Copy link

Anxiously waiting for this pull request to be merged

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 12, 2022
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @GlennChia!

Validated Acceptance Tests in Commercial (us-west-2)

make testacc TESTS=TestAccConnectSecurityProfile_serial PKG=connect

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectSecurityProfile_serial'  -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.42.38
go: downloading github.com/hashicorp/awspolicyequivalence v1.5.0
=== RUN   TestAccConnectSecurityProfile_serial
=== RUN   TestAccConnectSecurityProfile_serial/basic
=== RUN   TestAccConnectSecurityProfile_serial/disappears
--- PASS: TestAccConnectSecurityProfile_serial (194.40s)
    --- PASS: TestAccConnectSecurityProfile_serial/basic (100.84s)
    --- PASS: TestAccConnectSecurityProfile_serial/disappears (93.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	198.103s

Validated Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTS=TestAccConnectSecurityProfile_serial PKG=connect

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectSecurityProfile_serial'  -timeout 180m
=== RUN   TestAccConnectSecurityProfile_serial
=== RUN   TestAccConnectSecurityProfile_serial/disappears
=== RUN   TestAccConnectSecurityProfile_serial/basic
--- PASS: TestAccConnectSecurityProfile_serial (154.36s)
    --- PASS: TestAccConnectSecurityProfile_serial/disappears (74.54s)
    --- PASS: TestAccConnectSecurityProfile_serial/basic (79.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	157.488s```

@breathingdust breathingdust merged commit 5a326ca into hashicorp:main Jan 25, 2022
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 25, 2022
@GlennChia GlennChia deleted the f-aws_connect_security_profile branch January 25, 2022 23:43
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new resource for aws_connect_security_profile
5 participants