Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_connect_quick_connect #22527

Merged
merged 7 commits into from
Jan 26, 2022
Merged

d/aws_connect_quick_connect #22527

merged 7 commits into from
Jan 26, 2022

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21022

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectQuickConnectDataSource PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQuickConnectDataSource'  -timeout 180m
=== RUN   TestAccConnectQuickConnectDataSource_QuickConnectID
--- PASS: TestAccConnectQuickConnectDataSource_QuickConnectID (154.49s)
=== RUN   TestAccConnectQuickConnectDataSource_name
--- PASS: TestAccConnectQuickConnectDataSource_name (116.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    305.939s

...

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 11, 2022
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 11, 2022
AdamTylerLynch
AdamTylerLynch approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @GlennChia!

Validated Acceptance Tests in Commercial (us-west-2)

make testacc TESTS=TestAccConnectQuickConnectDataSource PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQuickConnectDataSource'  -timeout 180m
=== RUN   TestAccConnectQuickConnectDataSource_QuickConnectID
--- PASS: TestAccConnectQuickConnectDataSource_QuickConnectID (89.44s)
=== RUN   TestAccConnectQuickConnectDataSource_name
--- PASS: TestAccConnectQuickConnectDataSource_name (86.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	179.167s

Validated Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTS=TestAccConnectQuickConnectDataSource PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQuickConnectDataSource'  -timeout 180m
=== RUN   TestAccConnectQuickConnectDataSource_QuickConnectID
--- PASS: TestAccConnectQuickConnectDataSource_QuickConnectID (91.21s)
=== RUN   TestAccConnectQuickConnectDataSource_name
--- PASS: TestAccConnectQuickConnectDataSource_name (72.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	167.217s

@breathingdust breathingdust merged commit a802225 into hashicorp:main Jan 26, 2022
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 26, 2022
@GlennChia GlennChia deleted the f-aws_connect_quick_connect branch January 26, 2022 00:06
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.74.0
Development

Successfully merging this pull request may close these issues.

Add new resource/data_source for aws_connect_quick_connect
4 participants
@GlennChia @breathingdust @AdamTylerLynch @justinretzolk