Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_connect_queue #22566

Merged
merged 26 commits into from
Jan 25, 2022
Merged

r/aws_connect_queue #22566

merged 26 commits into from
Jan 25, 2022

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21021

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectQueue_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQueue_serial'  -timeout 180m
=== RUN   TestAccConnectQueue_serial
=== RUN   TestAccConnectQueue_serial/update_max_contacts
    queue_test.go:190: A bug in the service API has been reported
=== RUN   TestAccConnectQueue_serial/update_outbound_caller_config
=== RUN   TestAccConnectQueue_serial/update_status
=== RUN   TestAccConnectQueue_serial/basic
=== RUN   TestAccConnectQueue_serial/disappears
    queue_test.go:94: Queues do not support deletion today
=== RUN   TestAccConnectQueue_serial/update_hours_of_operation_id
--- PASS: TestAccConnectQueue_serial (678.45s)
    --- SKIP: TestAccConnectQueue_serial/update_max_contacts (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_outbound_caller_config (158.45s)
    --- PASS: TestAccConnectQueue_serial/update_status (162.19s)
    --- PASS: TestAccConnectQueue_serial/basic (155.96s)
    --- SKIP: TestAccConnectQueue_serial/disappears (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_hours_of_operation_id (201.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    686.313s

...

@GlennChia
feat(connect): add queue schema
cf54f2f
@GlennChia
feat(connect): expand flatten outbound caller conf
779e8c6
@GlennChia
feat(connect): add queue read
e2c2b3b
@GlennChia
feat(connect): add queue create
3982aad
@GlennChia
feat(connect): add queue update
54aa783
@GlennChia
feat(connect): add aws_connect_queue
e609acc
@GlennChia
test(connect): base config instance, hours of op
1634f9d 
data source for hours of operation used - explained in comments
@GlennChia
test(connect): add basic queue config
a57b2fa
@GlennChia
test(connect): check queue exists
04f54a7
@GlennChia
test(connect): check queue destroy
0f8d986
@GlennChia
test(connect): queue create, update description
335e236
@GlennChia
test(connect): queue disappears
12f5d8b
@GlennChia
test(connect): update hours of op id queue config
d8f1d24
@GlennChia
test(connect): queue update hours of op id
78138ef
@GlennChia
test(connect): update max contacts queue config
e95070e
@GlennChia
test(connect): queue update max contacts
5525f55 
test is skipped
@GlennChia
test(connect): update outbound caller queue config
735aba2
@GlennChia
test(connect): queue update outbound caller config
b50329e
@GlennChia
test(connect): update status queue config
722efbe
@GlennChia
test(connect): queue update status
8f528d1
@GlennChia
style(connect): order queue schema
0d13c05
@GlennChia
docs(connect): add aws_connect_queue
024b4bb
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jan 13, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed service/connect Issues and PRs that pertain to the connect service. needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 13, 2022
AdamTylerLynch
AdamTylerLynch suggested changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change requested in the docs, asking for a few more examples.

website/docs/r/connect_queue.html.markdown Show resolved Hide resolved
website/docs/r/connect_queue.html.markdown
Provides an Amazon Connect Queue resource. For more information see
[Amazon Connect: Getting Started](https://docs.aws.amazon.com/connect/latest/adminguide/amazon-connect-get-started.html)

~> **NOTE:** Due to The behaviour of Amazon Connect you cannot delete queues.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job including this note for the users. Having thorough documentation is important.

AdamTylerLynch
AdamTylerLynch approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @GlennChia!

Validated Acceptance Tests in Commercial (us-west-2)

make testacc TESTS=TestAccConnectQueue_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQueue_serial'  -timeout 180m
=== RUN   TestAccConnectQueue_serial
=== RUN   TestAccConnectQueue_serial/basic
=== RUN   TestAccConnectQueue_serial/disappears
    queue_test.go:89: Queues do not support deletion today
=== RUN   TestAccConnectQueue_serial/update_hours_of_operation_id
=== RUN   TestAccConnectQueue_serial/update_max_contacts
    queue_test.go:182: A bug in the service API has been reported
=== RUN   TestAccConnectQueue_serial/update_outbound_caller_config
=== RUN   TestAccConnectQueue_serial/update_status
--- PASS: TestAccConnectQueue_serial (427.78s)
    --- PASS: TestAccConnectQueue_serial/basic (104.24s)
    --- SKIP: TestAccConnectQueue_serial/disappears (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_hours_of_operation_id (119.52s)
    --- SKIP: TestAccConnectQueue_serial/update_max_contacts (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_outbound_caller_config (100.25s)
    --- PASS: TestAccConnectQueue_serial/update_status (103.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	432.281s

Validated Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTS=TestAccConnectQueue_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQueue_serial'  -timeout 180m
=== RUN   TestAccConnectQueue_serial
=== RUN   TestAccConnectQueue_serial/update_max_contacts
    queue_test.go:182: A bug in the service API has been reported
=== RUN   TestAccConnectQueue_serial/update_outbound_caller_config
=== RUN   TestAccConnectQueue_serial/update_status
=== RUN   TestAccConnectQueue_serial/basic
=== RUN   TestAccConnectQueue_serial/disappears
    queue_test.go:89: Queues do not support deletion today
=== RUN   TestAccConnectQueue_serial/update_hours_of_operation_id
--- PASS: TestAccConnectQueue_serial (373.67s)
    --- SKIP: TestAccConnectQueue_serial/update_max_contacts (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_outbound_caller_config (105.15s)
    --- PASS: TestAccConnectQueue_serial/update_status (84.96s)
    --- PASS: TestAccConnectQueue_serial/basic (86.20s)
    --- SKIP: TestAccConnectQueue_serial/disappears (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_hours_of_operation_id (97.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	376.804s

@breathingdust breathingdust merged commit 865bb33 into hashicorp:main Jan 25, 2022
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 25, 2022
@GlennChia GlennChia deleted the f-aws_connect_queue branch January 25, 2022 23:27
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.74.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GlennChia @breathingdust @AdamTylerLynch @justinretzolk