Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_cloudfront_origin_access_identity #22572

Merged
merged 2 commits into from
Jan 18, 2022
Merged

d/aws_cloudfront_origin_access_identity #22572

merged 2 commits into from
Jan 18, 2022

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Jan 13, 2022 •
edited by justinretzolk

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14258

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccCloudFrontOriginAccessIdentityDataSource_basic" PKG_NAME="./internal/service/cloudfront" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/cloudfront/... -v -count 1 -parallel 3  -run=TestAccCloudFrontOriginAccessIdentityDataSource_basic -timeout 180m
=== RUN   TestAccCloudFrontOriginAccessIdentityDataSource_basic
=== PAUSE TestAccCloudFrontOriginAccessIdentityDataSource_basic
=== CONT  TestAccCloudFrontOriginAccessIdentityDataSource_basic
--- PASS: TestAccCloudFrontOriginAccessIdentityDataSource_basic (21.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	22.739s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jan 13, 2022
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2022
ewbankkit
ewbankkit approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCloudFrontOriginAccessIdentityDataSource_ PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontOriginAccessIdentityDataSource_'  -timeout 180m
=== RUN   TestAccCloudFrontOriginAccessIdentityDataSource_basic
=== PAUSE TestAccCloudFrontOriginAccessIdentityDataSource_basic
=== CONT  TestAccCloudFrontOriginAccessIdentityDataSource_basic
--- PASS: TestAccCloudFrontOriginAccessIdentityDataSource_basic (11.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	15.388s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5ba2ffa into hashicorp:main Jan 18, 2022
@github-actions github-actions bot added this to the v3.73.0 milestone Jan 18, 2022
@github-actions
Copy link

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

antonbabenko
antonbabenko reviewed Jan 21, 2022
View reviewed changes
website/docs/d/cloudfront_origin_access_identity.html.markdown

principals {
type = "AWS"
identifiers = [aws_cloudfront_origin_access_identity.example.iam_arn]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, this should be like - data.aws_cloudfront_origin_access_identity.example.iam_arn, right? Similar change in the example above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I believe you’re right.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.73.0
Development

Successfully merging this pull request may close these issues.

data source for "aws_cloudfront_origin_access_identity"
4 participants
@danquack @ewbankkit @antonbabenko @justinretzolk