Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/appsync_api_cache - new resource #22578

Merged
merged 7 commits into from
Jan 18, 2022
Merged

r/appsync_api_cache - new resource #22578

merged 7 commits into from
Jan 18, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 13, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14408

Output from acceptance testing:

$ make testacc TESTS=TestAccAppSync_serial/ApiCache
--- PASS: TestAccAppSync_serial (1260.71s)
    --- PASS: TestAccAppSync_serial/ApiCache (1260.71s)
        --- PASS: TestAccAppSync_serial/ApiCache/basic (632.55s)
        --- PASS: TestAccAppSync_serial/ApiCache/disappears (628.16s)
PASS

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appsync Issues and PRs that pertain to the appsync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 13, 2022
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jan 13, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review January 13, 2022 20:47
ewbankkit
ewbankkit approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccAppSync_serial/ApiCache PKG=appsync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20 -run='TestAccAppSync_serial/ApiCache'  -timeout 180m
=== RUN   TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/ApiCache
=== RUN   TestAccAppSync_serial/ApiCache/basic
=== RUN   TestAccAppSync_serial/ApiCache/disappears
--- PASS: TestAccAppSync_serial (1248.66s)
    --- PASS: TestAccAppSync_serial/ApiCache (1248.66s)
        --- PASS: TestAccAppSync_serial/ApiCache/basic (625.72s)
        --- PASS: TestAccAppSync_serial/ApiCache/disappears (622.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	1252.074s

@ewbankkit ewbankkit merged commit 47f1373 into hashicorp:main Jan 18, 2022
@github-actions github-actions bot added this to the v3.73.0 milestone Jan 18, 2022
@github-actions
Copy link

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the appsync_cache branch February 12, 2022 12:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appsync Issues and PRs that pertain to the appsync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.73.0
Development

Successfully merging this pull request may close these issues.

aws_appsync_graphql_api is missing cache options
2 participants
@DrFaust92 @ewbankkit