Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket: read-only server_side_encryption_configuration argument #22605

Merged
merged 10 commits into from
Feb 7, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 15, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3Bucket_Basic_acceleration (171.29s)
--- PASS: TestAccS3Bucket_Basic_basic (97.47s)
--- PASS: TestAccS3Bucket_Basic_emptyString (97.74s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (85.81s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (80.52s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (76.97s)
--- PASS: TestAccS3Bucket_Basic_generatedName (96.27s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (94.31s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (165.41s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (72.06s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (96.84s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (213.92s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (176.00s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (103.06s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (90.03s)
--- PASS: TestAccS3Bucket_Manage_objectLock (120.46s)
--- PASS: TestAccS3Bucket_Manage_versioning (174.97s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (98.13s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (100.32s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (211.19s)
--- PASS: TestAccS3Bucket_Replication_basic (269.60s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (76.84s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (161.17s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (163.99s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (202.43s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (197.38s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (240.61s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (103.78s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (162.30s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (125.83s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (156.04s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (157.96s)
--- PASS: TestAccS3Bucket_Security_corsDelete (87.52s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (101.25s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (179.05s)
--- PASS: TestAccS3Bucket_Security_grantToACL (152.71s)
--- PASS: TestAccS3Bucket_Security_logging (104.98s)
--- PASS: TestAccS3Bucket_Security_policy (243.01s)
--- PASS: TestAccS3Bucket_Security_updateACL (165.88s)
--- PASS: TestAccS3Bucket_Security_updateGrant (241.55s)
--- PASS: TestAccS3Bucket_Tags_basic (98.37s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (151.04s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (310.78s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (357.39s)
--- PASS: TestAccS3Bucket_Web_redirect (241.15s)
--- PASS: TestAccS3Bucket_Web_routingRules (168.63s)
--- PASS: TestAccS3Bucket_Web_simple (241.34s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 15, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from 430903e to e03b998 Compare January 15, 2022 02:54
anGie44 added a commit that referenced this pull request Jan 15, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from 66b5fd9 to 53b08d7 Compare January 15, 2022 02:59
@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 15, 2022
@anGie44 anGie44 changed the base branch from main to release/4.x January 15, 2022 03:03
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from 53b08d7 to d09fc23 Compare January 26, 2022 22:42
@anGie44
Copy link
Contributor Author

anGie44 commented Jan 26, 2022

Preceded by #22609

@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from d09fc23 to d9fe277 Compare January 27, 2022 01:25
@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 01:27
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from d9fe277 to 4439983 Compare January 27, 2022 06:39
@anGie44 anGie44 force-pushed the release/4.x branch 5 times, most recently from 18688a6 to 322647c Compare January 28, 2022 22:37
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from a872dc2 to 8eee24f Compare January 29, 2022 01:05
anGie44 added a commit that referenced this pull request Jan 29, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from 8eee24f to 540b3dc Compare January 29, 2022 01:06
Base automatically changed from release/4.x to main January 31, 2022 22:56
anGie44 added a commit that referenced this pull request Feb 4, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from 5bdfad3 to 4e7b771 Compare February 4, 2022 17:05
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 4, 2022

Hmm i haven't come across that error in another branch/PR..I know there's logic to retry on that error code, i'll double-check if there's something different in this one

Update: I see an odd diff between the account i use. If i run TestAccS3Bucket_Basic_shouldFailNotFound in my dev account it fails, otherwise it passes 😕

anGie44 added a commit that referenced this pull request Feb 5, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from 293cddd to 0c76bbc Compare February 5, 2022 04:04
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 5, 2022

Output of updated acceptance tests:

--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_disappears (34.58s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS (38.80s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256 (38.80s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_basic (38.83s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyArn (39.06s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID (39.09s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled (65.43s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm (65.58s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled (65.71s)

anGie44 added a commit that referenced this pull request Feb 6, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from e24c494 to 94cb9e2 Compare February 6, 2022 23:37
anGie44 added a commit that referenced this pull request Feb 7, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from 94cb9e2 to c796e03 Compare February 7, 2022 00:27
anGie44 added a commit that referenced this pull request Feb 7, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from c796e03 to 52be896 Compare February 7, 2022 00:35
@anGie44 anGie44 force-pushed the f-s3-bucket-sse-config-deprecation branch from f8aefe1 to 7f94f4d Compare February 7, 2022 01:19
@anGie44 anGie44 merged commit ab935b2 into main Feb 7, 2022
@anGie44 anGie44 deleted the f-s3-bucket-sse-config-deprecation branch February 7, 2022 01:53
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants