Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_cognito_user_pool_clients - support name attribute #22615

Conversation

kamilturek
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates/closes #22593.

Output from acceptance testing:

$ AWS_PROFILE=private make testacc TESTS=TestAccCognitoIDPUserPoolClientsDataSource_basic PKG=cognitoidp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolClientsDataSource_basic'  -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClientsDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolClientsDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolClientsDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolClientsDataSource_basic (33.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 40.705s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/cognitoidentityprovider tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jan 16, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 18, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCognitoIDPUserPoolClientsDataSource_ PKG=cognitoidp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolClientsDataSource_'  -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClientsDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolClientsDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolClientsDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolClientsDataSource_basic (20.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	24.762s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8e270e5 into hashicorp:main Jan 18, 2022
@github-actions github-actions bot added this to the v3.73.0 milestone Jan 18, 2022
@kamilturek kamilturek deleted the f-aws_cognito_user_pool_clients-name-attribute branch January 18, 2022 17:11
@github-actions
Copy link

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cognito_user_pool_client data source missing 'name' attribute
2 participants