Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket_object_lock_configuration: new resource #22644

Merged
merged 5 commits into from
Feb 3, 2022
Merged

r/s3_bucket_object_lock_configuration: new resource #22644

merged 5 commits into from
Feb 3, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (27.17s)
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (28.60s)
--- PASS: TestAccS3BucketObjectLockConfiguration_update (49.30s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 18, 2022
@anGie44 anGie44 changed the base branch from main to release/4.x January 18, 2022 21:40
anGie44 added a commit that referenced this pull request Jan 19, 2022
@anGie44
Update CHANGELOG for #22644
36fd378
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
anGie44 added a commit that referenced this pull request Jan 26, 2022
@anGie44
Update CHANGELOG for #22644
741bc59
@anGie44 anGie44 force-pushed the f-s3-bucket-object-lock-config-resource branch from 36fd378 to 741bc59 Compare January 26, 2022 21:44
anGie44 added a commit that referenced this pull request Jan 27, 2022
@anGie44
Update CHANGELOG for #22644
abd6c98
@anGie44 anGie44 force-pushed the f-s3-bucket-object-lock-config-resource branch from 741bc59 to abd6c98 Compare January 27, 2022 04:05
@anGie44 anGie44 mentioned this pull request Jan 27, 2022
Merged
@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 06:59
@anGie44 anGie44 force-pushed the release/4.x branch 5 times, most recently from 18688a6 to 322647c Compare January 28, 2022 22:37
anGie44 added a commit that referenced this pull request Jan 29, 2022
@anGie44
Update CHANGELOG for #22644
b6d6d8c
@anGie44 anGie44 force-pushed the f-s3-bucket-object-lock-config-resource branch from abd6c98 to b6d6d8c Compare January 29, 2022 00:08
Base automatically changed from release/4.x to main January 31, 2022 22:59
anGie44 added a commit that referenced this pull request Feb 1, 2022
@anGie44
Update CHANGELOG for #22644
da65710
@anGie44 anGie44 force-pushed the f-s3-bucket-object-lock-config-resource branch from b6d6d8c to da65710 Compare February 1, 2022 00:28
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 2, 2022
@YakDriver YakDriver self-assigned this Feb 2, 2022
YakDriver
YakDriver approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

% make testacc TESTS=TestAccS3BucketObjectLockConfiguration_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketObjectLockConfiguration_'  -timeout 180m
--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (34.14s)
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (36.64s)
--- PASS: TestAccS3BucketObjectLockConfiguration_update (60.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	63.567s

anGie44 added a commit that referenced this pull request Feb 3, 2022
@anGie44
Update CHANGELOG for #22644
e2e254a
@anGie44 anGie44 force-pushed the f-s3-bucket-object-lock-config-resource branch from da65710 to e2e254a Compare February 3, 2022 01:55
@anGie44 anGie44 force-pushed the f-s3-bucket-object-lock-config-resource branch from 2f79b92 to 53c0e60 Compare February 3, 2022 06:27
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 3, 2022

Output of acceptance tests after update:

--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (32.16s)
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (34.14s)
--- PASS: TestAccS3BucketObjectLockConfiguration_update (57.38s)

@anGie44 anGie44 merged commit 3b14ac7 into main Feb 3, 2022
@anGie44 anGie44 deleted the f-s3-bucket-object-lock-config-resource branch February 3, 2022 15:12
github-actions bot pushed a commit that referenced this pull request Feb 3, 2022
Update CHANGELOG.md for #22644
855288d
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anGie44 @YakDriver @ewbankkit