Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket_request_payment_configuration: new resource #22649

Merged
merged 4 commits into from
Feb 3, 2022
Merged

r/s3_bucket_request_payment_configuration: new resource #22649

merged 4 commits into from
Feb 3, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_BucketOwner (27.46s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_Requester (27.69s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_update (68.28s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jan 19, 2022
anGie44 added a commit that referenced this pull request Jan 19, 2022
@anGie44
Update CHANGELOG for #22649
6936d3c
@anGie44 anGie44 changed the base branch from main to release/4.x January 19, 2022 03:49
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 19, 2022
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
anGie44 added a commit that referenced this pull request Jan 26, 2022
@anGie44
Update CHANGELOG for #22649
7d25d37
@anGie44 anGie44 force-pushed the f-s3-bucket-request-payment-config-resource branch from 6936d3c to 7d25d37 Compare January 26, 2022 21:40
@anGie44 anGie44 added the new-resource Introduces a new resource. label Jan 26, 2022
@anGie44 anGie44 mentioned this pull request Jan 27, 2022
Merged
@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 07:01
@anGie44 anGie44 force-pushed the release/4.x branch 4 times, most recently from e604544 to 18688a6 Compare January 28, 2022 22:24
@anGie44 anGie44 force-pushed the f-s3-bucket-request-payment-config-resource branch from 7d25d37 to 7893e61 Compare January 28, 2022 23:14
@github-actions github-actions bot added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jan 28, 2022
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44
Update CHANGELOG for #22649
ec2f525
@anGie44 anGie44 force-pushed the f-s3-bucket-request-payment-config-resource branch from 7893e61 to ec2f525 Compare January 28, 2022 23:15
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44
Update CHANGELOG for #22649
aeae99b
@anGie44 anGie44 force-pushed the f-s3-bucket-request-payment-config-resource branch from ec2f525 to aeae99b Compare January 28, 2022 23:16
@github-actions github-actions bot removed service/ec2 Issues and PRs that pertain to the ec2 service. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jan 28, 2022
anGie44 added a commit that referenced this pull request Jan 29, 2022
@anGie44
Update CHANGELOG for #22649
7322cee
@anGie44 anGie44 force-pushed the f-s3-bucket-request-payment-config-resource branch from aeae99b to 7322cee Compare January 29, 2022 00:01
@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jan 29, 2022
Base automatically changed from release/4.x to main January 31, 2022 22:59
anGie44 added a commit that referenced this pull request Feb 1, 2022
@anGie44
Update CHANGELOG for #22649
46ec9cd
@anGie44 anGie44 force-pushed the f-s3-bucket-request-payment-config-resource branch from 7322cee to 46ec9cd Compare February 1, 2022 00:23
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 2, 2022
@YakDriver YakDriver self-assigned this Feb 2, 2022
YakDriver
YakDriver approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🎉

Output:

% make testacc TESTS=TestAccS3BucketRequestPaymentConfiguration_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketRequestPaymentConfiguration_'  -timeout 180m
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_BucketOwner (29.25s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_Requester (29.38s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_update (71.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	73.274s

@anGie44 anGie44 force-pushed the f-s3-bucket-request-payment-config-resource branch from 46ec9cd to e5b9d5d Compare February 3, 2022 01:53
@anGie44 anGie44 force-pushed the f-s3-bucket-request-payment-config-resource branch from e0302c7 to 8a9587f Compare February 3, 2022 06:12
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 3, 2022

Output of acceptance tests after updates:

--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_Requester (31.87s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_BucketOwner (32.08s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_update (79.49s)

@anGie44 anGie44 merged commit a0434a3 into main Feb 3, 2022
@anGie44 anGie44 deleted the f-s3-bucket-request-payment-config-resource branch February 3, 2022 14:19
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anGie44 @YakDriver @ewbankkit