r/autoscaling_attachment: deprecate alb_target_group_arn and add lb_target_group_arn

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #5407
Relates #20433

Description

• Deprecation of alb_target_group_arn for removal in 5.0

Output from acceptance testing:

--- PASS: TestAccAutoScalingAttachment_elb (115.07s)
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (131.43s)

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingAttachment_' PKG=autoscaling 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingAttachment_ -timeout 180m
=== RUN   TestAccAutoScalingAttachment_elb
=== PAUSE TestAccAutoScalingAttachment_elb
=== RUN   TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== CONT  TestAccAutoScalingAttachment_elb
=== CONT  TestAccAutoScalingAttachment_albTargetGroup
--- PASS: TestAccAutoScalingAttachment_elb (187.56s)
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (192.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	196.444s

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.