Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/route and r/route_table: deprecate instance_id #22664

Merged
merged 2 commits into from
Jan 19, 2022
Merged

r/route and r/route_table: deprecate instance_id #22664

merged 2 commits into from
Jan 19, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14197

Output from acceptance testing:

N/A

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 19, 2022
@anGie44 anGie44 force-pushed the f-deprecate-route-route-table-instance-id branch from efa982d to 12b2adc Compare January 19, 2022 17:17
@anGie44 anGie44 force-pushed the f-deprecate-route-route-table-instance-id branch from 12b2adc to 7e3bde9 Compare January 19, 2022 17:18
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed service/dynamodb Issues and PRs that pertain to the dynamodb service. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 19, 2022
@anGie44 anGie44 marked this pull request as ready for review January 19, 2022 17:22
ewbankkit
ewbankkit approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v4.0.0 milestone Jan 19, 2022
@anGie44 anGie44 merged commit 20ce01f into release/4.x Jan 19, 2022
@anGie44 anGie44 deleted the f-deprecate-route-route-table-instance-id branch January 19, 2022 21:02
@github-actions github-actions bot modified the milestones: v4.0.0, v3.73.0 Jan 19, 2022
github-actions bot pushed a commit that referenced this pull request Jan 19, 2022
Update CHANGELOG.md for #22664
4dccd3c
@ewbankkit ewbankkit modified the milestones: v3.73.0, v4.0.0 Jan 19, 2022
anGie44 added a commit that referenced this pull request Jan 19, 2022
@anGie44
Update CHANGELOG for #22664
4dedd49
anGie44 added a commit that referenced this pull request Jan 20, 2022
@anGie44
Update CHANGELOG for #22664
5aa9db0
anGie44 added a commit that referenced this pull request Jan 21, 2022
@anGie44
Update CHANGELOG for #22664
ded4a4c
anGie44 added a commit that referenced this pull request Jan 21, 2022
@anGie44
Update CHANGELOG for #22664
1e32d58
anGie44 added a commit that referenced this pull request Jan 21, 2022
@anGie44
Update CHANGELOG for #22664
2f730d9
ewbankkit pushed a commit that referenced this pull request Jan 24, 2022
@anGie44 @ewbankkit
Update CHANGELOG for #22664
d1116cc
anGie44 added a commit that referenced this pull request Jan 25, 2022
@anGie44
Update CHANGELOG for #22664
91c316f
anGie44 pushed a commit that referenced this pull request Jan 25, 2022
@anGie44
Update CHANGELOG.md for #22664
876dab7
anGie44 added a commit that referenced this pull request Jan 26, 2022
@anGie44
Update CHANGELOG for #22664
3883955
@YakDriver YakDriver mentioned this pull request Jan 28, 2022
Closed
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44
Update CHANGELOG for #22664
fa0c0bf
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44
Update CHANGELOG for #22664
81170c6
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44
Update CHANGELOG for #22664
b9d8f47
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44
Update CHANGELOG for #22664
067388b
anGie44 pushed a commit that referenced this pull request Jan 28, 2022
@anGie44
Update CHANGELOG.md for #22664
5d5668c
anGie44 pushed a commit that referenced this pull request Jan 28, 2022
@anGie44
Update CHANGELOG.md for #22664
95c2539
anGie44 added a commit that referenced this pull request Jan 31, 2022
@anGie44
Update CHANGELOG for #22664
256b7f5
anGie44 added a commit that referenced this pull request Feb 3, 2022
@anGie44
Update CHANGELOG for #22664
c696683
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anGie44 @ewbankkit