Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable code signing in lambda for ap-southeast-3 #22693

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

jinhong-
Copy link
Contributor

@jinhong- jinhong- commented Jan 20, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22692

Output from acceptance testing:

$ make testacc TESTS=TestAccLambdaFunction_codeSigning PKG=lambda

(Failed to run. Asked for AWS credentials for running acceptance testing)
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 20, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jinhong- 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 20, 2022
…gProfile' to prevent 'function_test.go:3457: skipping acceptance testing: Signing Platform (AWSLambda-SHA384-ECDSA) not found'.
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 21, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning -timeout 180m
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_codeSigning
=== PAUSE TestAccLambdaFunction_codeSigning
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaFunction_codeSigning
--- PASS: TestAccLambdaFunction_codeSigning (73.21s)
--- PASS: TestAccLambdaFunction_basic (110.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     117.943s
% AWS_DEFAULT_REGION=ap-southeast-3 make testacc TESTARGS='-run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning -timeout 180m
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_codeSigning
    function_test.go:169: Lambda code signing config is not supported in ap-southeast-3 region
--- SKIP: TestAccLambdaFunction_codeSigning (0.00s)
=== CONT  TestAccLambdaFunction_basic
    function_test.go:46: Step 1/2 error: Check failed: Check 8/9 error: aws_lambda_function.test: Attribute 'architectures.0' not found
--- FAIL: TestAccLambdaFunction_basic (66.80s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/lambda     70.200s
FAIL
make: *** [testacc] Error 1
GovCloud
% make testacc TESTARGS='-run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning -timeout 180m
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_codeSigning
    function_test.go:162: Lambda code signing config is not supported in aws-us-gov partition
--- SKIP: TestAccLambdaFunction_codeSigning (0.00s)
=== CONT  TestAccLambdaFunction_basic
    function_test.go:46: Step 1/2 error: Check failed: Check 8/9 error: aws_lambda_function.test: Attribute 'architectures.0' not found
--- FAIL: TestAccLambdaFunction_basic (25.65s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/lambda     29.113s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change.

@ewbankkit
Copy link
Contributor

@jinhong- Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 99ce18e into hashicorp:main Jan 21, 2022
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 21, 2022
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/lambda Issues and PRs that pertain to the lambda service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tf plan/apply with aws_lambda_function in ap-southeast-3 throws errors
3 participants