Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/instance: prevent panic when instance does not have block devices #22719

Merged
merged 6 commits into from
Jan 25, 2022
Merged

r/instance: prevent panic when instance does not have block devices #22719

merged 6 commits into from
Jan 25, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 21, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reworks #16694
Closes #16689
Closes #16477
Closes #17284
Closes #20821
Closes #22660
Closes #19779

New test before code change:

=== RUN   TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
=== PAUSE TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
=== CONT  TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
panic: interface conversion: interface {} is nil, not []map[string]interface {}

goroutine 856 [running]:
github.com/hashicorp/terraform-provider-aws/internal/service/ec2.readBlockDevices(0xc001e4e180, 0xc002e43440, 0xc0005227c0, 0x0, 0x0)
	/Users/apinilla/Documents/test/go/src/github.com/hashicorp/terraform-provider-aws/internal/service/ec2/instance.go:1906 +0x799
github.com/hashicorp/terraform-provider-aws/internal/service/ec2.resourceInstanceRead(0xc001e4e180, 0x91e1980, 0xc0003a2a80, 0x102f37b0, 0xc000594000)
	/Users/apinilla/Documents/test/go/src/github.com/hashicorp/terraform-provider-aws/internal/service/ec2/instance.go:1118 +0x1ce6
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc000e35b20, 0xb587f58, 0xc0025ac0c0, 0xc001e4e180, 0x91e1980, 0xc0003a2a80, 0x0, 0x0, 0x0)
	/Users/apinilla/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.10.1/helper/schema/resource.go:346 +0x1ee
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc000e35b20, 0xb587f58, 0xc0025ac0c0, 0xc0027d20d0, 0x91e1980, 0xc0003a2a80, 0xc003376900, 0x0, 0x0, 0x0)
	/Users/apinilla/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.10.1/helper/schema/resource.go:635 +0x1cb
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadResource(0xc0027d8378, 0xb587f58, 0xc0025ac0c0, 0xc0025ac100, 0xa546200, 0x12, 0x0)
	/Users/apinilla/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.10.1/helper/schema/grpc_provider.go:576 +0x47d
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadResource(0xc0027e6280, 0xb588000, 0xc0025ac0c0, 0xc0025a80c0, 0x0, 0x0, 0x0)
	/Users/apinilla/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.5.0/tfprotov5/tf5server/server.go:553 +0x322
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadResource_Handler(0xa2a5f80, 0xc0027e6280, 0xb588000, 0xc002592db0, 0xc0025a8060, 0x0, 0xb588000, 0xc002592db0, 0xc0025aa800, 0x734)
	/Users/apinilla/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.5.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:344 +0x214
google.golang.org/grpc.(*Server).processUnaryRPC(0xc000579dc0, 0xb5b6198, 0xc00234d200, 0xc0008d7400, 0xc0027e8630, 0x102adb30, 0x0, 0x0, 0x0)
	/Users/apinilla/go/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1194 +0x52b
google.golang.org/grpc.(*Server).handleStream(0xc000579dc0, 0xb5b6198, 0xc00234d200, 0xc0008d7400, 0x0)
	/Users/apinilla/go/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1517 +0xd0c
google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc0017f7ad0, 0xc000579dc0, 0xb5b6198, 0xc00234d200, 0xc0008d7400)
	/Users/apinilla/go/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:859 +0xab
created by google.golang.org/grpc.(*Server).serveStreams.func1
	/Users/apinilla/go/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:857 +0x1fd
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	123.063s
FAIL
make: *** [testacc] Error 1

New test with code change:

--- PASS: TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed (148.43s)

Output from acceptance testing:

--- PASS: TestAccEC2Instance_CapacityReservation_modifyPreference (177.91s)
--- PASS: TestAccEC2Instance_CapacityReservation_modifyTarget (159.57s)
--- PASS: TestAccEC2Instance_CapacityReservation_targetID (108.55s)
--- PASS: TestAccEC2Instance_AssociatePublic_defaultPrivate (117.39s)
--- PASS: TestAccEC2Instance_AssociatePublic_defaultPublic (113.77s)
--- PASS: TestAccEC2Instance_AssociatePublic_explicitPrivate (139.65s)
--- PASS: TestAccEC2Instance_AssociatePublic_explicitPublic (131.57s)
--- PASS: TestAccEC2Instance_AssociatePublic_overridePrivate (122.24s)
--- PASS: TestAccEC2Instance_AssociatePublic_overridePublic (124.29s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_ebsAndRoot (206.44s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_volumeTags (199.21s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_withAttachedVolume (208.54s)
--- PASS: TestAccEC2Instance_CapacityReservationPreference_none (122.74s)
--- PASS: TestAccEC2Instance_CapacityReservationPreference_open (124.66s)
--- PASS: TestAccEC2Instance_CapacityReservation_unspecifiedDefaultsToOpen (127.88s)
--- PASS: TestAccEC2Instance_CreditSpecificationEmpty_nonBurstable (129.53s)
--- PASS: TestAccEC2Instance_CreditSpecificationStandardCPUCredits_t2Tot3Taint (425.63s)
--- PASS: TestAccEC2Instance_CreditSpecificationT3_standardCPUCredits (117.70s)
--- PASS: TestAccEC2Instance_CreditSpecificationT3_unlimitedCPUCredits (114.32s)
--- PASS: TestAccEC2Instance_CreditSpecificationT3_unspecifiedDefaultsToUnlimited (123.74s)
--- PASS: TestAccEC2Instance_CreditSpecificationT3_updateCPUCredits (170.21s)
--- PASS: TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t2 (110.58s)
--- PASS: TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t3 (105.76s)
--- PASS: TestAccEC2Instance_CreditSpecificationUnlimitedCPUCredits_t2Tot3Taint (182.08s)
--- PASS: TestAccEC2Instance_CreditSpecificationUnspecifiedToEmpty_nonBurstable (130.73s)
--- PASS: TestAccEC2Instance_CreditSpecification_isNotAppliedToNonBurstable (125.82s)
--- PASS: TestAccEC2Instance_CreditSpecification_standardCPUCredits (117.74s)
--- PASS: TestAccEC2Instance_CreditSpecification_unlimitedCPUCredits (135.40s)
--- PASS: TestAccEC2Instance_CreditSpecification_unspecifiedDefaultsToStandard (111.64s)
--- PASS: TestAccEC2Instance_CreditSpecification_updateCPUCredits (207.57s)
--- PASS: TestAccEC2Instance_EBSBlockDevice_invalidIopsForVolumeType (36.00s)
--- PASS: TestAccEC2Instance_EBSBlockDevice_invalidThroughputForVolumeType (35.01s)
--- PASS: TestAccEC2Instance_EBSBlockDevice_kmsKeyARN (107.61s)
--- PASS: TestAccEC2Instance_EBSRootDeviceModifyIOPS_io1 (170.70s)
--- PASS: TestAccEC2Instance_EBSRootDeviceModifyIOPS_io2 (167.74s)
--- PASS: TestAccEC2Instance_EBSRootDeviceModifyThroughput_gp3 (155.43s)
--- PASS: TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifyDeleteOnTermination (124.09s)
--- PASS: TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifySize (163.00s)
--- PASS: TestAccEC2Instance_EBSRootDevice_basic (101.97s)
--- PASS: TestAccEC2Instance_EBSRootDevice_modifyAll (153.04s)
--- PASS: TestAccEC2Instance_EBSRootDevice_modifyDeleteOnTermination (131.09s)
--- PASS: TestAccEC2Instance_EBSRootDevice_modifySize (159.02s)
--- PASS: TestAccEC2Instance_EBSRootDevice_modifyType (165.33s)
--- PASS: TestAccEC2Instance_EBSRootDevice_multipleDynamicEBSBlockDevices (225.40s)
--- PASS: TestAccEC2Instance_Empty_privateIP (143.17s)
--- PASS: TestAccEC2Instance_GetPasswordData_falseToTrue (177.43s)
--- PASS: TestAccEC2Instance_GetPasswordData_trueToFalse (210.50s)
--- PASS: TestAccEC2Instance_IPv6_supportAddressCount (137.90s)
--- PASS: TestAccEC2Instance_IPv6_supportAddressCountWithIPv4 (124.89s)
--- PASS: TestAccEC2Instance_LaunchTemplateModifyTemplate_defaultVersion (166.68s)
--- PASS: TestAccEC2Instance_LaunchTemplate_basic (66.97s)
--- PASS: TestAccEC2Instance_LaunchTemplate_overrideTemplate (92.14s)
--- PASS: TestAccEC2Instance_LaunchTemplate_setSpecificVersion (127.69s)
--- PASS: TestAccEC2Instance_LaunchTemplate_swapIDAndName (126.40s)
--- PASS: TestAccEC2Instance_LaunchTemplate_updateTemplateVersion (222.15s)
--- PASS: TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPs (115.57s)
--- PASS: TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPsUpdate (172.63s)
--- PASS: TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPs (79.29s)
--- PASS: TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPsUpdate (187.28s)
--- PASS: TestAccEC2Instance_NewNetworkInterface_publicIPAndSecondaryPrivateIPs (212.21s)
--- PASS: TestAccEC2Instance_RootBlockDevice_kmsKeyARN (139.35s)
--- PASS: TestAccEC2Instance_UserData_emptyStringToUnspecified (135.95s)
--- PASS: TestAccEC2Instance_UserData_unspecifiedToEmptyString (130.18s)
--- PASS: TestAccEC2Instance_addSecondaryInterface (371.02s)
--- PASS: TestAccEC2Instance_addSecurityGroupNetworkInterface (391.66s)
--- PASS: TestAccEC2Instance_associatePublicIPAndPrivateIP (124.99s)
--- PASS: TestAccEC2Instance_atLeastOneOtherEBSVolume (208.07s)
--- PASS: TestAccEC2Instance_basic (88.62s)
--- PASS: TestAccEC2Instance_blockDevices (110.58s)
--- PASS: TestAccEC2Instance_changeInstanceType (227.64s)
--- PASS: TestAccEC2Instance_disableAPITermination (176.73s)
--- PASS: TestAccEC2Instance_disappears (323.73s)
--- PASS: TestAccEC2Instance_enclaveOptions (235.40s)
--- PASS: TestAccEC2Instance_forceNewAndTagsDrift (270.69s)
--- PASS: TestAccEC2Instance_gp2IopsDevice (108.85s)
--- PASS: TestAccEC2Instance_gp2WithIopsValue (35.29s)
--- PASS: TestAccEC2Instance_gp3RootBlockDevice (112.21s)
--- PASS: TestAccEC2Instance_hibernation (208.08s)
--- PASS: TestAccEC2Instance_inDefaultVPCBySgID (143.25s)
--- PASS: TestAccEC2Instance_inDefaultVPCBySgName (130.54s)
--- PASS: TestAccEC2Instance_instanceProfileChange (250.33s)
--- PASS: TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError (28.26s)
--- PASS: TestAccEC2Instance_keyPairCheck (144.26s)
--- PASS: TestAccEC2Instance_metadataOptions (162.97s)
--- PASS: TestAccEC2Instance_networkInstanceRemovingAllSecurityGroups (134.61s)
--- PASS: TestAccEC2Instance_networkInstanceSecurityGroups (117.23s)
--- PASS: TestAccEC2Instance_networkInstanceVPCSecurityGroupIDs (112.02s)
--- PASS: TestAccEC2Instance_noAMIEphemeralDevices (153.23s)
--- PASS: TestAccEC2Instance_placementGroup (134.06s)
--- PASS: TestAccEC2Instance_placementPartitionNumber (144.89s)
--- PASS: TestAccEC2Instance_primaryNetworkInterface (124.09s)
--- PASS: TestAccEC2Instance_primaryNetworkInterfaceSourceDestCheck (108.13s)
--- PASS: TestAccEC2Instance_privateIP (141.78s)
--- PASS: TestAccEC2Instance_rootBlockDeviceMismatch (240.58s)
--- PASS: TestAccEC2Instance_rootInstanceStore (136.10s)
--- PASS: TestAccEC2Instance_sourceDestCheck (210.97s)
--- PASS: TestAccEC2Instance_tags (118.13s)
--- PASS: TestAccEC2Instance_userDataBase64 (137.57s)
--- PASS: TestAccEC2Instance_withIAMInstanceProfile (126.96s)
--- PASS: TestAccEC2Instance_withIAMInstanceProfilePath (155.08s)
--- SKIP: TestAccEC2Instance_inEC2Classic (2.11s)
--- SKIP: TestAccEC2Instance_outpost (1.30s)

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. labels Jan 21, 2022
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Jan 21, 2022
@anGie44 anGie44 marked this pull request as ready for review January 24, 2022 17:05
@anGie44 anGie44 added the crash Results from or addresses a Terraform crash or kernel panic. label Jan 24, 2022
@ewbankkit ewbankkit self-assigned this Jan 24, 2022
@ewbankkit
Copy link
Contributor

Is it possible to add an acceptance test case for this?

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 24, 2022
@anGie44 anGie44 force-pushed the b-instance-nil-block-devices branch from 4afd9fe to 8d53090 Compare January 24, 2022 22:35
@anGie44 anGie44 force-pushed the b-instance-nil-block-devices branch from 8d53090 to 1432d77 Compare January 24, 2022 22:42
@anGie44
Copy link
Contributor Author

anGie44 commented Jan 24, 2022

@ewbankkit test added 👍 it removes the block devices w/the aws SDK since updating the terraform config by removing ebs_block_device for example gets ignored by terraform

@ewbankkit ewbankkit removed their assignment Jan 24, 2022
ewbankkit
ewbankkit approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2Instance_' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccEC2Instance_ -timeout 180m
=== RUN   TestAccEC2Instance_inDefaultVPCBySgName
=== PAUSE TestAccEC2Instance_inDefaultVPCBySgName
=== RUN   TestAccEC2Instance_inDefaultVPCBySgID
=== PAUSE TestAccEC2Instance_inDefaultVPCBySgID
=== RUN   TestAccEC2Instance_inEC2Classic
=== PAUSE TestAccEC2Instance_inEC2Classic
=== RUN   TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN   TestAccEC2Instance_atLeastOneOtherEBSVolume
=== PAUSE TestAccEC2Instance_atLeastOneOtherEBSVolume
=== RUN   TestAccEC2Instance_EBSBlockDevice_kmsKeyARN
=== PAUSE TestAccEC2Instance_EBSBlockDevice_kmsKeyARN
=== RUN   TestAccEC2Instance_EBSBlockDevice_invalidIopsForVolumeType
=== PAUSE TestAccEC2Instance_EBSBlockDevice_invalidIopsForVolumeType
=== RUN   TestAccEC2Instance_EBSBlockDevice_invalidThroughputForVolumeType
=== PAUSE TestAccEC2Instance_EBSBlockDevice_invalidThroughputForVolumeType
=== RUN   TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
=== PAUSE TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
=== RUN   TestAccEC2Instance_RootBlockDevice_kmsKeyARN
=== PAUSE TestAccEC2Instance_RootBlockDevice_kmsKeyARN
=== RUN   TestAccEC2Instance_userDataBase64
=== PAUSE TestAccEC2Instance_userDataBase64
=== RUN   TestAccEC2Instance_gp2IopsDevice
=== PAUSE TestAccEC2Instance_gp2IopsDevice
=== RUN   TestAccEC2Instance_gp2WithIopsValue
=== PAUSE TestAccEC2Instance_gp2WithIopsValue
=== RUN   TestAccEC2Instance_blockDevices
=== PAUSE TestAccEC2Instance_blockDevices
=== RUN   TestAccEC2Instance_rootInstanceStore
=== PAUSE TestAccEC2Instance_rootInstanceStore
=== RUN   TestAccEC2Instance_noAMIEphemeralDevices
=== PAUSE TestAccEC2Instance_noAMIEphemeralDevices
=== RUN   TestAccEC2Instance_sourceDestCheck
=== PAUSE TestAccEC2Instance_sourceDestCheck
=== RUN   TestAccEC2Instance_disableAPITermination
=== PAUSE TestAccEC2Instance_disableAPITermination
=== RUN   TestAccEC2Instance_dedicatedInstance
=== PAUSE TestAccEC2Instance_dedicatedInstance
=== RUN   TestAccEC2Instance_outpost
=== PAUSE TestAccEC2Instance_outpost
=== RUN   TestAccEC2Instance_placementGroup
=== PAUSE TestAccEC2Instance_placementGroup
=== RUN   TestAccEC2Instance_placementPartitionNumber
=== PAUSE TestAccEC2Instance_placementPartitionNumber
=== RUN   TestAccEC2Instance_IPv6_supportAddressCount
=== PAUSE TestAccEC2Instance_IPv6_supportAddressCount
=== RUN   TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError
=== RUN   TestAccEC2Instance_IPv6_supportAddressCountWithIPv4
=== PAUSE TestAccEC2Instance_IPv6_supportAddressCountWithIPv4
=== RUN   TestAccEC2Instance_networkInstanceSecurityGroups
=== PAUSE TestAccEC2Instance_networkInstanceSecurityGroups
=== RUN   TestAccEC2Instance_networkInstanceRemovingAllSecurityGroups
=== PAUSE TestAccEC2Instance_networkInstanceRemovingAllSecurityGroups
=== RUN   TestAccEC2Instance_networkInstanceVPCSecurityGroupIDs
=== PAUSE TestAccEC2Instance_networkInstanceVPCSecurityGroupIDs
=== RUN   TestAccEC2Instance_tags
=== PAUSE TestAccEC2Instance_tags
=== RUN   TestAccEC2Instance_BlockDeviceTags_volumeTags
=== PAUSE TestAccEC2Instance_BlockDeviceTags_volumeTags
=== RUN   TestAccEC2Instance_BlockDeviceTags_withAttachedVolume
=== PAUSE TestAccEC2Instance_BlockDeviceTags_withAttachedVolume
=== RUN   TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== PAUSE TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== RUN   TestAccEC2Instance_instanceProfileChange
=== PAUSE TestAccEC2Instance_instanceProfileChange
=== RUN   TestAccEC2Instance_withIAMInstanceProfile
=== PAUSE TestAccEC2Instance_withIAMInstanceProfile
=== RUN   TestAccEC2Instance_withIAMInstanceProfilePath
=== PAUSE TestAccEC2Instance_withIAMInstanceProfilePath
=== RUN   TestAccEC2Instance_privateIP
=== PAUSE TestAccEC2Instance_privateIP
=== RUN   TestAccEC2Instance_associatePublicIPAndPrivateIP
=== PAUSE TestAccEC2Instance_associatePublicIPAndPrivateIP
=== RUN   TestAccEC2Instance_Empty_privateIP
=== PAUSE TestAccEC2Instance_Empty_privateIP
=== RUN   TestAccEC2Instance_keyPairCheck
=== PAUSE TestAccEC2Instance_keyPairCheck
=== RUN   TestAccEC2Instance_rootBlockDeviceMismatch
=== PAUSE TestAccEC2Instance_rootBlockDeviceMismatch
=== RUN   TestAccEC2Instance_forceNewAndTagsDrift
=== PAUSE TestAccEC2Instance_forceNewAndTagsDrift
=== RUN   TestAccEC2Instance_changeInstanceType
=== PAUSE TestAccEC2Instance_changeInstanceType
=== RUN   TestAccEC2Instance_EBSRootDevice_basic
=== PAUSE TestAccEC2Instance_EBSRootDevice_basic
=== RUN   TestAccEC2Instance_EBSRootDevice_modifySize
=== PAUSE TestAccEC2Instance_EBSRootDevice_modifySize
=== RUN   TestAccEC2Instance_EBSRootDevice_modifyType
=== PAUSE TestAccEC2Instance_EBSRootDevice_modifyType
=== RUN   TestAccEC2Instance_EBSRootDeviceModifyIOPS_io1
=== PAUSE TestAccEC2Instance_EBSRootDeviceModifyIOPS_io1
=== RUN   TestAccEC2Instance_EBSRootDeviceModifyIOPS_io2
=== PAUSE TestAccEC2Instance_EBSRootDeviceModifyIOPS_io2
=== RUN   TestAccEC2Instance_EBSRootDeviceModifyThroughput_gp3
=== PAUSE TestAccEC2Instance_EBSRootDeviceModifyThroughput_gp3
=== RUN   TestAccEC2Instance_EBSRootDevice_modifyDeleteOnTermination
=== PAUSE TestAccEC2Instance_EBSRootDevice_modifyDeleteOnTermination
=== RUN   TestAccEC2Instance_EBSRootDevice_modifyAll
=== PAUSE TestAccEC2Instance_EBSRootDevice_modifyAll
=== RUN   TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifySize
=== PAUSE TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifySize
=== RUN   TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifyDeleteOnTermination
=== PAUSE TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifyDeleteOnTermination
=== RUN   TestAccEC2Instance_EBSRootDevice_multipleDynamicEBSBlockDevices
=== PAUSE TestAccEC2Instance_EBSRootDevice_multipleDynamicEBSBlockDevices
=== RUN   TestAccEC2Instance_primaryNetworkInterface
=== PAUSE TestAccEC2Instance_primaryNetworkInterface
=== RUN   TestAccEC2Instance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccEC2Instance_primaryNetworkInterfaceSourceDestCheck
=== RUN   TestAccEC2Instance_addSecondaryInterface
=== PAUSE TestAccEC2Instance_addSecondaryInterface
=== RUN   TestAccEC2Instance_addSecurityGroupNetworkInterface
=== PAUSE TestAccEC2Instance_addSecurityGroupNetworkInterface
=== RUN   TestAccEC2Instance_NewNetworkInterface_publicIPAndSecondaryPrivateIPs
=== PAUSE TestAccEC2Instance_NewNetworkInterface_publicIPAndSecondaryPrivateIPs
=== RUN   TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPs
=== PAUSE TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPs
=== RUN   TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPsUpdate
=== PAUSE TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPsUpdate
=== RUN   TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPs
=== PAUSE TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPs
=== RUN   TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPsUpdate
=== PAUSE TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPsUpdate
=== RUN   TestAccEC2Instance_AssociatePublic_defaultPrivate
=== PAUSE TestAccEC2Instance_AssociatePublic_defaultPrivate
=== RUN   TestAccEC2Instance_AssociatePublic_defaultPublic
=== PAUSE TestAccEC2Instance_AssociatePublic_defaultPublic
=== RUN   TestAccEC2Instance_AssociatePublic_explicitPublic
=== PAUSE TestAccEC2Instance_AssociatePublic_explicitPublic
=== RUN   TestAccEC2Instance_AssociatePublic_explicitPrivate
=== PAUSE TestAccEC2Instance_AssociatePublic_explicitPrivate
=== RUN   TestAccEC2Instance_AssociatePublic_overridePublic
=== PAUSE TestAccEC2Instance_AssociatePublic_overridePublic
=== RUN   TestAccEC2Instance_AssociatePublic_overridePrivate
=== PAUSE TestAccEC2Instance_AssociatePublic_overridePrivate
=== RUN   TestAccEC2Instance_LaunchTemplate_basic
=== PAUSE TestAccEC2Instance_LaunchTemplate_basic
=== RUN   TestAccEC2Instance_LaunchTemplate_overrideTemplate
=== PAUSE TestAccEC2Instance_LaunchTemplate_overrideTemplate
=== RUN   TestAccEC2Instance_LaunchTemplate_setSpecificVersion
=== PAUSE TestAccEC2Instance_LaunchTemplate_setSpecificVersion
=== RUN   TestAccEC2Instance_LaunchTemplateModifyTemplate_defaultVersion
=== PAUSE TestAccEC2Instance_LaunchTemplateModifyTemplate_defaultVersion
=== RUN   TestAccEC2Instance_LaunchTemplate_updateTemplateVersion
=== PAUSE TestAccEC2Instance_LaunchTemplate_updateTemplateVersion
=== RUN   TestAccEC2Instance_LaunchTemplate_swapIDAndName
=== PAUSE TestAccEC2Instance_LaunchTemplate_swapIDAndName
=== RUN   TestAccEC2Instance_GetPasswordData_falseToTrue
=== PAUSE TestAccEC2Instance_GetPasswordData_falseToTrue
=== RUN   TestAccEC2Instance_GetPasswordData_trueToFalse
=== PAUSE TestAccEC2Instance_GetPasswordData_trueToFalse
=== RUN   TestAccEC2Instance_CreditSpecificationEmpty_nonBurstable
=== PAUSE TestAccEC2Instance_CreditSpecificationEmpty_nonBurstable
=== RUN   TestAccEC2Instance_CreditSpecificationUnspecifiedToEmpty_nonBurstable
=== PAUSE TestAccEC2Instance_CreditSpecificationUnspecifiedToEmpty_nonBurstable
=== RUN   TestAccEC2Instance_CreditSpecification_unspecifiedDefaultsToStandard
=== PAUSE TestAccEC2Instance_CreditSpecification_unspecifiedDefaultsToStandard
=== RUN   TestAccEC2Instance_CreditSpecification_standardCPUCredits
=== PAUSE TestAccEC2Instance_CreditSpecification_standardCPUCredits
=== RUN   TestAccEC2Instance_CreditSpecification_unlimitedCPUCredits
=== PAUSE TestAccEC2Instance_CreditSpecification_unlimitedCPUCredits
=== RUN   TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t2
=== PAUSE TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t2
=== RUN   TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t3
=== PAUSE TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t3
=== RUN   TestAccEC2Instance_CreditSpecification_updateCPUCredits
=== PAUSE TestAccEC2Instance_CreditSpecification_updateCPUCredits
=== RUN   TestAccEC2Instance_CreditSpecification_isNotAppliedToNonBurstable
=== PAUSE TestAccEC2Instance_CreditSpecification_isNotAppliedToNonBurstable
=== RUN   TestAccEC2Instance_CreditSpecificationT3_unspecifiedDefaultsToUnlimited
=== PAUSE TestAccEC2Instance_CreditSpecificationT3_unspecifiedDefaultsToUnlimited
=== RUN   TestAccEC2Instance_CreditSpecificationT3_standardCPUCredits
=== PAUSE TestAccEC2Instance_CreditSpecificationT3_standardCPUCredits
=== RUN   TestAccEC2Instance_CreditSpecificationT3_unlimitedCPUCredits
=== PAUSE TestAccEC2Instance_CreditSpecificationT3_unlimitedCPUCredits
=== RUN   TestAccEC2Instance_CreditSpecificationT3_updateCPUCredits
=== PAUSE TestAccEC2Instance_CreditSpecificationT3_updateCPUCredits
=== RUN   TestAccEC2Instance_CreditSpecificationStandardCPUCredits_t2Tot3Taint
=== PAUSE TestAccEC2Instance_CreditSpecificationStandardCPUCredits_t2Tot3Taint
=== RUN   TestAccEC2Instance_CreditSpecificationUnlimitedCPUCredits_t2Tot3Taint
=== PAUSE TestAccEC2Instance_CreditSpecificationUnlimitedCPUCredits_t2Tot3Taint
=== RUN   TestAccEC2Instance_disappears
=== PAUSE TestAccEC2Instance_disappears
=== RUN   TestAccEC2Instance_UserData_emptyStringToUnspecified
=== PAUSE TestAccEC2Instance_UserData_emptyStringToUnspecified
=== RUN   TestAccEC2Instance_UserData_unspecifiedToEmptyString
=== PAUSE TestAccEC2Instance_UserData_unspecifiedToEmptyString
=== RUN   TestAccEC2Instance_hibernation
=== PAUSE TestAccEC2Instance_hibernation
=== RUN   TestAccEC2Instance_metadataOptions
=== PAUSE TestAccEC2Instance_metadataOptions
=== RUN   TestAccEC2Instance_enclaveOptions
=== PAUSE TestAccEC2Instance_enclaveOptions
=== RUN   TestAccEC2Instance_CapacityReservation_unspecifiedDefaultsToOpen
=== PAUSE TestAccEC2Instance_CapacityReservation_unspecifiedDefaultsToOpen
=== RUN   TestAccEC2Instance_CapacityReservationPreference_open
=== PAUSE TestAccEC2Instance_CapacityReservationPreference_open
=== RUN   TestAccEC2Instance_CapacityReservationPreference_none
=== PAUSE TestAccEC2Instance_CapacityReservationPreference_none
=== RUN   TestAccEC2Instance_CapacityReservation_targetID
=== PAUSE TestAccEC2Instance_CapacityReservation_targetID
=== RUN   TestAccEC2Instance_CapacityReservation_modifyPreference
=== PAUSE TestAccEC2Instance_CapacityReservation_modifyPreference
=== RUN   TestAccEC2Instance_CapacityReservation_modifyTarget
=== PAUSE TestAccEC2Instance_CapacityReservation_modifyTarget
=== RUN   TestAccEC2Instance_gp3RootBlockDevice
=== PAUSE TestAccEC2Instance_gp3RootBlockDevice
=== CONT  TestAccEC2Instance_inDefaultVPCBySgName
=== CONT  TestAccEC2Instance_EBSRootDevice_multipleDynamicEBSBlockDevices
=== CONT  TestAccEC2Instance_networkInstanceRemovingAllSecurityGroups
=== CONT  TestAccEC2Instance_blockDevices
--- PASS: TestAccEC2Instance_blockDevices (104.39s)
=== CONT  TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifyDeleteOnTermination
--- PASS: TestAccEC2Instance_inDefaultVPCBySgName (140.75s)
=== CONT  TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifySize
--- PASS: TestAccEC2Instance_networkInstanceRemovingAllSecurityGroups (180.03s)
=== CONT  TestAccEC2Instance_EBSRootDevice_modifyAll
--- PASS: TestAccEC2Instance_EBSRootDevice_multipleDynamicEBSBlockDevices (219.71s)
=== CONT  TestAccEC2Instance_EBSRootDevice_modifyDeleteOnTermination
--- PASS: TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifyDeleteOnTermination (158.00s)
=== CONT  TestAccEC2Instance_EBSRootDeviceModifyThroughput_gp3
--- PASS: TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifySize (166.74s)
=== CONT  TestAccEC2Instance_networkInstanceSecurityGroups
--- PASS: TestAccEC2Instance_EBSRootDevice_modifyAll (191.06s)
=== CONT  TestAccEC2Instance_EBSRootDeviceModifyIOPS_io2
--- PASS: TestAccEC2Instance_EBSRootDevice_modifyDeleteOnTermination (164.38s)
=== CONT  TestAccEC2Instance_IPv6_supportAddressCountWithIPv4
--- PASS: TestAccEC2Instance_EBSRootDeviceModifyThroughput_gp3 (181.48s)
=== CONT  TestAccEC2Instance_EBSRootDeviceModifyIOPS_io1
--- PASS: TestAccEC2Instance_networkInstanceSecurityGroups (138.23s)
=== CONT  TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError (32.17s)
=== CONT  TestAccEC2Instance_EBSRootDevice_modifyType
--- PASS: TestAccEC2Instance_IPv6_supportAddressCountWithIPv4 (155.70s)
=== CONT  TestAccEC2Instance_IPv6_supportAddressCount
--- PASS: TestAccEC2Instance_EBSRootDeviceModifyIOPS_io2 (208.03s)
=== CONT  TestAccEC2Instance_EBSRootDevice_modifySize
--- PASS: TestAccEC2Instance_EBSRootDeviceModifyIOPS_io1 (208.55s)
=== CONT  TestAccEC2Instance_EBSRootDevice_basic
--- PASS: TestAccEC2Instance_IPv6_supportAddressCount (154.88s)
=== CONT  TestAccEC2Instance_EBSBlockDevice_invalidThroughputForVolumeType
--- PASS: TestAccEC2Instance_EBSBlockDevice_invalidThroughputForVolumeType (15.39s)
=== CONT  TestAccEC2Instance_gp2WithIopsValue
--- PASS: TestAccEC2Instance_EBSRootDevice_modifyType (243.00s)
=== CONT  TestAccEC2Instance_gp2IopsDevice
--- PASS: TestAccEC2Instance_gp2WithIopsValue (13.62s)
=== CONT  TestAccEC2Instance_changeInstanceType
--- PASS: TestAccEC2Instance_EBSRootDevice_modifySize (174.10s)
=== CONT  TestAccEC2Instance_userDataBase64
--- PASS: TestAccEC2Instance_EBSRootDevice_basic (111.23s)
=== CONT  TestAccEC2Instance_RootBlockDevice_kmsKeyARN
--- PASS: TestAccEC2Instance_gp2IopsDevice (112.76s)
=== CONT  TestAccEC2Instance_forceNewAndTagsDrift
--- PASS: TestAccEC2Instance_userDataBase64 (135.88s)
=== CONT  TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
--- PASS: TestAccEC2Instance_RootBlockDevice_kmsKeyARN (128.06s)
=== CONT  TestAccEC2Instance_rootBlockDeviceMismatch
--- PASS: TestAccEC2Instance_changeInstanceType (340.59s)
=== CONT  TestAccEC2Instance_keyPairCheck
--- PASS: TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed (178.79s)
=== CONT  TestAccEC2Instance_EBSBlockDevice_invalidIopsForVolumeType
--- PASS: TestAccEC2Instance_forceNewAndTagsDrift (244.76s)
=== CONT  TestAccEC2Instance_placementPartitionNumber
--- PASS: TestAccEC2Instance_EBSBlockDevice_invalidIopsForVolumeType (16.69s)
=== CONT  TestAccEC2Instance_Empty_privateIP
--- PASS: TestAccEC2Instance_rootBlockDeviceMismatch (218.39s)
=== CONT  TestAccEC2Instance_disableAPITermination
--- PASS: TestAccEC2Instance_keyPairCheck (123.39s)
=== CONT  TestAccEC2Instance_sourceDestCheck
--- PASS: TestAccEC2Instance_placementPartitionNumber (126.98s)
=== CONT  TestAccEC2Instance_placementGroup
--- PASS: TestAccEC2Instance_Empty_privateIP (124.91s)
=== CONT  TestAccEC2Instance_outpost
    acctest.go:1255: skipping since no Outposts found
--- SKIP: TestAccEC2Instance_outpost (0.61s)
=== CONT  TestAccEC2Instance_dedicatedInstance
--- PASS: TestAccEC2Instance_disableAPITermination (177.92s)
=== CONT  TestAccEC2Instance_associatePublicIPAndPrivateIP
--- PASS: TestAccEC2Instance_placementGroup (104.96s)
=== CONT  TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
--- PASS: TestAccEC2Instance_dedicatedInstance (127.41s)
=== CONT  TestAccEC2Instance_BlockDeviceTags_withAttachedVolume
--- PASS: TestAccEC2Instance_sourceDestCheck (214.97s)
=== CONT  TestAccEC2Instance_privateIP
--- PASS: TestAccEC2Instance_associatePublicIPAndPrivateIP (140.38s)
=== CONT  TestAccEC2Instance_noAMIEphemeralDevices
--- PASS: TestAccEC2Instance_BlockDeviceTags_ebsAndRoot (191.32s)
=== CONT  TestAccEC2Instance_rootInstanceStore
--- PASS: TestAccEC2Instance_privateIP (128.23s)
=== CONT  TestAccEC2Instance_CreditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccEC2Instance_noAMIEphemeralDevices (109.59s)
=== CONT  TestAccEC2Instance_BlockDeviceTags_volumeTags
--- PASS: TestAccEC2Instance_BlockDeviceTags_withAttachedVolume (216.71s)
=== CONT  TestAccEC2Instance_gp3RootBlockDevice
--- PASS: TestAccEC2Instance_rootInstanceStore (119.30s)
=== CONT  TestAccEC2Instance_tags
--- PASS: TestAccEC2Instance_CreditSpecification_unspecifiedDefaultsToStandard (131.17s)
=== CONT  TestAccEC2Instance_networkInstanceVPCSecurityGroupIDs
--- PASS: TestAccEC2Instance_gp3RootBlockDevice (108.92s)
=== CONT  TestAccEC2Instance_withIAMInstanceProfilePath
--- PASS: TestAccEC2Instance_tags (170.16s)
=== CONT  TestAccEC2Instance_withIAMInstanceProfile
--- PASS: TestAccEC2Instance_withIAMInstanceProfilePath (144.01s)
=== CONT  TestAccEC2Instance_AssociatePublic_explicitPrivate
--- PASS: TestAccEC2Instance_networkInstanceVPCSecurityGroupIDs (145.43s)
=== CONT  TestAccEC2Instance_instanceProfileChange
--- PASS: TestAccEC2Instance_BlockDeviceTags_volumeTags (307.62s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnspecifiedToEmpty_nonBurstable
--- PASS: TestAccEC2Instance_AssociatePublic_explicitPrivate (130.07s)
=== CONT  TestAccEC2Instance_EBSBlockDevice_kmsKeyARN
--- PASS: TestAccEC2Instance_withIAMInstanceProfile (169.25s)
=== CONT  TestAccEC2Instance_CreditSpecificationEmpty_nonBurstable
--- PASS: TestAccEC2Instance_CreditSpecificationUnspecifiedToEmpty_nonBurstable (134.20s)
=== CONT  TestAccEC2Instance_GetPasswordData_trueToFalse
--- PASS: TestAccEC2Instance_EBSBlockDevice_kmsKeyARN (117.96s)
=== CONT  TestAccEC2Instance_GetPasswordData_falseToTrue
--- PASS: TestAccEC2Instance_CreditSpecificationEmpty_nonBurstable (147.68s)
=== CONT  TestAccEC2Instance_LaunchTemplate_swapIDAndName
--- PASS: TestAccEC2Instance_instanceProfileChange (307.45s)
=== CONT  TestAccEC2Instance_LaunchTemplate_updateTemplateVersion
--- PASS: TestAccEC2Instance_LaunchTemplate_swapIDAndName (125.93s)
=== CONT  TestAccEC2Instance_LaunchTemplateModifyTemplate_defaultVersion
--- PASS: TestAccEC2Instance_GetPasswordData_trueToFalse (268.43s)
=== CONT  TestAccEC2Instance_inEC2Classic
--- PASS: TestAccEC2Instance_GetPasswordData_falseToTrue (200.01s)
=== CONT  TestAccEC2Instance_basic
--- PASS: TestAccEC2Instance_LaunchTemplate_updateTemplateVersion (230.85s)
=== CONT  TestAccEC2Instance_inDefaultVPCBySgID
--- PASS: TestAccEC2Instance_inEC2Classic (113.69s)
=== CONT  TestAccEC2Instance_LaunchTemplate_setSpecificVersion
--- PASS: TestAccEC2Instance_LaunchTemplateModifyTemplate_defaultVersion (128.02s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPsUpdate
--- PASS: TestAccEC2Instance_basic (109.78s)
=== CONT  TestAccEC2Instance_AssociatePublic_explicitPublic
--- PASS: TestAccEC2Instance_inDefaultVPCBySgID (112.23s)
=== CONT  TestAccEC2Instance_atLeastOneOtherEBSVolume
--- PASS: TestAccEC2Instance_AssociatePublic_explicitPublic (138.78s)
=== CONT  TestAccEC2Instance_AssociatePublic_defaultPublic
--- PASS: TestAccEC2Instance_LaunchTemplate_setSpecificVersion (161.50s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPsUpdate
--- PASS: TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPsUpdate (207.92s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPs
--- PASS: TestAccEC2Instance_AssociatePublic_defaultPublic (147.50s)
=== CONT  TestAccEC2Instance_AssociatePublic_overridePrivate
--- PASS: TestAccEC2Instance_atLeastOneOtherEBSVolume (250.60s)
=== CONT  TestAccEC2Instance_LaunchTemplate_overrideTemplate
--- PASS: TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPs (142.20s)
=== CONT  TestAccEC2Instance_AssociatePublic_overridePublic
--- PASS: TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPsUpdate (202.80s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnlimitedCPUCredits_t2Tot3Taint
--- PASS: TestAccEC2Instance_AssociatePublic_overridePrivate (142.74s)
=== CONT  TestAccEC2Instance_AssociatePublic_defaultPrivate
--- PASS: TestAccEC2Instance_LaunchTemplate_overrideTemplate (100.09s)
=== CONT  TestAccEC2Instance_addSecurityGroupNetworkInterface
--- PASS: TestAccEC2Instance_AssociatePublic_overridePublic (124.28s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPs
--- PASS: TestAccEC2Instance_AssociatePublic_defaultPrivate (137.67s)
=== CONT  TestAccEC2Instance_LaunchTemplate_basic
--- PASS: TestAccEC2Instance_CreditSpecificationUnlimitedCPUCredits_t2Tot3Taint (209.90s)
=== CONT  TestAccEC2Instance_enclaveOptions
--- PASS: TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPs (122.59s)
=== CONT  TestAccEC2Instance_CapacityReservation_targetID
--- PASS: TestAccEC2Instance_LaunchTemplate_basic (83.49s)
=== CONT  TestAccEC2Instance_CapacityReservationPreference_none
--- PASS: TestAccEC2Instance_CapacityReservation_targetID (133.03s)
=== CONT  TestAccEC2Instance_CapacityReservationPreference_open
--- PASS: TestAccEC2Instance_CapacityReservationPreference_none (110.94s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_publicIPAndSecondaryPrivateIPs
--- PASS: TestAccEC2Instance_enclaveOptions (197.31s)
=== CONT  TestAccEC2Instance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccEC2Instance_CapacityReservationPreference_open (122.68s)
=== CONT  TestAccEC2Instance_addSecondaryInterface
--- PASS: TestAccEC2Instance_addSecurityGroupNetworkInterface (450.73s)
=== CONT  TestAccEC2Instance_CapacityReservation_unspecifiedDefaultsToOpen
--- PASS: TestAccEC2Instance_primaryNetworkInterfaceSourceDestCheck (134.66s)
=== CONT  TestAccEC2Instance_CreditSpecification_isNotAppliedToNonBurstable
--- PASS: TestAccEC2Instance_CreditSpecification_isNotAppliedToNonBurstable (115.91s)
=== CONT  TestAccEC2Instance_CreditSpecificationStandardCPUCredits_t2Tot3Taint
--- PASS: TestAccEC2Instance_CapacityReservation_unspecifiedDefaultsToOpen (149.84s)
=== CONT  TestAccEC2Instance_CreditSpecificationT3_updateCPUCredits
--- PASS: TestAccEC2Instance_NewNetworkInterface_publicIPAndSecondaryPrivateIPs (285.07s)
=== CONT  TestAccEC2Instance_CapacityReservation_modifyPreference
    instance_test.go:3712: Step 3/3 error: Check failed: Check 4/4 error: aws_instance.test: Attribute 'capacity_reservation_specification.0.capacity_reservation_preference' expected "none", got "open"
--- FAIL: TestAccEC2Instance_CapacityReservation_modifyPreference (192.11s)
=== CONT  TestAccEC2Instance_metadataOptions
--- PASS: TestAccEC2Instance_CreditSpecificationStandardCPUCredits_t2Tot3Taint (235.75s)
=== CONT  TestAccEC2Instance_hibernation
--- PASS: TestAccEC2Instance_CreditSpecificationT3_updateCPUCredits (244.91s)
=== CONT  TestAccEC2Instance_UserData_unspecifiedToEmptyString
--- PASS: TestAccEC2Instance_addSecondaryInterface (459.81s)
=== CONT  TestAccEC2Instance_UserData_emptyStringToUnspecified
--- PASS: TestAccEC2Instance_metadataOptions (150.42s)
=== CONT  TestAccEC2Instance_primaryNetworkInterface
--- PASS: TestAccEC2Instance_UserData_unspecifiedToEmptyString (146.43s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t2
--- PASS: TestAccEC2Instance_UserData_emptyStringToUnspecified (159.42s)
=== CONT  TestAccEC2Instance_CreditSpecification_updateCPUCredits
--- PASS: TestAccEC2Instance_hibernation (236.66s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t3
--- PASS: TestAccEC2Instance_primaryNetworkInterface (140.46s)
=== CONT  TestAccEC2Instance_CreditSpecificationT3_unlimitedCPUCredits
--- PASS: TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t2 (137.69s)
=== CONT  TestAccEC2Instance_CreditSpecification_unlimitedCPUCredits
--- PASS: TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t3 (130.99s)
=== CONT  TestAccEC2Instance_CreditSpecification_standardCPUCredits
--- PASS: TestAccEC2Instance_CreditSpecificationT3_unlimitedCPUCredits (135.52s)
=== CONT  TestAccEC2Instance_CreditSpecificationT3_unspecifiedDefaultsToUnlimited
--- PASS: TestAccEC2Instance_CreditSpecification_updateCPUCredits (204.44s)
=== CONT  TestAccEC2Instance_disappears
--- PASS: TestAccEC2Instance_CreditSpecification_unlimitedCPUCredits (173.06s)
=== CONT  TestAccEC2Instance_CreditSpecificationT3_standardCPUCredits
--- PASS: TestAccEC2Instance_CreditSpecificationT3_unspecifiedDefaultsToUnlimited (108.41s)
=== CONT  TestAccEC2Instance_CapacityReservation_modifyTarget
--- PASS: TestAccEC2Instance_CreditSpecification_standardCPUCredits (205.63s)
--- PASS: TestAccEC2Instance_CreditSpecificationT3_standardCPUCredits (128.30s)
--- PASS: TestAccEC2Instance_CapacityReservation_modifyTarget (192.55s)
--- PASS: TestAccEC2Instance_disappears (299.52s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	4341.417s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change.

@anGie44 anGie44 added this to the v3.74.0 milestone Jan 25, 2022
@anGie44 anGie44 merged commit c4586b3 into main Jan 25, 2022
@anGie44 anGie44 deleted the b-instance-nil-block-devices branch January 25, 2022 13:23
github-actions bot pushed a commit that referenced this pull request Jan 25, 2022
Update CHANGELOG.md for #22719
2714242
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.74.0
2 participants
@anGie44 @ewbankkit