r/aws_vpc_dhcp_options_association: Support default DHCP Options ID

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22716.

Prior to the fix:

% make testacc TESTARGS='-run=TestAccEC2VPCDHCPOptionsAssociation_default' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPCDHCPOptionsAssociation_default -timeout 180m
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_default
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_default
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_default
    vpc_dhcp_options_association_test.go:113: Step 1/2 error: Error running apply: exit status 1
        
        Error: unexpected format for ID (default-vpc-0c3d3a2ecaff91a69), expected DHCPOptionsID-VPCID
        
          with aws_vpc_dhcp_options_association.test,
          on terraform_plugin_test.tf line 15, in resource "aws_vpc_dhcp_options_association" "test":
          15: resource "aws_vpc_dhcp_options_association" "test" {
        
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: unexpected format for ID (default-vpc-0c3d3a2ecaff91a69), expected DHCPOptionsID-VPCID
        
--- FAIL: TestAccEC2VPCDHCPOptionsAssociation_default (13.84s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ec2        17.503s
FAIL
make: *** [testacc] Error 1

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccEC2VPCDHCPOptionsAssociation_' PKG=ec2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPCDHCPOptionsAssociation_ -timeout 180m
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_basic
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_basic
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_disappears
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_disappears
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_default
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_default
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_basic
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_disappears
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_default
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc (21.84s)
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_disappears (25.71s)
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp (26.49s)
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_default (28.16s)
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_basic (28.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        33.742s

[anGie44]

LGTM 🚀

Hmm i wonder if we should try to have more unit tests for these parse "id" type methods. we have them in some places, though doesn't necessarily guarantee we'll always catch these unique ones ahead of time

[github-actions]

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.