Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/apigatewayv2_export - new data source #22732

Merged
merged 5 commits into from
Jan 24, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 22, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12942.

Output from acceptance testing:

$ make testacc TESTS=TestAccExportGatewayV2ExportDataSource_ PKG=apigatewayv2

--- PASS: TestAccExportGatewayV2ExportDataSource_basic (40.71s)
--- PASS: TestAccExportGatewayV2ExportDataSource_stage (49.20s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jan 22, 2022
@DrFaust92 DrFaust92 changed the title d/apigateway_v2_export - new data source d/apigatewayv2_export - new data source Jan 22, 2022
@DrFaust92 DrFaust92 added the new-data-source Introduces a new data source. label Jan 22, 2022
… (o1hlpon70b): BadRequestException: No deployment is available in the stage tf-acc-test-5885592264819914276'.
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccExportGatewayV2ExportDataSource_' PKG=apigatewayv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20  -run=TestAccExportGatewayV2ExportDataSource_ -timeout 180m
=== RUN   TestAccExportGatewayV2ExportDataSource_basic
=== PAUSE TestAccExportGatewayV2ExportDataSource_basic
=== RUN   TestAccExportGatewayV2ExportDataSource_stage
=== PAUSE TestAccExportGatewayV2ExportDataSource_stage
=== CONT  TestAccExportGatewayV2ExportDataSource_basic
=== CONT  TestAccExportGatewayV2ExportDataSource_stage
--- PASS: TestAccExportGatewayV2ExportDataSource_basic (26.52s)
--- PASS: TestAccExportGatewayV2ExportDataSource_stage (31.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	37.164s
GovCloud
% make testacc TESTARGS='-run=TestAccExportGatewayV2ExportDataSource_' PKG=apigatewayv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20  -run=TestAccExportGatewayV2ExportDataSource_ -timeout 180m
=== RUN   TestAccExportGatewayV2ExportDataSource_basic
=== PAUSE TestAccExportGatewayV2ExportDataSource_basic
=== RUN   TestAccExportGatewayV2ExportDataSource_stage
=== PAUSE TestAccExportGatewayV2ExportDataSource_stage
=== CONT  TestAccExportGatewayV2ExportDataSource_basic
=== CONT  TestAccExportGatewayV2ExportDataSource_stage
--- PASS: TestAccExportGatewayV2ExportDataSource_basic (30.01s)
--- PASS: TestAccExportGatewayV2ExportDataSource_stage (35.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	40.684s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d32dc39 into hashicorp:main Jan 24, 2022
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 24, 2022
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the apigwv2_export branch February 12, 2022 12:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting API Gateway HTTP APIs as OpenAPI 3.0
2 participants