Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_imagebuilder_distribution_configurations - new data source #22733

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Jan 22, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17035.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccImageBuilderDistributionConfigurationsDataSource_" PKG_NAME=internal/service/imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderDistributionConfigurationsDataSource_ -timeout 180m
=== RUN   TestAccImageBuilderDistributionConfigurationsDataSource_filter
=== PAUSE TestAccImageBuilderDistributionConfigurationsDataSource_filter
=== CONT  TestAccImageBuilderDistributionConfigurationsDataSource_filter
--- PASS: TestAccImageBuilderDistributionConfigurationsDataSource_filter (31.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       39.472s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Jan 22, 2022
@kamilturek kamilturek marked this pull request as ready for review January 23, 2022 08:32
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 24, 2022
@ewbankkit ewbankkit force-pushed the f-aws_imagebuilder_distribution_configurations_data_source branch from 9737b53 to c8f7347 Compare January 24, 2022 14:06
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTS=TestAccImageBuilderDistributionConfigurationsDataSource_ PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run='TestAccImageBuilderDistributionConfigurationsDataSource_'  -timeout 180m
=== RUN   TestAccImageBuilderDistributionConfigurationsDataSource_filter
=== PAUSE TestAccImageBuilderDistributionConfigurationsDataSource_filter
=== CONT  TestAccImageBuilderDistributionConfigurationsDataSource_filter
--- PASS: TestAccImageBuilderDistributionConfigurationsDataSource_filter (21.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	27.128s
GovCloud
% make testacc TESTS=TestAccImageBuilderDistributionConfigurationsDataSource_ PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run='TestAccImageBuilderDistributionConfigurationsDataSource_'  -timeout 180m
=== RUN   TestAccImageBuilderDistributionConfigurationsDataSource_filter
=== PAUSE TestAccImageBuilderDistributionConfigurationsDataSource_filter
=== CONT  TestAccImageBuilderDistributionConfigurationsDataSource_filter
--- PASS: TestAccImageBuilderDistributionConfigurationsDataSource_filter (23.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	30.226s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c333e36 into hashicorp:main Jan 24, 2022
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 24, 2022
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@kamilturek kamilturek deleted the f-aws_imagebuilder_distribution_configurations_data_source branch February 11, 2022 16:56
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data "aws_imagebuilder_*"
2 participants