Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cloudwatch_event_target: remove launch_type default #22803

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 27, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16078
Relates #22776
Relates #20433

Output from acceptance testing:

--- PASS: TestAccEventsTarget_Input_transformer (104.27s)
--- PASS: TestAccEventsTarget_RetryPolicy_deadLetter (109.71s)
--- PASS: TestAccEventsTarget_basic (118.85s)
--- PASS: TestAccEventsTarget_batch (131.47s)
--- PASS: TestAccEventsTarget_disappears (60.23s)
--- PASS: TestAccEventsTarget_ecs (317.22s)
--- PASS: TestAccEventsTarget_ecsFull (96.61s)
--- PASS: TestAccEventsTarget_ecsWithBlankLaunchType (134.21s)
--- PASS: TestAccEventsTarget_ecsWithBlankTaskCount (316.90s)
--- PASS: TestAccEventsTarget_ecsWithoutLaunchType (133.32s)
--- PASS: TestAccEventsTarget_eventBusARN (80.01s)
--- PASS: TestAccEventsTarget_eventBusName (108.13s)
--- PASS: TestAccEventsTarget_full (112.59s)
--- PASS: TestAccEventsTarget_generatedTargetID (68.02s)
--- PASS: TestAccEventsTarget_http (78.19s)
--- PASS: TestAccEventsTarget_inputTransformerJSONString (98.11s)
--- PASS: TestAccEventsTarget_kinesis (112.95s)
--- PASS: TestAccEventsTarget_redshift (293.13s)
--- PASS: TestAccEventsTarget_sqs (105.17s)
--- PASS: TestAccEventsTarget_ssmDocument (80.44s)
--- SKIP: TestAccEventsTarget_partnerEventBus (0.00s)

@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 27, 2022
@anGie44 anGie44 added this to the v4.0.0 milestone Jan 27, 2022
@github-actions github-actions bot added service/events Issues and PRs that pertain to the events service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jan 27, 2022
anGie44 added a commit that referenced this pull request Jan 27, 2022
@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 19:31
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 13942a7 to e604544 Compare January 28, 2022 22:15
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44 anGie44 force-pushed the b-cloudwatch-event-target-launch-type-default-removal branch from dba7e70 to c49cf34 Compare January 28, 2022 22:23
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44 anGie44 force-pushed the b-cloudwatch-event-target-launch-type-default-removal branch from c49cf34 to fb9293a Compare January 28, 2022 22:23
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44 anGie44 force-pushed the b-cloudwatch-event-target-launch-type-default-removal branch from fb9293a to 9969917 Compare January 28, 2022 22:24
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44 anGie44 force-pushed the b-cloudwatch-event-target-launch-type-default-removal branch from 9969917 to 2fa711b Compare January 28, 2022 22:26
anGie44 added a commit that referenced this pull request Jan 28, 2022
@anGie44 anGie44 force-pushed the b-cloudwatch-event-target-launch-type-default-removal branch from 2fa711b to 2a1d3fc Compare January 28, 2022 22:39
Base automatically changed from release/4.x to main January 31, 2022 22:59
anGie44 added a commit that referenced this pull request Feb 1, 2022
@anGie44 anGie44 force-pushed the b-cloudwatch-event-target-launch-type-default-removal branch from 2a1d3fc to 68098a2 Compare February 1, 2022 00:11
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEventsTarget_' PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20  -run=TestAccEventsTarget_ -timeout 180m
=== RUN   TestAccEventsTarget_basic
=== PAUSE TestAccEventsTarget_basic
=== RUN   TestAccEventsTarget_eventBusName
=== PAUSE TestAccEventsTarget_eventBusName
=== RUN   TestAccEventsTarget_eventBusARN
=== PAUSE TestAccEventsTarget_eventBusARN
=== RUN   TestAccEventsTarget_generatedTargetID
=== PAUSE TestAccEventsTarget_generatedTargetID
=== RUN   TestAccEventsTarget_RetryPolicy_deadLetter
=== PAUSE TestAccEventsTarget_RetryPolicy_deadLetter
=== RUN   TestAccEventsTarget_full
=== PAUSE TestAccEventsTarget_full
=== RUN   TestAccEventsTarget_disappears
=== PAUSE TestAccEventsTarget_disappears
=== RUN   TestAccEventsTarget_ssmDocument
=== PAUSE TestAccEventsTarget_ssmDocument
=== RUN   TestAccEventsTarget_http
=== PAUSE TestAccEventsTarget_http
=== RUN   TestAccEventsTarget_ecs
=== PAUSE TestAccEventsTarget_ecs
=== RUN   TestAccEventsTarget_redshift
=== PAUSE TestAccEventsTarget_redshift
=== RUN   TestAccEventsTarget_ecsWithoutLaunchType
=== PAUSE TestAccEventsTarget_ecsWithoutLaunchType
=== RUN   TestAccEventsTarget_ecsWithBlankLaunchType
=== PAUSE TestAccEventsTarget_ecsWithBlankLaunchType
=== RUN   TestAccEventsTarget_ecsWithBlankTaskCount
=== PAUSE TestAccEventsTarget_ecsWithBlankTaskCount
=== RUN   TestAccEventsTarget_ecsFull
=== PAUSE TestAccEventsTarget_ecsFull
=== RUN   TestAccEventsTarget_batch
=== PAUSE TestAccEventsTarget_batch
=== RUN   TestAccEventsTarget_kinesis
=== PAUSE TestAccEventsTarget_kinesis
=== RUN   TestAccEventsTarget_sqs
=== PAUSE TestAccEventsTarget_sqs
=== RUN   TestAccEventsTarget_Input_transformer
=== PAUSE TestAccEventsTarget_Input_transformer
=== RUN   TestAccEventsTarget_inputTransformerJSONString
=== PAUSE TestAccEventsTarget_inputTransformerJSONString
=== RUN   TestAccEventsTarget_partnerEventBus
    target_test.go:796: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsTarget_partnerEventBus (0.00s)
=== CONT  TestAccEventsTarget_basic
=== CONT  TestAccEventsTarget_redshift
=== CONT  TestAccEventsTarget_ecsWithBlankTaskCount
=== CONT  TestAccEventsTarget_ecsWithoutLaunchType
=== CONT  TestAccEventsTarget_generatedTargetID
=== CONT  TestAccEventsTarget_batch
=== CONT  TestAccEventsTarget_inputTransformerJSONString
=== CONT  TestAccEventsTarget_Input_transformer
=== CONT  TestAccEventsTarget_sqs
=== CONT  TestAccEventsTarget_kinesis
=== CONT  TestAccEventsTarget_full
=== CONT  TestAccEventsTarget_ssmDocument
=== CONT  TestAccEventsTarget_ecs
=== CONT  TestAccEventsTarget_http
=== CONT  TestAccEventsTarget_disappears
=== CONT  TestAccEventsTarget_eventBusARN
=== CONT  TestAccEventsTarget_RetryPolicy_deadLetter
=== CONT  TestAccEventsTarget_ecsWithBlankLaunchType
=== CONT  TestAccEventsTarget_ecsFull
=== CONT  TestAccEventsTarget_eventBusName
--- PASS: TestAccEventsTarget_disappears (35.00s)
--- PASS: TestAccEventsTarget_generatedTargetID (39.59s)
--- PASS: TestAccEventsTarget_eventBusARN (40.35s)
--- PASS: TestAccEventsTarget_http (42.89s)
--- PASS: TestAccEventsTarget_ssmDocument (45.47s)
--- PASS: TestAccEventsTarget_inputTransformerJSONString (49.95s)
--- PASS: TestAccEventsTarget_eventBusName (60.03s)
--- PASS: TestAccEventsTarget_Input_transformer (61.43s)
--- PASS: TestAccEventsTarget_sqs (67.72s)
--- PASS: TestAccEventsTarget_basic (69.13s)
--- PASS: TestAccEventsTarget_ecsWithBlankTaskCount (70.47s)
--- PASS: TestAccEventsTarget_full (73.55s)
--- PASS: TestAccEventsTarget_RetryPolicy_deadLetter (73.92s)
--- PASS: TestAccEventsTarget_kinesis (74.43s)
--- PASS: TestAccEventsTarget_ecsFull (77.65s)
--- PASS: TestAccEventsTarget_ecsWithoutLaunchType (101.41s)
--- PASS: TestAccEventsTarget_ecsWithBlankLaunchType (101.62s)
--- PASS: TestAccEventsTarget_batch (148.70s)
--- PASS: TestAccEventsTarget_redshift (219.97s)
--- PASS: TestAccEventsTarget_ecs (303.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	307.752s

.changelog/22803.txt Outdated Show resolved Hide resolved
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 2, 2022

Note: Should probably be mentioned in the upgrade guide #22818

@anGie44 anGie44 force-pushed the b-cloudwatch-event-target-launch-type-default-removal branch from 722d634 to 99b7f07 Compare February 2, 2022 18:00
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 2, 2022
@anGie44 anGie44 force-pushed the b-cloudwatch-event-target-launch-type-default-removal branch from 6752037 to 71ae3b3 Compare February 2, 2022 18:11
@anGie44 anGie44 merged commit 9e4f677 into main Feb 2, 2022
@anGie44 anGie44 deleted the b-cloudwatch-event-target-launch-type-default-removal branch February 2, 2022 18:25
github-actions bot pushed a commit that referenced this pull request Feb 2, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/events Issues and PRs that pertain to the events service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_cloudwatch_event_target: ecs_target's launch_type should not have a default
2 participants