Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_connect_routing_profile #22813

Merged
merged 22 commits into from
Mar 3, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Jan 28, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21023

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectRoutingProfile_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectRoutingProfile_serial'  -timeout 180m
=== RUN   TestAccConnectRoutingProfile_serial
=== RUN   TestAccConnectRoutingProfile_serial/update_concurrency
=== RUN   TestAccConnectRoutingProfile_serial/update_default_outbound_queue
=== RUN   TestAccConnectRoutingProfile_serial/update_queues
=== RUN   TestAccConnectRoutingProfile_serial/basic
=== RUN   TestAccConnectRoutingProfile_serial/disappears
    routing_profile_test.go:93: Routing Profiles do not support deletion today
--- PASS: TestAccConnectRoutingProfile_serial (1020.69s)
    --- PASS: TestAccConnectRoutingProfile_serial/update_concurrency (222.90s)
    --- PASS: TestAccConnectRoutingProfile_serial/update_default_outbound_queue (201.90s)
    --- PASS: TestAccConnectRoutingProfile_serial/update_queues (382.58s)
    --- PASS: TestAccConnectRoutingProfile_serial/basic (213.31s)
    --- SKIP: TestAccConnectRoutingProfile_serial/disappears (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    1028.694s

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 28, 2022
@GlennChia GlennChia marked this pull request as ready for review January 28, 2022 13:26
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccConnectRoutingProfile_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectRoutingProfile_serial'  -timeout 180m
=== RUN   TestAccConnectRoutingProfile_serial
=== RUN   TestAccConnectRoutingProfile_serial/basic
=== RUN   TestAccConnectRoutingProfile_serial/disappears
    routing_profile_test.go:93: Routing Profiles do not support deletion today
=== RUN   TestAccConnectRoutingProfile_serial/update_concurrency
=== RUN   TestAccConnectRoutingProfile_serial/update_default_outbound_queue
=== RUN   TestAccConnectRoutingProfile_serial/update_queues
--- PASS: TestAccConnectRoutingProfile_serial (552.58s)
    --- PASS: TestAccConnectRoutingProfile_serial/basic (119.97s)
    --- SKIP: TestAccConnectRoutingProfile_serial/disappears (0.00s)
    --- PASS: TestAccConnectRoutingProfile_serial/update_concurrency (124.07s)
    --- PASS: TestAccConnectRoutingProfile_serial/update_default_outbound_queue (117.31s)
    --- PASS: TestAccConnectRoutingProfile_serial/update_queues (191.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	558.757s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b311d69 into hashicorp:main Mar 3, 2022
@github-actions github-actions bot added this to the v4.4.0 milestone Mar 3, 2022
@GlennChia GlennChia deleted the f-aws_connect_routing_profile branch March 3, 2022 16:28
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants