Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_connect_queue-update quick connect ids #22821

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Jan 28, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21021
Closes #22849

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectQueue_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQueue_serial'  -timeout 180m
=== RUN   TestAccConnectQueue_serial
=== RUN   TestAccConnectQueue_serial/update_max_contacts
    queue_test.go:188: A bug in the service API has been reported
=== RUN   TestAccConnectQueue_serial/update_outbound_caller_config
=== RUN   TestAccConnectQueue_serial/update_status
=== RUN   TestAccConnectQueue_serial/update_quick_connect_ids
=== RUN   TestAccConnectQueue_serial/basic
=== RUN   TestAccConnectQueue_serial/disappears
    queue_test.go:92: Queues do not support deletion today
=== RUN   TestAccConnectQueue_serial/update_hours_of_operation_id
--- PASS: TestAccConnectQueue_serial (1293.15s)
    --- SKIP: TestAccConnectQueue_serial/update_max_contacts (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_outbound_caller_config (211.94s)
    --- PASS: TestAccConnectQueue_serial/update_status (209.09s)
    --- PASS: TestAccConnectQueue_serial/update_quick_connect_ids (364.77s)
    --- PASS: TestAccConnectQueue_serial/basic (237.51s)
    --- SKIP: TestAccConnectQueue_serial/disappears (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_hours_of_operation_id (269.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    1301.329s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 28, 2022
@GlennChia GlennChia mentioned this pull request Jan 28, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 1, 2022
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @GlennChia!

Validated Acceptance Tests in Commercial (us-west-2)

make testacc TESTS=TestAccConnectQueue_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQueue_serial'  -timeout 180m
=== RUN   TestAccConnectQueue_serial
=== RUN   TestAccConnectQueue_serial/update_quick_connect_ids
=== RUN   TestAccConnectQueue_serial/basic
=== RUN   TestAccConnectQueue_serial/disappears
    queue_test.go:92: Queues do not support deletion today
=== RUN   TestAccConnectQueue_serial/update_hours_of_operation_id
=== RUN   TestAccConnectQueue_serial/update_max_contacts
    queue_test.go:188: A bug in the service API has been reported
=== RUN   TestAccConnectQueue_serial/update_outbound_caller_config
=== RUN   TestAccConnectQueue_serial/update_status
--- PASS: TestAccConnectQueue_serial (633.71s)
    --- PASS: TestAccConnectQueue_serial/update_quick_connect_ids (215.14s)
    --- PASS: TestAccConnectQueue_serial/basic (102.50s)
    --- SKIP: TestAccConnectQueue_serial/disappears (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_hours_of_operation_id (120.57s)
    --- SKIP: TestAccConnectQueue_serial/update_max_contacts (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_outbound_caller_config (92.75s)
    --- PASS: TestAccConnectQueue_serial/update_status (102.74s)
PASS

Validated Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTS=TestAccConnectQueue_serial PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectQueue_serial'  -timeout 180m
=== RUN   TestAccConnectQueue_serial
=== RUN   TestAccConnectQueue_serial/update_max_contacts
    queue_test.go:188: A bug in the service API has been reported
=== RUN   TestAccConnectQueue_serial/update_outbound_caller_config
=== RUN   TestAccConnectQueue_serial/update_status
=== RUN   TestAccConnectQueue_serial/update_quick_connect_ids
=== RUN   TestAccConnectQueue_serial/basic
=== RUN   TestAccConnectQueue_serial/disappears
    queue_test.go:92: Queues do not support deletion today
=== RUN   TestAccConnectQueue_serial/update_hours_of_operation_id
--- PASS: TestAccConnectQueue_serial (546.97s)
    --- SKIP: TestAccConnectQueue_serial/update_max_contacts (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_outbound_caller_config (158.68s)
    --- PASS: TestAccConnectQueue_serial/update_status (84.86s)
    --- PASS: TestAccConnectQueue_serial/update_quick_connect_ids (117.98s)
    --- PASS: TestAccConnectQueue_serial/basic (84.38s)
    --- SKIP: TestAccConnectQueue_serial/disappears (0.00s)
    --- PASS: TestAccConnectQueue_serial/update_hours_of_operation_id (101.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	550.084s

@breathingdust breathingdust merged commit d32049d into hashicorp:main Feb 28, 2022
@github-actions github-actions bot added this to the v4.3.0 milestone Feb 28, 2022
@GlennChia GlennChia deleted the f-aws_connect_queue-update-quick-connect-ids branch February 28, 2022 16:58
@ewbankkit ewbankkit mentioned this pull request Feb 28, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/connect Issues and PRs that pertain to the connect service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add update support for quick_connect_ids attribute for aws_connect_queue resource
4 participants