Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_cloudformation_stack: use retry logic on IAM role error #22840

Merged
merged 4 commits into from
Jan 31, 2022
Merged

aws_cloudformation_stack: use retry logic on IAM role error #22840

merged 4 commits into from
Jan 31, 2022

Conversation

thatderek
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22834

Output from acceptance testing:

➜  terraform-provider-aws git:(master) ✗ make testacc TESTS=TestAccCloudFormationStack_withIAM PKG=cloudformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStack_withIAM'  -timeout 180m
=== RUN   TestAccCloudFormationStack_withIAM
=== PAUSE TestAccCloudFormationStack_withIAM
=== CONT  TestAccCloudFormationStack_withIAM
--- PASS: TestAccCloudFormationStack_withIAM (67.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	67.927s
➜  terraform-provider-aws git:(master) ✗

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/cloudformation Issues and PRs that pertain to the cloudformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jan 30, 2022
@thatderek thatderek force-pushed the cloudformation-stack-iam-fix branch 2 times, most recently from d07fbdb to 5789bba Compare January 30, 2022 22:40
@ewbankkit ewbankkit added eventual-consistency Pertains to eventual consistency issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 31, 2022
ewbankkit
ewbankkit approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFormationStack_basic\|TestAccCloudFormationStack_allAttributes' PKG=cloudformation 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20  -run=TestAccCloudFormationStack_basic\|TestAccCloudFormationStack_allAttributes -timeout 180m
=== RUN   TestAccCloudFormationStack_basic
=== PAUSE TestAccCloudFormationStack_basic
=== RUN   TestAccCloudFormationStack_allAttributes
=== PAUSE TestAccCloudFormationStack_allAttributes
=== CONT  TestAccCloudFormationStack_basic
=== CONT  TestAccCloudFormationStack_allAttributes
--- PASS: TestAccCloudFormationStack_basic (72.39s)
--- PASS: TestAccCloudFormationStack_allAttributes (87.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	91.188s

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jan 31, 2022
@ewbankkit
Copy link
Contributor

@thatderek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f9b8ec5 into hashicorp:main Jan 31, 2022
@github-actions github-actions bot added this to the v3.75.0 milestone Jan 31, 2022
@ewbankkit ewbankkit modified the milestones: v3.75.0, v4.0.0 Feb 1, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
eventual-consistency Pertains to eventual consistency issues. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

aws_cloudformation_stack may need retry logic when utilizing iam_role_arn attribute
2 participants
@thatderek @ewbankkit