Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_imagebuilder_distribution_configuration - add support for launch template configurations #22842

Conversation

kamilturek
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19046.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration" PKG_NAME=internal/service/imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration -timeout 180m
=== RUN   TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration
=== PAUSE TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration
=== CONT  TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration
--- PASS: TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration (58.98s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       66.795s

@github-actions github-actions bot added service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jan 30, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 31, 2022
@kamilturek kamilturek marked this pull request as ready for review January 31, 2022 22:44
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccImageBuilderDistributionConfiguration_ PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run='TestAccImageBuilderDistributionConfiguration_'  -timeout 180m
=== RUN   TestAccImageBuilderDistributionConfiguration_basic
=== PAUSE TestAccImageBuilderDistributionConfiguration_basic
=== RUN   TestAccImageBuilderDistributionConfiguration_disappears
=== PAUSE TestAccImageBuilderDistributionConfiguration_disappears
=== RUN   TestAccImageBuilderDistributionConfiguration_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_description
=== RUN   TestAccImageBuilderDistributionConfiguration_distribution
=== PAUSE TestAccImageBuilderDistributionConfiguration_distribution
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== RUN   TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration
=== PAUSE TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration
=== RUN   TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== PAUSE TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== RUN   TestAccImageBuilderDistributionConfiguration_tags
=== PAUSE TestAccImageBuilderDistributionConfiguration_tags
=== CONT  TestAccImageBuilderDistributionConfiguration_basic
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== CONT  TestAccImageBuilderDistributionConfiguration_tags
=== CONT  TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== CONT  TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== CONT  TestAccImageBuilderDistributionConfiguration_description
=== CONT  TestAccImageBuilderDistributionConfiguration_disappears
=== CONT  TestAccImageBuilderDistributionConfiguration_distribution
=== CONT  TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
    distribution_configuration_test.go:564: Step 1/3 error: Error running apply: exit status 1
        
        Error: Error creating License Manager license configuration: ResourceLimitExceededException: You have reached the maximum allowed number of license configurations created in one day.
        
          with aws_licensemanager_license_configuration.test,
          on terraform_plugin_test.tf line 4, in resource "aws_licensemanager_license_configuration" "test":
           4: resource "aws_licensemanager_license_configuration" "test" {
        
--- FAIL: TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs (16.78s)
--- PASS: TestAccImageBuilderDistributionConfiguration_disappears (38.51s)
--- PASS: TestAccImageBuilderDistributionConfiguration_basic (43.06s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups (47.26s)
--- PASS: TestAccImageBuilderDistributionConfiguration_distribution (51.27s)
--- PASS: TestAccImageBuilderDistributionConfiguration_description (66.68s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs (69.67s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description (70.31s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name (71.08s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags (71.11s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs (71.35s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description (71.45s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository (71.55s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags (71.58s)
--- PASS: TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration (72.33s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID (74.63s)
--- PASS: TestAccImageBuilderDistributionConfiguration_tags (80.93s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	84.900s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change.

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0bacb1c into hashicorp:main Feb 1, 2022
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 1, 2022
@kamilturek kamilturek deleted the f-aws_imagebuilder_distribution_configuration-launch-template-configurations branch February 1, 2022 19:39
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add launchTemplateConfigurations section to aws_imagebuilder_distribution_configuration
2 participants