Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ec2_client_vpn_endpoint: Change dns_servers argument from TypeSet to TypeList #22889

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20690.

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short -timeout 180m
=== RUN   TestAccEC2ClientVPNEndpoint_serial
=== PAUSE TestAccEC2ClientVPNEndpoint_serial
=== CONT  TestAccEC2ClientVPNEndpoint_serial
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth
    client_vpn_endpoint_test.go:250: skipping long-running test in short mode
2022/02/01 16:56:02 [WARN] Notifying semaphore without Wait
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuth
    client_vpn_endpoint_test.go:214: skipping long-running test in short mode
2022/02/01 16:56:03 [WARN] Notifying semaphore without Wait
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource
--- PASS: TestAccEC2ClientVPNEndpoint_serial (3.72s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth (0.00s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuth (0.00s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic (29.73s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate (37.05s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags (50.90s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner (52.45s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears (66.68s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (84.39s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup (84.78s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers (99.33s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal (100.79s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService (104.11s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource (104.54s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect (113.54s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth (116.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        124.032s

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 1, 2022
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 1, 2022
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Feb 1, 2022
@YakDriver YakDriver self-assigned this Feb 2, 2022
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order matters. Looks great! 🎉

Output:

% make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short -timeout 180m
--- PASS: TestAccEC2ClientVPNEndpoint_serial (4.87s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuth (0.00s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth (0.00s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears (19.89s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic (22.04s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource (23.46s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (55.74s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags (68.88s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner (71.68s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup (78.56s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService (99.72s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal (104.58s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers (105.93s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate (109.37s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect (118.74s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth (120.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	126.626s

@ewbankkit ewbankkit merged commit 9c833ce into main Feb 2, 2022
@ewbankkit ewbankkit deleted the td-aws_ec2_client_vpn_endpoint-dns_servers-list branch February 2, 2022 16:34
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ec2_client_vpn_endpoint dns_servers input does not preserve order
2 participants