Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsx/ontap_storeage_virtulal_mcahine: Remove deprecadted distinguidshed #22915

Merged
merged 13 commits into from
Feb 3, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 3, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22247
Relates #22246
Relates #22286

Output from acceptance testing:

make testacc TESTS=TestOntapStorageVirtualMachineStateUpgradeV0 PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestOntapStorageVirtualMachineStateUpgradeV0'  -timeout 180m
=== RUN   TestOntapStorageVirtualMachineStateUpgradeV0
2022/02/02 20:27:13 [DEBUG] Attributes before migration: map[string]interface {}{"active_directory_configuration.0.self_managed_active_directory_configuration.0.organizational_unit_distinguidshed_name":"MeArrugoDerrito"}
2022/02/02 20:27:13 [DEBUG] Attributes after migration: map[string]interface {}{"active_directory_configuration.0.self_managed_active_directory_configuration.0.organizational_unit_distinguished_name":"MeArrugoDerrito"}
--- PASS: TestOntapStorageVirtualMachineStateUpgradeV0 (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1.390s
% make testacc TESTS=TestAccFSxOntapStorageVirtualMachine_ PKG=fsx               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOntapStorageVirtualMachine_'  -timeout 180m
--- PASS: TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle (2659.31s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_svmAdminPassword (2660.15s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_basic (2702.16s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_tags (2757.56s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_activeDirectory (2794.72s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_disappears (2865.29s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_name (3167.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	3169.255s

@github-actions github-actions bot added service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Feb 3, 2022
@YakDriver YakDriver changed the title fsx/ontap_storage_virtual_mcahine: Remove deprecated distinguidshed" fsx/ontap_storeage_virtulal_mcahine: Remove deprecadted distinguidshed Feb 3, 2022
@github-actions github-actions bot added generators Relates to code generators. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Feb 3, 2022
@YakDriver YakDriver added this to the v4.0.0 milestone Feb 3, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. size/L Managed by automation to categorize the size of a PR. labels Feb 3, 2022
@gdavison gdavison self-assigned this Feb 3, 2022
@github-actions github-actions bot removed the generators Relates to code generators. label Feb 3, 2022
.changelog/22915.txt Outdated Show resolved Hide resolved
@gdavison gdavison removed their assignment Feb 3, 2022
@gdavison
Copy link
Contributor

gdavison commented Feb 3, 2022

Acceptance test results in Commercial partition

--- PASS: TestOntapStorageVirtualMachineStateUpgradeV0 (0.00s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_activeDirectory (2665.02s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_basic (2666.46s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_tags (2703.71s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle (2725.89s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_disappears (2805.39s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_svmAdminPassword (2889.36s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_name (2947.14s)

YakDriver and others added 3 commits February 3, 2022 15:09
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@YakDriver YakDriver merged commit 04b7c91 into main Feb 3, 2022
@YakDriver YakDriver deleted the td-fsx-ou-distinguidshed branch February 3, 2022 21:19
github-actions bot pushed a commit that referenced this pull request Feb 3, 2022
anGie44 pushed a commit that referenced this pull request Feb 4, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_fsx_ontap_storage_virtual_machine: Remove organizational_unit_distinguidshed_name argument
3 participants