Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2/routes: Remove empty validation #22931

Merged
merged 9 commits into from
Feb 4, 2022
Merged

ec2/routes: Remove empty validation #22931

merged 9 commits into from
Feb 4, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 3, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13943

Output from acceptance testing:

% make testacc TESTS='TestAccEC2DefaultRouteTable_|TestAccEC2RouteTable_|TestAccEC2RouteTableDataSource_|TestAccEC2RouteTablesDataSource_|TestAccEC2Route_|TestAccEC2RouteDataSource_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultRouteTable_|TestAccEC2RouteTable_|TestAccEC2RouteTableDataSource_|TestAccEC2RouteTablesDataSource_|TestAccEC2Route_|TestAccEC2RouteDataSource_'  -timeout 180m
--- SKIP: TestAccEC2Route_ipv4ToCarrierGateway (1.77s)
--- SKIP: TestAccEC2Route_ipv4ToLocalGateway (2.06s)
--- PASS: TestAccEC2Route_Disappears_routeTable (34.00s)
--- PASS: TestAccEC2Route_disappears (36.28s)
--- PASS: TestAccEC2Route_ipv4ToVPCPeeringConnection (40.16s)
--- PASS: TestAccEC2Route_IPv4ToNetworkInterface_unattached (42.89s)
--- PASS: TestAccEC2DefaultRouteTable_basic (44.39s)
--- PASS: TestAccEC2Route_ipv6ToVPCPeeringConnection (50.64s)
--- PASS: TestAccEC2Route_ipv6ToInternetGateway (51.57s)
--- PASS: TestAccEC2Route_IPv6ToNetworkInterface_unattached (53.70s)
--- PASS: TestAccEC2Route_doesNotCrashWithVPCEndpoint (54.19s)
--- PASS: TestAccEC2Route_ipv6ToEgressOnlyInternetGateway (69.07s)
--- PASS: TestAccEC2Route_basic (36.15s)
--- PASS: TestAccEC2RouteTablesDataSource_basic (33.18s)
--- PASS: TestAccEC2RouteTable_prefixListToInternetGateway (37.80s)
--- PASS: TestAccEC2Route_ipv6ToVPNGateway (81.77s)
--- PASS: TestAccEC2RouteTable_vpcClassicLink (30.72s)
--- PASS: TestAccEC2Route_ipv4ToVPNGateway (84.75s)
--- PASS: TestAccEC2RouteTable_gatewayVPCEndpoint (46.35s)
--- PASS: TestAccEC2RouteTable_conditionalCIDRBlock (70.36s)
--- PASS: TestAccEC2Route_ipv4ToInstance (106.54s)
--- PASS: TestAccEC2RouteTable_vpcMultipleCIDRs (53.82s)
--- PASS: TestAccEC2RouteTable_disappears (25.27s)
--- SKIP: TestAccEC2RouteDataSource_carrierGatewayID (0.36s)
--- SKIP: TestAccEC2RouteDataSource_localGatewayID (0.65s)
--- PASS: TestAccEC2RouteTable_basic (28.97s)
--- PASS: TestAccEC2RouteTable_Disappears_subnetAssociation (32.41s)
--- SKIP: TestAccEC2RouteTable_ipv4ToLocalGateway (0.64s)
--- PASS: TestAccEC2RouteTable_IPv6ToNetworkInterface_unattached (49.29s)
--- PASS: TestAccEC2RouteTableDataSource_main (24.06s)
--- PASS: TestAccEC2Route_IPv4ToNetworkInterface_attached (124.95s)
--- PASS: TestAccEC2RouteTable_ipv4ToInstance (130.04s)
--- PASS: TestAccEC2RouteTableDataSource_basic (32.65s)
--- PASS: TestAccEC2RouteDataSource_ipv6DestinationCIDR (31.18s)
--- PASS: TestAccEC2RouteTable_requireRouteTarget (15.15s)
--- PASS: TestAccEC2RouteTable_ipv4ToInternetGateway (60.39s)
--- PASS: TestAccEC2RouteTable_ipv4ToVPCPeeringConnection (34.95s)
--- SKIP: TestAccEC2RouteTable_ipv4ToCarrierGateway (0.37s)
--- PASS: TestAccEC2RouteDataSource_gatewayVPCEndpoint (48.20s)
--- PASS: TestAccEC2Route_ipv6ToInstance (164.10s)
--- PASS: TestAccEC2RouteTable_IPv4ToNetworkInterfaces_unattached (115.22s)
--- PASS: TestAccEC2DefaultRouteTable_vpcEndpointAssociation (40.02s)
--- PASS: TestAccEC2Route_IPv4ToNetworkInterface_twoAttachments (185.45s)
--- PASS: TestAccEC2RouteTable_ipv6ToEgressOnlyInternetGateway (60.00s)
--- PASS: TestAccEC2RouteTable_Route_mode (85.22s)
--- PASS: TestAccEC2RouteTable_tags (69.45s)
--- SKIP: TestAccEC2Route_prefixListToLocalGateway (1.30s)
--- PASS: TestAccEC2DefaultRouteTable_prefixListToInternetGateway (61.25s)
--- SKIP: TestAccEC2Route_prefixListToCarrierGateway (0.77s)
--- PASS: TestAccEC2RouteTable_vgwRoutePropagation (99.63s)
--- PASS: TestAccEC2Route_ipv4ToNatGateway (223.11s)
--- PASS: TestAccEC2DefaultRouteTable_tags (67.29s)
--- PASS: TestAccEC2RouteTable_multipleRoutes (207.57s)
--- PASS: TestAccEC2Route_prefixListToVPCPeeringConnection (41.19s)
--- PASS: TestAccEC2Route_prefixListToEgressOnlyInternetGateway (62.20s)
--- PASS: TestAccEC2RouteTable_ipv4ToNatGateway (199.49s)
--- PASS: TestAccEC2DefaultRouteTable_revokeExistingRules (118.16s)
--- PASS: TestAccEC2RouteDataSource_basic (132.23s)
--- PASS: TestAccEC2DefaultRouteTable_Disappears_vpc (22.40s)
--- PASS: TestAccEC2DefaultRouteTable_swap (108.47s)
--- PASS: TestAccEC2DefaultRouteTable_conditionalCIDRBlock (74.66s)
--- PASS: TestAccEC2Route_PrefixListToNetworkInterface_unattached (46.19s)
--- PASS: TestAccEC2DefaultRouteTable_ipv4ToVPCEndpoint (373.17s)
--- SKIP: TestAccEC2Route_ipv6ToLocalGateway (0.67s)
--- PASS: TestAccEC2DefaultRouteTable_Route_mode (98.45s)
--- PASS: TestAccEC2RouteDataSource_destinationPrefixListID (214.82s)
--- PASS: TestAccEC2Route_prefixListToInternetGateway (44.74s)
--- PASS: TestAccEC2Route_localRoute (32.83s)
--- PASS: TestAccEC2Route_PrefixListToNetworkInterface_attached (127.45s)
--- PASS: TestAccEC2Route_conditionalCIDRBlock (71.28s)
--- PASS: TestAccEC2Route_prefixListToVPNGateway (76.69s)
--- PASS: TestAccEC2Route_prefixListToInstance (134.01s)
--- PASS: TestAccEC2Route_ipv6ToTransitGateway (415.92s)
--- PASS: TestAccEC2Route_prefixListToNatGateway (219.16s)
--- PASS: TestAccEC2RouteTable_requireRouteDestination (352.74s)
--- PASS: TestAccEC2Route_ipv4ToTransitGateway (512.41s)
--- PASS: TestAccEC2RouteDataSource_transitGatewayID (439.65s)
--- PASS: TestAccEC2Route_ipv4ToVPCEndpoint (303.44s)
--- PASS: TestAccEC2Route_IPv6Update_target (309.19s)
--- PASS: TestAccEC2DefaultRouteTable_ipv4ToTransitGateway (402.92s)
--- PASS: TestAccEC2RouteTable_ipv4ToTransitGateway (475.05s)
--- PASS: TestAccEC2RouteTable_ipv4ToVPCEndpoint (340.30s)
--- PASS: TestAccEC2Route_prefixListToTransitGateway (451.44s)
--- PASS: TestAccEC2Route_IPv4Update_target (720.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	996.064s

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. labels Feb 3, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 3, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Feb 4, 2022
@ewbankkit ewbankkit self-requested a review February 4, 2022 13:27
ewbankkit
ewbankkit approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2DefaultRouteTable_\|TestAccEC2RouteTable_\|TestAccEC2RouteTableDataSource_\|TestAccEC2RouteTablesDataSource_\|TestAccEC2Route_\|TestAccEC2RouteDataSource_ -short' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2DefaultRouteTable_\|TestAccEC2RouteTable_\|TestAccEC2RouteTableDataSource_\|TestAccEC2RouteTablesDataSource_\|TestAccEC2Route_\|TestAccEC2RouteDataSource_ -short -timeout 180m
=== RUN   TestAccEC2DefaultRouteTable_basic
=== PAUSE TestAccEC2DefaultRouteTable_basic
=== RUN   TestAccEC2DefaultRouteTable_Disappears_vpc
=== PAUSE TestAccEC2DefaultRouteTable_Disappears_vpc
=== RUN   TestAccEC2DefaultRouteTable_Route_mode
=== PAUSE TestAccEC2DefaultRouteTable_Route_mode
=== RUN   TestAccEC2DefaultRouteTable_swap
=== PAUSE TestAccEC2DefaultRouteTable_swap
=== RUN   TestAccEC2DefaultRouteTable_ipv4ToTransitGateway
=== PAUSE TestAccEC2DefaultRouteTable_ipv4ToTransitGateway
=== RUN   TestAccEC2DefaultRouteTable_ipv4ToVPCEndpoint
=== PAUSE TestAccEC2DefaultRouteTable_ipv4ToVPCEndpoint
=== RUN   TestAccEC2DefaultRouteTable_vpcEndpointAssociation
=== PAUSE TestAccEC2DefaultRouteTable_vpcEndpointAssociation
=== RUN   TestAccEC2DefaultRouteTable_tags
=== PAUSE TestAccEC2DefaultRouteTable_tags
=== RUN   TestAccEC2DefaultRouteTable_conditionalCIDRBlock
=== PAUSE TestAccEC2DefaultRouteTable_conditionalCIDRBlock
=== RUN   TestAccEC2DefaultRouteTable_prefixListToInternetGateway
=== PAUSE TestAccEC2DefaultRouteTable_prefixListToInternetGateway
=== RUN   TestAccEC2DefaultRouteTable_revokeExistingRules
=== PAUSE TestAccEC2DefaultRouteTable_revokeExistingRules
=== RUN   TestAccEC2RouteDataSource_basic
=== PAUSE TestAccEC2RouteDataSource_basic
=== RUN   TestAccEC2RouteDataSource_transitGatewayID
=== PAUSE TestAccEC2RouteDataSource_transitGatewayID
=== RUN   TestAccEC2RouteDataSource_ipv6DestinationCIDR
=== PAUSE TestAccEC2RouteDataSource_ipv6DestinationCIDR
=== RUN   TestAccEC2RouteDataSource_localGatewayID
=== PAUSE TestAccEC2RouteDataSource_localGatewayID
=== RUN   TestAccEC2RouteDataSource_carrierGatewayID
=== PAUSE TestAccEC2RouteDataSource_carrierGatewayID
=== RUN   TestAccEC2RouteDataSource_destinationPrefixListID
=== PAUSE TestAccEC2RouteDataSource_destinationPrefixListID
=== RUN   TestAccEC2RouteDataSource_gatewayVPCEndpoint
=== PAUSE TestAccEC2RouteDataSource_gatewayVPCEndpoint
=== RUN   TestAccEC2RouteTableDataSource_basic
=== PAUSE TestAccEC2RouteTableDataSource_basic
=== RUN   TestAccEC2RouteTableDataSource_main
=== PAUSE TestAccEC2RouteTableDataSource_main
=== RUN   TestAccEC2RouteTable_basic
=== PAUSE TestAccEC2RouteTable_basic
=== RUN   TestAccEC2RouteTable_disappears
=== PAUSE TestAccEC2RouteTable_disappears
=== RUN   TestAccEC2RouteTable_Disappears_subnetAssociation
=== PAUSE TestAccEC2RouteTable_Disappears_subnetAssociation
=== RUN   TestAccEC2RouteTable_ipv4ToInternetGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToInternetGateway
=== RUN   TestAccEC2RouteTable_ipv4ToInstance
=== PAUSE TestAccEC2RouteTable_ipv4ToInstance
=== RUN   TestAccEC2RouteTable_ipv6ToEgressOnlyInternetGateway
=== PAUSE TestAccEC2RouteTable_ipv6ToEgressOnlyInternetGateway
=== RUN   TestAccEC2RouteTable_tags
=== PAUSE TestAccEC2RouteTable_tags
=== RUN   TestAccEC2RouteTable_requireRouteDestination
=== PAUSE TestAccEC2RouteTable_requireRouteDestination
=== RUN   TestAccEC2RouteTable_requireRouteTarget
=== PAUSE TestAccEC2RouteTable_requireRouteTarget
=== RUN   TestAccEC2RouteTable_Route_mode
=== PAUSE TestAccEC2RouteTable_Route_mode
=== RUN   TestAccEC2RouteTable_ipv4ToTransitGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToTransitGateway
=== RUN   TestAccEC2RouteTable_ipv4ToVPCEndpoint
=== PAUSE TestAccEC2RouteTable_ipv4ToVPCEndpoint
=== RUN   TestAccEC2RouteTable_ipv4ToCarrierGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToCarrierGateway
=== RUN   TestAccEC2RouteTable_ipv4ToLocalGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToLocalGateway
=== RUN   TestAccEC2RouteTable_ipv4ToVPCPeeringConnection
=== PAUSE TestAccEC2RouteTable_ipv4ToVPCPeeringConnection
=== RUN   TestAccEC2RouteTable_vgwRoutePropagation
=== PAUSE TestAccEC2RouteTable_vgwRoutePropagation
=== RUN   TestAccEC2RouteTable_conditionalCIDRBlock
=== PAUSE TestAccEC2RouteTable_conditionalCIDRBlock
=== RUN   TestAccEC2RouteTable_ipv4ToNatGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToNatGateway
=== RUN   TestAccEC2RouteTable_IPv6ToNetworkInterface_unattached
=== PAUSE TestAccEC2RouteTable_IPv6ToNetworkInterface_unattached
=== RUN   TestAccEC2RouteTable_IPv4ToNetworkInterfaces_unattached
=== PAUSE TestAccEC2RouteTable_IPv4ToNetworkInterfaces_unattached
=== RUN   TestAccEC2RouteTable_vpcMultipleCIDRs
=== PAUSE TestAccEC2RouteTable_vpcMultipleCIDRs
=== RUN   TestAccEC2RouteTable_vpcClassicLink
=== PAUSE TestAccEC2RouteTable_vpcClassicLink
=== RUN   TestAccEC2RouteTable_gatewayVPCEndpoint
=== PAUSE TestAccEC2RouteTable_gatewayVPCEndpoint
=== RUN   TestAccEC2RouteTable_multipleRoutes
=== PAUSE TestAccEC2RouteTable_multipleRoutes
=== RUN   TestAccEC2RouteTable_prefixListToInternetGateway
=== PAUSE TestAccEC2RouteTable_prefixListToInternetGateway
=== RUN   TestAccEC2RouteTablesDataSource_basic
=== PAUSE TestAccEC2RouteTablesDataSource_basic
=== RUN   TestAccEC2Route_basic
=== PAUSE TestAccEC2Route_basic
=== RUN   TestAccEC2Route_disappears
=== PAUSE TestAccEC2Route_disappears
=== RUN   TestAccEC2Route_Disappears_routeTable
=== PAUSE TestAccEC2Route_Disappears_routeTable
=== RUN   TestAccEC2Route_ipv6ToEgressOnlyInternetGateway
=== PAUSE TestAccEC2Route_ipv6ToEgressOnlyInternetGateway
=== RUN   TestAccEC2Route_ipv6ToInternetGateway
=== PAUSE TestAccEC2Route_ipv6ToInternetGateway
=== RUN   TestAccEC2Route_ipv6ToInstance
=== PAUSE TestAccEC2Route_ipv6ToInstance
=== RUN   TestAccEC2Route_IPv6ToNetworkInterface_unattached
=== PAUSE TestAccEC2Route_IPv6ToNetworkInterface_unattached
=== RUN   TestAccEC2Route_ipv6ToVPCPeeringConnection
=== PAUSE TestAccEC2Route_ipv6ToVPCPeeringConnection
=== RUN   TestAccEC2Route_ipv6ToVPNGateway
=== PAUSE TestAccEC2Route_ipv6ToVPNGateway
=== RUN   TestAccEC2Route_ipv4ToVPNGateway
=== PAUSE TestAccEC2Route_ipv4ToVPNGateway
=== RUN   TestAccEC2Route_ipv4ToInstance
=== PAUSE TestAccEC2Route_ipv4ToInstance
=== RUN   TestAccEC2Route_IPv4ToNetworkInterface_unattached
=== PAUSE TestAccEC2Route_IPv4ToNetworkInterface_unattached
=== RUN   TestAccEC2Route_IPv4ToNetworkInterface_attached
=== PAUSE TestAccEC2Route_IPv4ToNetworkInterface_attached
=== RUN   TestAccEC2Route_IPv4ToNetworkInterface_twoAttachments
=== PAUSE TestAccEC2Route_IPv4ToNetworkInterface_twoAttachments
=== RUN   TestAccEC2Route_ipv4ToVPCPeeringConnection
=== PAUSE TestAccEC2Route_ipv4ToVPCPeeringConnection
=== RUN   TestAccEC2Route_ipv4ToNatGateway
=== PAUSE TestAccEC2Route_ipv4ToNatGateway
=== RUN   TestAccEC2Route_doesNotCrashWithVPCEndpoint
=== PAUSE TestAccEC2Route_doesNotCrashWithVPCEndpoint
=== RUN   TestAccEC2Route_ipv4ToTransitGateway
=== PAUSE TestAccEC2Route_ipv4ToTransitGateway
=== RUN   TestAccEC2Route_ipv6ToTransitGateway
=== PAUSE TestAccEC2Route_ipv6ToTransitGateway
=== RUN   TestAccEC2Route_ipv4ToCarrierGateway
=== PAUSE TestAccEC2Route_ipv4ToCarrierGateway
=== RUN   TestAccEC2Route_ipv4ToLocalGateway
=== PAUSE TestAccEC2Route_ipv4ToLocalGateway
=== RUN   TestAccEC2Route_ipv6ToLocalGateway
=== PAUSE TestAccEC2Route_ipv6ToLocalGateway
=== RUN   TestAccEC2Route_conditionalCIDRBlock
=== PAUSE TestAccEC2Route_conditionalCIDRBlock
=== RUN   TestAccEC2Route_IPv4Update_target
=== PAUSE TestAccEC2Route_IPv4Update_target
=== RUN   TestAccEC2Route_IPv6Update_target
=== PAUSE TestAccEC2Route_IPv6Update_target
=== RUN   TestAccEC2Route_ipv4ToVPCEndpoint
=== PAUSE TestAccEC2Route_ipv4ToVPCEndpoint
=== RUN   TestAccEC2Route_localRoute
=== PAUSE TestAccEC2Route_localRoute
=== RUN   TestAccEC2Route_prefixListToInternetGateway
=== PAUSE TestAccEC2Route_prefixListToInternetGateway
=== RUN   TestAccEC2Route_prefixListToVPNGateway
=== PAUSE TestAccEC2Route_prefixListToVPNGateway
=== RUN   TestAccEC2Route_prefixListToInstance
=== PAUSE TestAccEC2Route_prefixListToInstance
=== RUN   TestAccEC2Route_PrefixListToNetworkInterface_unattached
=== PAUSE TestAccEC2Route_PrefixListToNetworkInterface_unattached
=== RUN   TestAccEC2Route_PrefixListToNetworkInterface_attached
=== PAUSE TestAccEC2Route_PrefixListToNetworkInterface_attached
=== RUN   TestAccEC2Route_prefixListToVPCPeeringConnection
=== PAUSE TestAccEC2Route_prefixListToVPCPeeringConnection
=== RUN   TestAccEC2Route_prefixListToNatGateway
=== PAUSE TestAccEC2Route_prefixListToNatGateway
=== RUN   TestAccEC2Route_prefixListToTransitGateway
=== PAUSE TestAccEC2Route_prefixListToTransitGateway
=== RUN   TestAccEC2Route_prefixListToCarrierGateway
=== PAUSE TestAccEC2Route_prefixListToCarrierGateway
=== RUN   TestAccEC2Route_prefixListToLocalGateway
=== PAUSE TestAccEC2Route_prefixListToLocalGateway
=== RUN   TestAccEC2Route_prefixListToEgressOnlyInternetGateway
=== PAUSE TestAccEC2Route_prefixListToEgressOnlyInternetGateway
=== CONT  TestAccEC2DefaultRouteTable_basic
=== CONT  TestAccEC2RouteTable_gatewayVPCEndpoint
=== CONT  TestAccEC2Route_prefixListToEgressOnlyInternetGateway
--- PASS: TestAccEC2DefaultRouteTable_basic (52.67s)
=== CONT  TestAccEC2Route_prefixListToLocalGateway
--- PASS: TestAccEC2RouteTable_gatewayVPCEndpoint (57.44s)
=== CONT  TestAccEC2Route_prefixListToCarrierGateway
=== CONT  TestAccEC2Route_prefixListToLocalGateway
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2Route_prefixListToLocalGateway (8.07s)
=== CONT  TestAccEC2Route_prefixListToTransitGateway
--- PASS: TestAccEC2Route_prefixListToEgressOnlyInternetGateway (63.45s)
=== CONT  TestAccEC2Route_prefixListToNatGateway
--- PASS: TestAccEC2Route_prefixListToCarrierGateway (42.56s)
=== CONT  TestAccEC2Route_prefixListToVPCPeeringConnection
--- PASS: TestAccEC2Route_prefixListToVPCPeeringConnection (39.12s)
=== CONT  TestAccEC2Route_PrefixListToNetworkInterface_attached
--- PASS: TestAccEC2Route_PrefixListToNetworkInterface_attached (145.59s)
=== CONT  TestAccEC2Route_PrefixListToNetworkInterface_unattached
--- PASS: TestAccEC2Route_prefixListToNatGateway (222.03s)
=== CONT  TestAccEC2Route_prefixListToInstance
--- PASS: TestAccEC2Route_PrefixListToNetworkInterface_unattached (48.25s)
=== CONT  TestAccEC2Route_prefixListToVPNGateway
--- PASS: TestAccEC2Route_prefixListToVPNGateway (71.87s)
=== CONT  TestAccEC2Route_prefixListToInternetGateway
--- PASS: TestAccEC2Route_prefixListToInstance (125.76s)
=== CONT  TestAccEC2Route_localRoute
--- PASS: TestAccEC2Route_localRoute (32.54s)
=== CONT  TestAccEC2Route_ipv4ToVPCEndpoint
--- PASS: TestAccEC2Route_prefixListToInternetGateway (44.39s)
=== CONT  TestAccEC2Route_IPv6Update_target
--- PASS: TestAccEC2Route_prefixListToTransitGateway (456.82s)
=== CONT  TestAccEC2Route_IPv4Update_target
--- PASS: TestAccEC2Route_ipv4ToVPCEndpoint (305.74s)
=== CONT  TestAccEC2Route_conditionalCIDRBlock
--- PASS: TestAccEC2Route_IPv6Update_target (314.96s)
=== CONT  TestAccEC2Route_ipv6ToLocalGateway
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2Route_ipv6ToLocalGateway (0.66s)
=== CONT  TestAccEC2Route_ipv4ToLocalGateway
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2Route_ipv4ToLocalGateway (0.57s)
=== CONT  TestAccEC2Route_ipv4ToCarrierGateway
--- PASS: TestAccEC2Route_ipv4ToCarrierGateway (36.30s)
=== CONT  TestAccEC2Route_ipv6ToTransitGateway
--- PASS: TestAccEC2Route_conditionalCIDRBlock (71.30s)
=== CONT  TestAccEC2Route_ipv4ToTransitGateway
--- PASS: TestAccEC2Route_ipv6ToTransitGateway (415.86s)
=== CONT  TestAccEC2Route_doesNotCrashWithVPCEndpoint
--- PASS: TestAccEC2Route_IPv4Update_target (713.35s)
=== CONT  TestAccEC2Route_ipv4ToNatGateway
--- PASS: TestAccEC2Route_ipv4ToTransitGateway (416.25s)
=== CONT  TestAccEC2Route_ipv4ToVPCPeeringConnection
--- PASS: TestAccEC2Route_doesNotCrashWithVPCEndpoint (50.25s)
=== CONT  TestAccEC2Route_IPv4ToNetworkInterface_twoAttachments
--- PASS: TestAccEC2Route_ipv4ToVPCPeeringConnection (36.96s)
=== CONT  TestAccEC2Route_IPv4ToNetworkInterface_attached
--- PASS: TestAccEC2Route_IPv4ToNetworkInterface_twoAttachments (135.75s)
=== CONT  TestAccEC2Route_IPv4ToNetworkInterface_unattached
--- PASS: TestAccEC2Route_IPv4ToNetworkInterface_attached (137.76s)
=== CONT  TestAccEC2Route_ipv4ToInstance
--- PASS: TestAccEC2Route_IPv4ToNetworkInterface_unattached (40.20s)
=== CONT  TestAccEC2Route_ipv4ToVPNGateway
--- PASS: TestAccEC2Route_ipv4ToNatGateway (230.86s)
=== CONT  TestAccEC2Route_ipv6ToVPNGateway
--- PASS: TestAccEC2Route_ipv4ToInstance (94.06s)
=== CONT  TestAccEC2Route_ipv6ToVPCPeeringConnection
--- PASS: TestAccEC2Route_ipv4ToVPNGateway (70.92s)
=== CONT  TestAccEC2Route_IPv6ToNetworkInterface_unattached
--- PASS: TestAccEC2Route_ipv6ToVPNGateway (81.49s)
=== CONT  TestAccEC2Route_ipv6ToInstance
--- PASS: TestAccEC2Route_ipv6ToVPCPeeringConnection (46.72s)
=== CONT  TestAccEC2Route_ipv6ToInternetGateway
--- PASS: TestAccEC2Route_IPv6ToNetworkInterface_unattached (53.37s)
=== CONT  TestAccEC2RouteTable_disappears
--- PASS: TestAccEC2RouteTable_disappears (28.57s)
=== CONT  TestAccEC2Route_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccEC2Route_ipv6ToInternetGateway (47.35s)
=== CONT  TestAccEC2Route_Disappears_routeTable
--- PASS: TestAccEC2Route_Disappears_routeTable (31.19s)
=== CONT  TestAccEC2Route_disappears
--- PASS: TestAccEC2Route_ipv6ToEgressOnlyInternetGateway (64.01s)
=== CONT  TestAccEC2Route_basic
--- PASS: TestAccEC2Route_disappears (32.15s)
=== CONT  TestAccEC2RouteTablesDataSource_basic
--- PASS: TestAccEC2Route_ipv6ToInstance (134.89s)
=== CONT  TestAccEC2RouteTable_prefixListToInternetGateway
--- PASS: TestAccEC2RouteTablesDataSource_basic (32.00s)
=== CONT  TestAccEC2RouteTable_multipleRoutes
--- PASS: TestAccEC2Route_basic (37.31s)
=== CONT  TestAccEC2DefaultRouteTable_revokeExistingRules
--- PASS: TestAccEC2RouteTable_prefixListToInternetGateway (43.77s)
=== CONT  TestAccEC2RouteTable_basic
--- PASS: TestAccEC2RouteTable_basic (28.74s)
=== CONT  TestAccEC2RouteTable_vpcClassicLink
--- PASS: TestAccEC2RouteTable_vpcClassicLink (30.75s)
=== CONT  TestAccEC2RouteTableDataSource_main
--- PASS: TestAccEC2RouteTableDataSource_main (23.59s)
=== CONT  TestAccEC2RouteTable_vpcMultipleCIDRs
--- PASS: TestAccEC2DefaultRouteTable_revokeExistingRules (108.91s)
=== CONT  TestAccEC2RouteTable_IPv4ToNetworkInterfaces_unattached
--- PASS: TestAccEC2RouteTable_vpcMultipleCIDRs (50.86s)
=== CONT  TestAccEC2RouteTable_IPv6ToNetworkInterface_unattached
--- PASS: TestAccEC2RouteTable_multipleRoutes (193.88s)
=== CONT  TestAccEC2RouteTableDataSource_basic
--- PASS: TestAccEC2RouteTable_IPv6ToNetworkInterface_unattached (50.57s)
=== CONT  TestAccEC2RouteDataSource_gatewayVPCEndpoint
--- PASS: TestAccEC2RouteTableDataSource_basic (31.39s)
=== CONT  TestAccEC2RouteDataSource_destinationPrefixListID
--- PASS: TestAccEC2RouteTable_IPv4ToNetworkInterfaces_unattached (115.04s)
=== CONT  TestAccEC2RouteDataSource_carrierGatewayID
--- PASS: TestAccEC2RouteDataSource_carrierGatewayID (33.14s)
=== CONT  TestAccEC2RouteTable_ipv4ToNatGateway
--- PASS: TestAccEC2RouteDataSource_gatewayVPCEndpoint (50.62s)
=== CONT  TestAccEC2RouteDataSource_localGatewayID
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2RouteDataSource_localGatewayID (0.67s)
=== CONT  TestAccEC2RouteTable_conditionalCIDRBlock
--- PASS: TestAccEC2RouteTable_conditionalCIDRBlock (70.64s)
=== CONT  TestAccEC2RouteDataSource_ipv6DestinationCIDR
--- PASS: TestAccEC2RouteDataSource_ipv6DestinationCIDR (33.39s)
=== CONT  TestAccEC2RouteTable_vgwRoutePropagation
--- PASS: TestAccEC2RouteDataSource_destinationPrefixListID (220.67s)
=== CONT  TestAccEC2RouteDataSource_transitGatewayID
--- PASS: TestAccEC2RouteTable_ipv4ToNatGateway (198.76s)
=== CONT  TestAccEC2RouteTable_requireRouteDestination
--- PASS: TestAccEC2RouteTable_vgwRoutePropagation (93.65s)
=== CONT  TestAccEC2RouteDataSource_basic
--- PASS: TestAccEC2RouteDataSource_basic (109.69s)
=== CONT  TestAccEC2RouteTable_tags
--- PASS: TestAccEC2RouteTable_tags (74.70s)
=== CONT  TestAccEC2RouteTable_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccEC2RouteTable_ipv6ToEgressOnlyInternetGateway (60.58s)
=== CONT  TestAccEC2DefaultRouteTable_ipv4ToVPCEndpoint
--- PASS: TestAccEC2RouteTable_requireRouteDestination (290.26s)
=== CONT  TestAccEC2RouteTable_ipv4ToInstance
=== CONT  TestAccEC2DefaultRouteTable_ipv4ToVPCEndpoint
    default_route_table_test.go:265: Step 1/3 error: Error running apply: exit status 1
        
        Error: error waiting for VPC Endpoint (vpce-0b78633b55f2e8cbe) to become available: unexpected state 'failed', wanted target 'available, pendingAcceptance'. last error: AttachInterfaceUnauthorized: VPC endpoint vpce-0b78633b55f2e8cbe is still provisioning.
        
          with aws_vpc_endpoint.test,
          on terraform_plugin_test.tf line 59, in resource "aws_vpc_endpoint" "test":
          59: resource "aws_vpc_endpoint" "test" {
        
--- FAIL: TestAccEC2DefaultRouteTable_ipv4ToVPCEndpoint (117.94s)
=== CONT  TestAccEC2DefaultRouteTable_prefixListToInternetGateway
--- PASS: TestAccEC2RouteDataSource_transitGatewayID (414.25s)
=== CONT  TestAccEC2RouteTable_ipv4ToInternetGateway
--- PASS: TestAccEC2RouteTable_ipv4ToInstance (116.88s)
=== CONT  TestAccEC2RouteTable_Disappears_subnetAssociation
--- PASS: TestAccEC2DefaultRouteTable_prefixListToInternetGateway (65.84s)
=== CONT  TestAccEC2RouteTable_ipv4ToCarrierGateway
--- PASS: TestAccEC2RouteTable_Disappears_subnetAssociation (31.68s)
=== CONT  TestAccEC2RouteTable_ipv4ToVPCPeeringConnection
--- PASS: TestAccEC2RouteTable_ipv4ToInternetGateway (61.98s)
=== CONT  TestAccEC2RouteTable_ipv4ToLocalGateway
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2RouteTable_ipv4ToLocalGateway (0.65s)
=== CONT  TestAccEC2DefaultRouteTable_conditionalCIDRBlock
--- PASS: TestAccEC2RouteTable_ipv4ToCarrierGateway (36.63s)
=== CONT  TestAccEC2DefaultRouteTable_tags
--- PASS: TestAccEC2RouteTable_ipv4ToVPCPeeringConnection (37.13s)
=== CONT  TestAccEC2DefaultRouteTable_vpcEndpointAssociation
--- PASS: TestAccEC2DefaultRouteTable_vpcEndpointAssociation (41.95s)
=== CONT  TestAccEC2RouteTable_ipv4ToTransitGateway
--- PASS: TestAccEC2DefaultRouteTable_conditionalCIDRBlock (68.23s)
=== CONT  TestAccEC2RouteTable_Route_mode
--- PASS: TestAccEC2DefaultRouteTable_tags (66.95s)
=== CONT  TestAccEC2RouteTable_ipv4ToVPCEndpoint
--- PASS: TestAccEC2RouteTable_Route_mode (81.01s)
=== CONT  TestAccEC2DefaultRouteTable_Route_mode
=== CONT  TestAccEC2RouteTable_ipv4ToVPCEndpoint
    route_table_test.go:427: Step 1/2 error: Error running apply: exit status 1
        
        Error: error waiting for VPC Endpoint (vpce-00cbd1973c4d4e48d) to become available: unexpected state 'failed', wanted target 'available, pendingAcceptance'. last error: AttachInterfaceUnauthorized: VPC endpoint vpce-00cbd1973c4d4e48d is still provisioning.
        
          with aws_vpc_endpoint.test,
          on terraform_plugin_test.tf line 50, in resource "aws_vpc_endpoint" "test":
          50: resource "aws_vpc_endpoint" "test" {
        
--- FAIL: TestAccEC2RouteTable_ipv4ToVPCEndpoint (159.72s)
=== CONT  TestAccEC2DefaultRouteTable_ipv4ToTransitGateway
--- PASS: TestAccEC2DefaultRouteTable_Route_mode (86.12s)
=== CONT  TestAccEC2DefaultRouteTable_Disappears_vpc
--- PASS: TestAccEC2DefaultRouteTable_Disappears_vpc (19.23s)
=== CONT  TestAccEC2RouteTable_requireRouteTarget
--- PASS: TestAccEC2RouteTable_requireRouteTarget (15.31s)
=== CONT  TestAccEC2DefaultRouteTable_swap
--- PASS: TestAccEC2DefaultRouteTable_swap (103.46s)
--- PASS: TestAccEC2RouteTable_ipv4ToTransitGateway (424.71s)
--- PASS: TestAccEC2DefaultRouteTable_ipv4ToTransitGateway (426.56s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	3277.623s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change - we frequently get them in nightly CI.

@YakDriver YakDriver merged commit 366e17e into main Feb 4, 2022
@YakDriver YakDriver deleted the td-empty-valid-routes branch February 4, 2022 15:30
@YakDriver YakDriver added this to the v4.0.0 milestone Feb 4, 2022
github-actions bot pushed a commit that referenced this pull request Feb 4, 2022
Update CHANGELOG.md for #22931
6b67ccc
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced Feb 24, 2022
Closed
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YakDriver @ewbankkit