Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ami_copy, r/ami_from_instance: add boot_mode and ebs_block_device.outpost_arn args inherited from AMI resource #22972

Merged
merged 6 commits into from
Feb 7, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 6, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22971
Relates: #22939

Output from acceptance testing:

--- PASS: TestAccEC2AMICopy_basic (379.75s)

--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (366.97s)

--- PASS: TestAccEC2AMIFromInstance_basic (270.19s)
--- PASS: TestAccEC2AMIFromInstance_disappears (275.39s)
--- PASS: TestAccEC2AMIFromInstance_tags (348.59s)

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. labels Feb 6, 2022
@anGie44 anGie44 marked this pull request as ready for review February 6, 2022 16:36
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Feb 6, 2022
@anGie44 anGie44 changed the title r/ami_copy: add boot_mode and destination.outpost_arn args inherited from AMI resource r/ami_copy, r/ami_from_instance: add boot_mode and ebs_block_device.outpost_arn args inherited from AMI resource Feb 6, 2022
@anGie44 anGie44 added this to the v4.0.0 milestone Feb 6, 2022
@anGie44 anGie44 added the crash Results from or addresses a Terraform crash or kernel panic. label Feb 7, 2022
.changelog/22972.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2AMICopy_\|TestAccEC2AMIFromInstance_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2AMICopy_\|TestAccEC2AMIFromInstance_ -timeout 180m
=== RUN   TestAccEC2AMICopy_basic
=== PAUSE TestAccEC2AMICopy_basic
=== RUN   TestAccEC2AMICopy_description
=== PAUSE TestAccEC2AMICopy_description
=== RUN   TestAccEC2AMICopy_enaSupport
=== PAUSE TestAccEC2AMICopy_enaSupport
=== RUN   TestAccEC2AMICopy_destinationOutpost
=== PAUSE TestAccEC2AMICopy_destinationOutpost
=== RUN   TestAccEC2AMICopy_tags
=== PAUSE TestAccEC2AMICopy_tags
=== RUN   TestAccEC2AMIFromInstance_basic
=== PAUSE TestAccEC2AMIFromInstance_basic
=== RUN   TestAccEC2AMIFromInstance_tags
=== PAUSE TestAccEC2AMIFromInstance_tags
=== RUN   TestAccEC2AMIFromInstance_disappears
=== PAUSE TestAccEC2AMIFromInstance_disappears
=== CONT  TestAccEC2AMICopy_basic
=== CONT  TestAccEC2AMICopy_tags
=== CONT  TestAccEC2AMIFromInstance_disappears
=== CONT  TestAccEC2AMIFromInstance_tags
=== CONT  TestAccEC2AMIFromInstance_basic
=== CONT  TestAccEC2AMICopy_enaSupport
=== CONT  TestAccEC2AMICopy_destinationOutpost
=== CONT  TestAccEC2AMICopy_description
=== CONT  TestAccEC2AMICopy_destinationOutpost
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2AMICopy_destinationOutpost (2.20s)
--- PASS: TestAccEC2AMIFromInstance_disappears (307.12s)
--- PASS: TestAccEC2AMIFromInstance_basic (332.98s)
--- PASS: TestAccEC2AMICopy_enaSupport (384.90s)
--- PASS: TestAccEC2AMICopy_basic (387.34s)
--- PASS: TestAccEC2AMICopy_description (390.32s)
--- PASS: TestAccEC2AMIFromInstance_tags (396.20s)
--- PASS: TestAccEC2AMICopy_tags (432.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	436.095s
% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears' PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears -timeout 180m
=== RUN   TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== PAUSE TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
=== CONT  TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears
--- PASS: TestAccAutoScalingLaunchConfiguration_RootBlockDevice_amiDisappears (407.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	410.884s

@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Feb 7, 2022
@anGie44 anGie44 merged commit 84311ac into main Feb 7, 2022
@anGie44 anGie44 deleted the b-ami-copy-boot-mode-and-outpost-arn branch February 7, 2022 17:20
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants