Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket_lifecycle_configuration: correctly configure filter tag and add and block documentation #23252

Merged
merged 6 commits into from
Feb 17, 2022
Merged

r/s3_bucket_lifecycle_configuration: correctly configure filter tag and add and block documentation #23252

merged 6 commits into from
Feb 17, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 17, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23239

Output from acceptance testing:

--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_Tag (193.92s)

--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering (197.49s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering (219.40s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly (281.11s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering (332.06s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa (193.00s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering (193.25s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock (193.54s)
--- PASS: TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload (273.25s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration (194.30s)
--- PASS: TestAccS3BucketLifecycleConfiguration_prefix (203.91s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (54.16s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition (193.61s)
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules (193.32s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disableRule (327.59s)
--- PASS: TestAccS3BucketLifecycleConfiguration_filterWithPrefix (272.06s)

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. labels Feb 17, 2022
@anGie44 anGie44 mentioned this pull request Feb 17, 2022
Closed
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 17, 2022
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Feb 17, 2022
@anGie44 anGie44 changed the title r/s3_bucket_lifecycle_configuration: add and block config details r/s3_bucket_lifecycle_configuration: correctly configure filter tag and add and` block documentation Feb 17, 2022
@anGie44 anGie44 changed the title r/s3_bucket_lifecycle_configuration: correctly configure filter tag and add and` block documentation r/s3_bucket_lifecycle_configuration: correctly configure filter tag and add and block documentation Feb 17, 2022
@anGie44 anGie44 force-pushed the b-s3-bucket-lifecycle-configuration-filter-tags branch from 26c561f to b431de6 Compare February 17, 2022 19:37
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Feb 17, 2022
@anGie44 anGie44 added this to the v4.2.0 milestone Feb 17, 2022
@anGie44 anGie44 marked this pull request as ready for review February 17, 2022 19:47
@YakDriver YakDriver self-assigned this Feb 17, 2022
YakDriver
YakDriver approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPB 🎉

% make testacc TESTS=TestAccS3BucketLifecycle PKG=s3 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 5 -run='TestAccS3BucketLifecycle'  -timeout 180m
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (198.58s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering (198.96s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering (199.20s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly (279.70s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering (335.33s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa (195.21s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering (195.65s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock (194.92s)
--- PASS: TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload (275.88s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (54.79s)
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules (195.78s)
--- PASS: TestAccS3BucketLifecycleConfiguration_prefix (192.20s)
--- PASS: TestAccS3BucketLifecycleConfiguration_filterWithPrefix (276.06s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disableRule (340.00s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_Tag (203.28s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition (191.94s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration (192.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	861.198s

website/docs/r/s3_bucket_lifecycle_configuration.html.markdown
@@ -208,6 +190,15 @@ The `transition` configuration block supports the following arguments:
* `days` - (Optional, Conflicts with `date`) The number of days after creation when objects are transitioned to the specified storage class. The value must be a positive integer. If both `days` and `date` are not specified, defaults to `0`. Valid values depend on `storage_class`, see [Transition objects using Amazon S3 Lifecycle](https://docs.aws.amazon.com/AmazonS3/latest/userguide/lifecycle-transition-general-considerations.html) for more details.
* `storage_class` - The class of storage used to store the object. Valid Values: `GLACIER`, `STANDARD_IA`, `ONEZONE_IA`, `INTELLIGENT_TIERING`, `DEEP_ARCHIVE`, `GLACIER_IR`.

### and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the upgrade guide having filter examples using and and just prefix.

@anGie44 anGie44 merged commit 4ef641a into main Feb 17, 2022
@anGie44 anGie44 deleted the b-s3-bucket-lifecycle-configuration-filter-tags branch February 17, 2022 22:52
github-actions bot pushed a commit that referenced this pull request Feb 17, 2022
Update CHANGELOG.md for #23252
00620da
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@Tenzer Tenzer mentioned this pull request Feb 21, 2022
Closed
@Tenzer
Copy link
Contributor

Tenzer commented Feb 21, 2022

The bug reported in #23132 was for version 4.0.0, was fixed in 4.1.0 and is now a problem again in 4.2.0, likely due to the change in this PR. Could the bug be reopened again, please?

@anGie44
Copy link
Contributor Author

anGie44 commented Feb 22, 2022

Hi @Tenzer 👋 , please see my latest comment in #23132 . based on your reply there, we can further evaluate next steps.

This was referenced Mar 8, 2022
Closed
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.

aws_s3_bucket_lifecycle_configuration filter: tag(s)
3 participants
@anGie44 @Tenzer @YakDriver