Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket_lifecycle_configuration: improve documentation and officially deprecate prefix #23325

Merged
merged 2 commits into from Feb 23, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 23, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23299
Relates #23228

Description:

  • The prefix argument is deprecated as suggested in the documentation; AWS has already announced its deprecation.
  • The resource documentation examples are enhanced to encourage filter use and provide more specifics on how to use filtering based on use-case

Output from acceptance testing:

N/A

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. labels Feb 23, 2022
@anGie44 anGie44 marked this pull request as ready for review February 23, 2022 02:01
@anGie44 anGie44 changed the title r/s3_bucket_lifecycle_configuration: improve documentation and match … r/s3_bucket_lifecycle_configuration: improve documentation and officially deprecate prefix Feb 23, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccS3BucketLifecycleConfiguration_basic\|TestAccS3BucketLifecycleConfiguration_prefix' PKG=s3    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3BucketLifecycleConfiguration_basic\|TestAccS3BucketLifecycleConfiguration_prefix -timeout 180m
=== RUN   TestAccS3BucketLifecycleConfiguration_basic
=== PAUSE TestAccS3BucketLifecycleConfiguration_basic
=== RUN   TestAccS3BucketLifecycleConfiguration_prefix
=== PAUSE TestAccS3BucketLifecycleConfiguration_prefix
=== CONT  TestAccS3BucketLifecycleConfiguration_basic
=== CONT  TestAccS3BucketLifecycleConfiguration_prefix
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (195.87s)
--- PASS: TestAccS3BucketLifecycleConfiguration_prefix (195.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	200.064s

@anGie44 anGie44 added this to the v4.3.0 milestone Feb 23, 2022
@anGie44 anGie44 merged commit 1d268ac into main Feb 23, 2022
@anGie44 anGie44 deleted the e-s3-bucket-lifecycle-configuration branch February 23, 2022 14:05
github-actions bot pushed a commit that referenced this pull request Feb 23, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants