Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/f aws grafana license association #23401

Conversation

AlexanderSchiff
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16789

Output from acceptance testing (I didn't run the enterprise test):

$ make testacc TESTS=TestAccGrafana_serial PKG=grafana
=== RUN   TestAccGrafana_serial
--- FAIL: TestAccGrafana_serial (1648.35s)
=== RUN   TestAccGrafana_serial/Workspace
    --- FAIL: TestAccGrafana_serial/Workspace (1222.37s)
=== RUN   TestAccGrafana_serial/Workspace/disappears
        --- PASS: TestAccGrafana_serial/Workspace/disappears (184.00s)
=== RUN   TestAccGrafana_serial/Workspace/organization
        --- PASS: TestAccGrafana_serial/Workspace/organization (177.26s)
=== RUN   TestAccGrafana_serial/Workspace/dataSources
    workspace_test.go:201: Step 1/2 error: Check failed: 1 error occurred:
        	* Check 2/20 error: aws_grafana_workspace.test: Attribute 'arn' didn't match "arn:aws:grafana:us-east-2:ACCT:/workspaces/.+", got "arn:aws:grafana::ACCT:/workspaces/g-cbc0b35aad"
        
        --- FAIL: TestAccGrafana_serial/Workspace/dataSources (164.46s)

=== RUN   TestAccGrafana_serial/Workspace/permissionType
        --- PASS: TestAccGrafana_serial/Workspace/permissionType (184.93s)
=== RUN   TestAccGrafana_serial/Workspace/notificationDestinations
        --- PASS: TestAccGrafana_serial/Workspace/notificationDestinations (183.10s)
=== RUN   TestAccGrafana_serial/Workspace/saml
    workspace_test.go:56: Step 1/2 error: Check failed: 1 error occurred:
        	* Check 2/17 error: aws_grafana_workspace.test: Attribute 'arn' didn't match "arn:aws:grafana:us-east-2:ACCT:/workspaces/.+", got "arn:aws:grafana::ACCT:/workspaces/g-4d967fd914"
        

        --- FAIL: TestAccGrafana_serial/Workspace/saml (163.89s)

=== RUN   TestAccGrafana_serial/Workspace/sso
    workspace_test.go:98: Step 1/2 error: Check failed: 1 error occurred:
        	* Check 2/17 error: aws_grafana_workspace.test: Attribute 'arn' didn't match "arn:aws:grafana:us-east-2:ACCT:/workspaces/.+", got "arn:aws:grafana::ACCT:/workspaces/g-d8abd47428"
        
        --- FAIL: TestAccGrafana_serial/Workspace/sso (164.74s)


=== RUN   TestAccGrafana_serial/DataSource
    --- PASS: TestAccGrafana_serial/DataSource (169.73s)
=== RUN   TestAccGrafana_serial/DataSource/basic
        --- PASS: TestAccGrafana_serial/DataSource/basic (169.73s)
=== RUN   TestAccGrafana_serial/LicenseAssociation
    --- PASS: TestAccGrafana_serial/LicenseAssociation (256.25s)
=== RUN   TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial
        --- PASS: TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial (256.25s)

FAIL

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/grafana Issues and PRs that pertain to the grafana service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Feb 26, 2022
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 1, 2022
@ewbankkit ewbankkit added this to the Roadmap milestone Mar 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccGrafana_serial/LicenseAssociation PKG=grafana
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20 -run='TestAccGrafana_serial/LicenseAssociation'  -timeout 180m
=== RUN   TestAccGrafana_serial
=== RUN   TestAccGrafana_serial/LicenseAssociation
=== RUN   TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial
--- PASS: TestAccGrafana_serial (241.50s)
    --- PASS: TestAccGrafana_serial/LicenseAssociation (241.50s)
        --- PASS: TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial (241.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	244.962s

@ewbankkit
Copy link
Contributor

@AlexanderSchiff Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0e0a854 into hashicorp:main Mar 1, 2022
@github-actions github-actions bot modified the milestones: Roadmap, v4.4.0 Mar 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/grafana Issues and PRs that pertain to the grafana service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants