Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route: NAT Gateway targets support IPv6 destinations #23427

Merged
merged 4 commits into from
Mar 2, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 1, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23413.

Output from acceptance testing:

% make testacc TESTS=TestAccEC2Route_ipv6ToNatGateway PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Route_ipv6ToNatGateway'  -timeout 180m
=== RUN   TestAccEC2Route_ipv6ToNatGateway
=== PAUSE TestAccEC2Route_ipv6ToNatGateway
=== CONT  TestAccEC2Route_ipv6ToNatGateway
--- PASS: TestAccEC2Route_ipv6ToNatGateway (191.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	195.021s

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 1, 2022
…y cannot be the next hop for an IPv6 destination CIDR block outside the CIDR range 64:ff9b::/96 or IPv6 prefix list.' error.
@YakDriver YakDriver self-assigned this Mar 2, 2022
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

% make testacc TESTS=TestAccEC2Route_ipv6ToNatGateway PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Route_ipv6ToNatGateway'  -timeout 180m
=== RUN   TestAccEC2Route_ipv6ToNatGateway
=== PAUSE TestAccEC2Route_ipv6ToNatGateway
=== CONT  TestAccEC2Route_ipv6ToNatGateway
--- PASS: TestAccEC2Route_ipv6ToNatGateway (245.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	247.459s

@ewbankkit ewbankkit merged commit 75ee0fe into main Mar 2, 2022
@ewbankkit ewbankkit deleted the f-aws_route-nat_gateway_id-IPv6 branch March 2, 2022 16:41
@github-actions github-actions bot added this to the v4.4.0 milestone Mar 2, 2022
github-actions bot pushed a commit that referenced this pull request Mar 2, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_route: Unable to use destination_ipv6_cidr_block with nat_gateway_id
2 participants