Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Hibernated" as possible pool_state state under autoscaling_group docs. #23772

Merged
merged 3 commits into from Mar 21, 2022
Merged

Add "Hibernated" as possible pool_state state under autoscaling_group docs. #23772

merged 3 commits into from Mar 21, 2022

Conversation

bschaatsbergen
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23752

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Mar 20, 2022
@bschaatsbergen bschaatsbergen changed the title Include "Hibernated" in the pool_state under autoscaling_group docs Add "Hibernated" as possible pool_state state under autoscaling_group docs. Mar 20, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 21, 2022
ewbankkit
ewbankkit approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0377432 into hashicorp:main Mar 21, 2022
@github-actions github-actions bot added this to the v4.7.0 milestone Mar 21, 2022
@bschaatsbergen bschaatsbergen deleted the update-warm-pool-status-docs branch March 21, 2022 13:04
@github-actions
Copy link

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.

AutoScaling Warm Pool Hibernated State Support
2 participants
@bschaatsbergen @ewbankkit