Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_memorydb_parameter_group: new data source #23814

Merged
merged 2 commits into from Mar 22, 2022
Merged

d/aws_memorydb_parameter_group: new data source #23814

merged 2 commits into from Mar 22, 2022

Conversation

roberth-k
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23795

Output from acceptance testing:

$ make testacc PKG=memorydb TESTS=TestAccMemoryDBParameterGroupDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBParameterGroupDataSource_'  -timeout 180m
=== RUN   TestAccMemoryDBParameterGroupDataSource_basic
=== PAUSE TestAccMemoryDBParameterGroupDataSource_basic
=== CONT  TestAccMemoryDBParameterGroupDataSource_basic
--- PASS: TestAccMemoryDBParameterGroupDataSource_basic (8.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   10.389s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Mar 22, 2022
roberth-k added a commit to roberth-k/terraform-provider-aws that referenced this pull request Mar 22, 2022
@roberth-k
add changelog entry for hashicorp#23814
194f7f9
@roberth-k roberth-k force-pushed the d-aws_memorydb_parameter_group branch from 194f7f9 to c65bf16 Compare March 22, 2022 20:33
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 22, 2022
ewbankkit
ewbankkit approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG=memorydb TESTS=TestAccMemoryDBParameterGroupDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBParameterGroupDataSource_'  -timeout 180m
=== RUN   TestAccMemoryDBParameterGroupDataSource_basic
=== PAUSE TestAccMemoryDBParameterGroupDataSource_basic
=== CONT  TestAccMemoryDBParameterGroupDataSource_basic
--- PASS: TestAccMemoryDBParameterGroupDataSource_basic (18.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	23.217s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e32d638 into hashicorp:main Mar 22, 2022
@github-actions github-actions bot added this to the v4.7.0 milestone Mar 22, 2022
@github-actions
Copy link

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/memorydb Issues and PRs that pertain to the memorydb service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth-k @ewbankkit