Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Datasource to list cloudfront origin access identities #24023 #24382

Merged

Conversation

Aegon95
Copy link
Contributor

@Aegon95 Aegon95 commented Apr 24, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24023.

Sample output of the datasource:
image

iam new, please let me know, if changes are required

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Apr 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Aegon95 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added new-data-source Introduces a new data source. labels Apr 25, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 25, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCloudFrontOriginAccessIdentitiesDataSource_ PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontOriginAccessIdentitiesDataSource_'  -timeout 180m
=== RUN   TestAccCloudFrontOriginAccessIdentitiesDataSource_comments
=== PAUSE TestAccCloudFrontOriginAccessIdentitiesDataSource_comments
=== RUN   TestAccCloudFrontOriginAccessIdentitiesDataSource_all
=== PAUSE TestAccCloudFrontOriginAccessIdentitiesDataSource_all
=== CONT  TestAccCloudFrontOriginAccessIdentitiesDataSource_comments
=== CONT  TestAccCloudFrontOriginAccessIdentitiesDataSource_all
--- PASS: TestAccCloudFrontOriginAccessIdentitiesDataSource_comments (19.05s)
--- PASS: TestAccCloudFrontOriginAccessIdentitiesDataSource_all (19.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	25.680s

@ewbankkit
Copy link
Contributor

@Aegon95 Thanks for the contribution 🎉 👏.
I made a couple of changes to match the AWS API and the existing aws_cloudfront_origin_access_identity data source:

  • changed filter to comments (a list of strings)
  • renamed arns to iam_arns

@ewbankkit ewbankkit merged commit 162491c into hashicorp:main Apr 25, 2022
@github-actions github-actions bot added this to the v4.12.0 milestone Apr 25, 2022
@github-actions
Copy link

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add datasource for listing Cloudfront OriginAccessIdentites
2 participants