Amend r/aws_appflow_flow validation for attribute task_properties to avoid conflicting type assumption

[zhelding]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24888.

Output from acceptance testing:

❯ make testacc TESTS=TestAccAppFlowFlow PKG=appflow
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20 -run='TestAccAppFlowFlow'  -timeout 180m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_tags
=== CONT  TestAccAppFlowFlow_TaskProperties
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_disappears (19.57s)
--- PASS: TestAccAppFlowFlow_TaskProperties (20.54s)
--- PASS: TestAccAppFlowFlow_basic (23.52s)
--- PASS: TestAccAppFlowFlow_update (35.47s)
--- PASS: TestAccAppFlowFlow_tags (50.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appflow    50.310s

Unfortunately, we don't have a ValidateFunc that allows us to check the keys and values of a TypeMap object -- except for a simple regex check.

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccAppFlowFlow_ PKG=appflow ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 2 -run='TestAccAppFlowFlow_'  -timeout 180m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_tags
--- PASS: TestAccAppFlowFlow_basic (29.49s)
=== CONT  TestAccAppFlowFlow_TaskProperties
--- PASS: TestAccAppFlowFlow_TaskProperties (25.94s)
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_tags (70.45s)
=== CONT  TestAccAppFlowFlow_disappears
--- PASS: TestAccAppFlowFlow_disappears (23.84s)
--- PASS: TestAccAppFlowFlow_update (45.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	106.874s

[ewbankkit]

Does this require a CHANGELOG entry?

[zhelding]

Does this require a CHANGELOG entry?

Good catch! Should have a bug-fix changelog. Can add one when I'm back in on Thursday.

[github-actions]

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.