Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/redshift_hsm_client_certificate - new resource #24906

Merged
merged 5 commits into from
May 23, 2022
Merged

r/redshift_hsm_client_certificate - new resource #24906

merged 5 commits into from
May 23, 2022

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccRedshiftHsmClientCertificate_disappears PKG=redshift
--- PASS: TestAccRedshiftHsmClientCertificate_disappears (26.38s)
--- PASS: TestAccRedshiftHsmClientCertificate_basic (33.82s)
--- PASS: TestAccRedshiftHsmClientCertificate_tags (79.04s)

@DrFaust92 DrFaust92 changed the title r/redshift_client_certificate - new resource r/redshift_hsm_client_certificate - new resource May 20, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/redshift Issues and PRs that pertain to the redshift service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels May 20, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 20, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review May 20, 2022 17:42
ewbankkit
ewbankkit approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftHsmClientCertificate_' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2  -run=TestAccRedshiftHsmClientCertificate_ -timeout 180m
=== RUN   TestAccRedshiftHsmClientCertificate_basic
=== PAUSE TestAccRedshiftHsmClientCertificate_basic
=== RUN   TestAccRedshiftHsmClientCertificate_tags
=== PAUSE TestAccRedshiftHsmClientCertificate_tags
=== RUN   TestAccRedshiftHsmClientCertificate_disappears
=== PAUSE TestAccRedshiftHsmClientCertificate_disappears
=== CONT  TestAccRedshiftHsmClientCertificate_basic
=== CONT  TestAccRedshiftHsmClientCertificate_disappears
--- PASS: TestAccRedshiftHsmClientCertificate_disappears (17.41s)
=== CONT  TestAccRedshiftHsmClientCertificate_tags
--- PASS: TestAccRedshiftHsmClientCertificate_basic (23.62s)
--- PASS: TestAccRedshiftHsmClientCertificate_tags (48.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	72.758s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit
Copy link
Contributor 

% make providerlint && make golangci-lint         
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

@ewbankkit ewbankkit merged commit 63ac5cd into hashicorp:main May 23, 2022
@github-actions github-actions bot added this to the v4.16.0 milestone May 23, 2022
@github-actions
Copy link

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 mentioned this pull request May 28, 2022
Open
@DrFaust92 DrFaust92 deleted the redshift-hsm-client-cert branch June 23, 2022 06:10
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/redshift Issues and PRs that pertain to the redshift service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DrFaust92 @ewbankkit